* [Re-RFA PATCH] make some of the newer tests assemblable onECOFF.
@ 2001-10-24 11:55 cgd
2001-10-24 12:15 ` [Re-RFA PATCH] make some of the newer tests assemblable on ECOFF Eric Christopher
0 siblings, 1 reply; 2+ messages in thread
From: cgd @ 2001-10-24 11:55 UTC (permalink / raw)
To: binutils; +Cc: r.sandiford
See:
http://sources.redhat.com/ml/binutils/2001-08/msg00124.html
for background, some of the original msg & the patch included below.
I let it get dropped on the floor, but I've recently re-tested things.
It doesn't break anything new for any of the targets I tested (my
standard 12, tested in this case w/ gmake && gmake check 8-), but it
did point out a couple of issues elsewhere
( http://sources.redhat.com/ml/binutils/2001-10/msg00335.html ,
http://sources.redhat.com/ml/binutils/2001-10/msg00442.html ).
Anyway, any objections? Seems fairly straightforward to me... 8-)
chris
== original message and patch ==
[ ... ]
It changes uses of .4byte to .word (the former seems to be supported
in ELF only?). I don't believe there could be negative consequences
from this part; .word generates 4-byte values on MIPS.
It also removes the .size directives which differ in usage from ELF to
ECOFF. This caused me some concern, but causes no failures with the
existing tests.
Comments?
chris
=====
for gas/testsuite/ChangeLog:
2001-08-07 Chris Demetriou <cgd@broadcom.com>
* gas/mips/mips-abi32-pic.s: Use ".word" rather than ".4byte".
Delete use of ".size".
* gas/mips/mips-abi32.s: Likewise.
* gas/mips/mips-gp32-fp32-pic.s: Likewise.
* gas/mips/mips-gp32-fp32.s: Likewise.
* gas/mips/mips-gp32-fp64-pic.s: Likewise.
* gas/mips/mips-gp32-fp64.s: Likewise.
* gas/mips/mips-gp64-fp32-pic.s: Likewise.
* gas/mips/mips-gp64-fp32.s: Likewise.
* gas/mips/mips-gp64-fp64-pic.s: Likewise.
* gas/mips/mips-gp64-fp64.s: Likewise.
Index: gas/mips/mips-abi32-pic.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-abi32-pic.s,v
retrieving revision 1.2
diff -c -r1.2 mips-abi32-pic.s
*** mips-abi32-pic.s 2001/08/05 00:53:28 1.2
--- mips-abi32-pic.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
.ent func
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
.ent func
Index: gas/mips/mips-abi32.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-abi32.s,v
retrieving revision 1.2
diff -c -r1.2 mips-abi32.s
*** mips-abi32.s 2001/08/05 00:53:28 1.2
--- mips-abi32.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
func:
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
func:
Index: gas/mips/mips-gp32-fp32-pic.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp32-fp32-pic.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp32-fp32-pic.s
*** mips-gp32-fp32-pic.s 2001/08/05 00:53:28 1.2
--- mips-gp32-fp32-pic.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
.ent func
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
.ent func
Index: gas/mips/mips-gp32-fp32.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp32-fp32.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp32-fp32.s
*** mips-gp32-fp32.s 2001/08/05 00:53:28 1.2
--- mips-gp32-fp32.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
func:
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
func:
Index: gas/mips/mips-gp32-fp64-pic.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp32-fp64-pic.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp32-fp64-pic.s
*** mips-gp32-fp64-pic.s 2001/08/05 00:53:28 1.2
--- mips-gp32-fp64-pic.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
.ent func
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
.ent func
Index: gas/mips/mips-gp32-fp64.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp32-fp64.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp32-fp64.s
*** mips-gp32-fp64.s 2001/08/05 00:53:28 1.2
--- mips-gp32-fp64.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
func:
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
func:
Index: gas/mips/mips-gp64-fp32-pic.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp64-fp32-pic.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp64-fp32-pic.s
*** mips-gp64-fp32-pic.s 2001/08/05 00:53:28 1.2
--- mips-gp64-fp32-pic.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
.ent func
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
.ent func
Index: gas/mips/mips-gp64-fp32.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp64-fp32.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp64-fp32.s
*** mips-gp64-fp32.s 2001/08/05 00:53:28 1.2
--- mips-gp64-fp32.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
func:
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
func:
Index: gas/mips/mips-gp64-fp64-pic.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp64-fp64-pic.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp64-fp64-pic.s
*** mips-gp64-fp64-pic.s 2001/08/05 00:53:28 1.2
--- mips-gp64-fp64-pic.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
.ent func
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
.ent func
Index: gas/mips/mips-gp64-fp64.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips-gp64-fp64.s,v
retrieving revision 1.2
diff -c -r1.2 mips-gp64-fp64.s
*** mips-gp64-fp64.s 2001/08/05 00:53:28 1.2
--- mips-gp64-fp64.s 2001/08/07 22:26:33
***************
*** 1,14 ****
.sdata
! shared: .4byte 11
.data
- .size unshared,16
unshared:
! .4byte 1
! .4byte 2
! .4byte 3
! .4byte 4
.text
func:
--- 1,13 ----
.sdata
! shared: .word 11
.data
unshared:
! .word 1
! .word 2
! .word 3
! .word 4
.text
func:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Re-RFA PATCH] make some of the newer tests assemblable on ECOFF.
2001-10-24 11:55 [Re-RFA PATCH] make some of the newer tests assemblable onECOFF cgd
@ 2001-10-24 12:15 ` Eric Christopher
0 siblings, 0 replies; 2+ messages in thread
From: Eric Christopher @ 2001-10-24 12:15 UTC (permalink / raw)
To: cgd; +Cc: binutils, r.sandiford
> Anyway, any objections? Seems fairly straightforward to me... 8-)
>
> 2001-08-07 Chris Demetriou <cgd@broadcom.com>
>
> * gas/mips/mips-abi32-pic.s: Use ".word" rather than ".4byte".
> Delete use of ".size".
> * gas/mips/mips-abi32.s: Likewise.
> * gas/mips/mips-gp32-fp32-pic.s: Likewise.
> * gas/mips/mips-gp32-fp32.s: Likewise.
> * gas/mips/mips-gp32-fp64-pic.s: Likewise.
> * gas/mips/mips-gp32-fp64.s: Likewise.
> * gas/mips/mips-gp64-fp32-pic.s: Likewise.
> * gas/mips/mips-gp64-fp32.s: Likewise.
> * gas/mips/mips-gp64-fp64-pic.s: Likewise.
> * gas/mips/mips-gp64-fp64.s: Likewise.
No objections.
-eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-10-24 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-24 11:55 [Re-RFA PATCH] make some of the newer tests assemblable onECOFF cgd
2001-10-24 12:15 ` [Re-RFA PATCH] make some of the newer tests assemblable on ECOFF Eric Christopher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).