From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: binutils@sources.redhat.com
Subject: [PATCH] CFLAGS, etc. used for the build system in bfd/doc/
Date: Sun, 13 Feb 2005 16:55:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61L.0502130345550.23762@blysk.ds.pg.gda.pl> (raw)
Hello,
There is a problem with building "chew" in bfd/doc/ when cross-compiling.
The rule used correctly invokes $(CC_FOR_BUILD), but it uses $(CFLAGS),
$(LOADLIBES) and $(LDFLAGS) which specify flags for the host system and
not the build one. This is incorrect and even leads to a failure when a
flag is used that's not recognized by the build compiler (such as
"-march="). Here's an obvious fix. I've removed $(LOADLIBES) altogether
-- anything needed can be supplied in $(LDFLAGS_FOR_BUILD).
2005-02-13 Maciej W. Rozycki <macro@linux-mips.org>
* Makefile.am: Use CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD for
building chew.
* Makefile.in: Regenerate.
OK to apply?
binutils-2.15.94-20050203-chew-for_build.patch
diff -up --recursive --new-file binutils-2.15.94-20050203.macro/bfd/doc/Makefile.am binutils-2.15.94-20050203/bfd/doc/Makefile.am
--- binutils-2.15.94-20050203.macro/bfd/doc/Makefile.am 2004-12-21 05:25:10.000000000 +0000
+++ binutils-2.15.94-20050203/bfd/doc/Makefile.am 2005-02-06 03:09:49.000000000 +0000
@@ -55,10 +55,10 @@ info_TEXINFOS = bfd.texinfo
MKDOC = chew$(EXEEXT_FOR_BUILD)
$(MKDOC): chew.o
- $(CC_FOR_BUILD) -o $(MKDOC) chew.o $(CFLAGS) $(LOADLIBES) $(LDFLAGS)
+ $(CC_FOR_BUILD) -o $(MKDOC) chew.o $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD)
chew.o: chew.c
- $(CC_FOR_BUILD) -c -I.. -I$(srcdir)/.. -I$(srcdir)/../../include -I$(srcdir)/../../intl -I../../intl $(H_CFLAGS) $(CFLAGS) $(srcdir)/chew.c
+ $(CC_FOR_BUILD) -c -I.. -I$(srcdir)/.. -I$(srcdir)/../../include -I$(srcdir)/../../intl -I../../intl $(H_CFLAGS) $(CFLAGS_FOR_BUILD) $(srcdir)/chew.c
protos: libbfd.h libcoff.h bfd.h
next reply other threads:[~2005-02-13 4:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-13 16:55 Maciej W. Rozycki [this message]
2005-02-14 10:11 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61L.0502130345550.23762@blysk.ds.pg.gda.pl \
--to=macro@linux-mips.org \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).