public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: Eric Christopher <echristo@redhat.com>, binutils@sources.redhat.com
Subject: Re: [PATCH] MIPS gas: Fix macro expansions for .set noat
Date: Fri, 18 Feb 2005 00:21:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.61L.0502172102390.28978@blysk.ds.pg.gda.pl> (raw)
In-Reply-To: <20050217175835.GK1757@rembrandt.csv.ica.uni-stuttgart.de>

On Thu, 17 Feb 2005, Thiemo Seufer wrote:

> Ok, this patch converts $at uses in .set noat from warnings to errors.

 How about extracting these bits of test cases that used to be expected to 
trigger warnings into separate cases to test if errors are generated 
correctly?

> I haven't changed the .set nomacro behaviour yet, partially because
> this patch is already big enough, and partially because nomacro isn't
> fully equivalent to noat. Nomacro probably shouldn't fail if the number
> of instructions stays the same.

 That's the whole point IMHO.  A macro that expands into a single 
instruction can be seen as a mere alias and it doesn't violate code length 
or delay slot restrictions.  That is I think it should be allowed, for 
readability if nothing else, to call an instruction "li $2,1" instead of 
"addiu $2,$0,1" even with ".set nomacro" in effect.

  Maciej

  reply	other threads:[~2005-02-17 21:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-16 23:51 Thiemo Seufer
2005-02-17  0:25 ` Maciej W. Rozycki
2005-02-17  1:31   ` Maciej W. Rozycki
2005-02-17  1:34     ` Thiemo Seufer
2005-02-17  2:02       ` Maciej W. Rozycki
2005-02-17  7:10         ` Thiemo Seufer
2005-02-17 13:53           ` Eric Christopher
2005-02-17 20:50             ` Maciej W. Rozycki
2005-02-17 21:33               ` Thiemo Seufer
2005-02-18  0:21                 ` Maciej W. Rozycki [this message]
2005-02-21  2:57                   ` Thiemo Seufer
2005-02-18 23:01                 ` Eric Christopher
2005-02-21  8:21                 ` Thiemo Seufer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61L.0502172102390.28978@blysk.ds.pg.gda.pl \
    --to=macro@linux-mips.org \
    --cc=binutils@sources.redhat.com \
    --cc=echristo@redhat.com \
    --cc=ica2_ts@csv.ica.uni-stuttgart.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).