From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1530 invoked by alias); 17 Feb 2005 21:13:29 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 1451 invoked from network); 17 Feb 2005 21:13:21 -0000 Received: from unknown (HELO pollux.ds.pg.gda.pl) (153.19.208.7) by sourceware.org with SMTP; 17 Feb 2005 21:13:21 -0000 Received: from localhost (localhost [127.0.0.1]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id 98F9DE1CAD; Thu, 17 Feb 2005 22:13:14 +0100 (CET) Received: from pollux.ds.pg.gda.pl ([127.0.0.1]) by localhost (pollux [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 06500-01; Thu, 17 Feb 2005 22:13:14 +0100 (CET) Received: from piorun.ds.pg.gda.pl (piorun.ds.pg.gda.pl [153.19.208.8]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id 3A788E1CAC; Thu, 17 Feb 2005 22:13:14 +0100 (CET) Received: from blysk.ds.pg.gda.pl (macro@blysk.ds.pg.gda.pl [153.19.208.6]) by piorun.ds.pg.gda.pl (8.13.1/8.13.1) with ESMTP id j1HLDJNX003849; Thu, 17 Feb 2005 22:13:19 +0100 Date: Fri, 18 Feb 2005 00:21:00 -0000 From: "Maciej W. Rozycki" To: Thiemo Seufer Cc: Eric Christopher , binutils@sources.redhat.com Subject: Re: [PATCH] MIPS gas: Fix macro expansions for .set noat In-Reply-To: <20050217175835.GK1757@rembrandt.csv.ica.uni-stuttgart.de> Message-ID: References: <20050216154924.GG1757@rembrandt.csv.ica.uni-stuttgart.de> <20050216192153.GH1757@rembrandt.csv.ica.uni-stuttgart.de> <20050217002446.GJ1757@rembrandt.csv.ica.uni-stuttgart.de> <1108624232.4149.13.camel@localhost.localdomain> <20050217175835.GK1757@rembrandt.csv.ica.uni-stuttgart.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Status: Clean X-SW-Source: 2005-02/txt/msg00413.txt.bz2 On Thu, 17 Feb 2005, Thiemo Seufer wrote: > Ok, this patch converts $at uses in .set noat from warnings to errors. How about extracting these bits of test cases that used to be expected to trigger warnings into separate cases to test if errors are generated correctly? > I haven't changed the .set nomacro behaviour yet, partially because > this patch is already big enough, and partially because nomacro isn't > fully equivalent to noat. Nomacro probably shouldn't fail if the number > of instructions stays the same. That's the whole point IMHO. A macro that expands into a single instruction can be seen as a mere alias and it doesn't violate code length or delay slot restrictions. That is I think it should be allowed, for readability if nothing else, to call an instruction "li $2,1" instead of "addiu $2,$0,1" even with ".set nomacro" in effect. Maciej