From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: binutils@sources.redhat.com
Subject: [patch] MIPS: Use the right offset for LO16 in add_got_offset_hilo() (ping)
Date: Thu, 24 Feb 2005 22:31:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61L.0502242005470.23589@blysk.ds.pg.gda.pl> (raw)
Hello,
I've reviewed my pile of patches due to the close 2.16 branch and this
patch is still needed. OK to apply?
Maciej
---------- Forwarded message ----------
Message-ID: <Pine.LNX.4.55.0406281823190.23162@jurand.ds.pg.gda.pl>
Date: Mon, 28 Jun 2004 18:47:46 +0200 (CEST)
From: Maciej W. Rozycki <macro@linux-mips.org>
To: binutils@sources.redhat.com
Subject: [patch] MIPS: Use the right offset for LO16 in
add_got_offset_hilo()
Hello,
This is a follow-on patch to the "mips-hilo-reloc-sort" one. It changes
add_got_offset_hilo() to use the same addend for the LO16 relocation it
emits that is used for the preceding GOT16 one. It's required for the two
relocations to pair.
2004-06-28 Maciej W. Rozycki <macro@linux-mips.org>
* config/tc-mips.c (add_got_offset_hilo): Fix the addend used for
the LO16 reloc so that it pairs with thepreceding GOT16 one.
This has been tested for the mipsel-linux-gnu target with no new
regressions and fixing failures revealed by the "mips-hilo-reloc-sort"
patch in the "la-svr4pic", "lca-svr4pic" and "elf-rel19" test cases.
OK to apply?
Maciej
binutils-2.15.91-20040625-mips-reloc-got-offset.patch
diff -up --recursive --new-file binutils-2.15.91-20040625.macro/gas/config/tc-mips.c binutils-2.15.91-20040625/gas/config/tc-mips.c
--- binutils-2.15.91-20040625.macro/gas/config/tc-mips.c 2004-06-15 03:25:28.000000000 +0000
+++ binutils-2.15.91-20040625/gas/config/tc-mips.c 2004-06-28 00:15:46.000000000 +0000
@@ -4104,7 +4104,9 @@ add_got_offset_hilo (int dest, expressio
mips_optimize = 2;
macro_build_lui (&global, tmp);
mips_optimize = hold_mips_optimize;
+ local->X_add_number = ((local->X_add_number + 0x8000) & 0xffff) - 0x8000;
macro_build (local, ADDRESS_ADDI_INSN, "t,r,j", tmp, tmp, BFD_RELOC_LO16);
+ local->X_add_number = global.X_add_number;
relax_end ();
macro_build (NULL, ADDRESS_ADD_INSN, "d,v,t", dest, dest, tmp);
next reply other threads:[~2005-02-24 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 22:31 Maciej W. Rozycki [this message]
2005-02-26 9:40 ` Eric Christopher
2005-02-28 10:27 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61L.0502242005470.23589@blysk.ds.pg.gda.pl \
--to=macro@linux-mips.org \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).