From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16763 invoked by alias); 29 Aug 2005 09:55:23 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 16649 invoked by uid 22791); 29 Aug 2005 09:55:11 -0000 Received: from pollux.ds.pg.gda.pl (HELO pollux.ds.pg.gda.pl) (153.19.208.7) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 29 Aug 2005 09:55:11 +0000 Received: from localhost (localhost [127.0.0.1]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id 97412E1C8A; Mon, 29 Aug 2005 11:55:03 +0200 (CEST) Received: from pollux.ds.pg.gda.pl ([127.0.0.1]) by localhost (pollux [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 04613-04; Mon, 29 Aug 2005 11:55:03 +0200 (CEST) Received: from piorun.ds.pg.gda.pl (piorun.ds.pg.gda.pl [153.19.208.8]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id C0D62E1C6B; Mon, 29 Aug 2005 11:55:02 +0200 (CEST) Received: from blysk.ds.pg.gda.pl (macro@blysk.ds.pg.gda.pl [153.19.208.6]) by piorun.ds.pg.gda.pl (8.13.3/8.13.1) with ESMTP id j7T9swNN019769; Mon, 29 Aug 2005 11:54:59 +0200 Date: Mon, 29 Aug 2005 09:55:00 -0000 From: "Maciej W. Rozycki" To: Chao-ying Fu Cc: Eric Christopher , "Thekkath, Radhika" , Thiemo Seufer , binutils@sourceware.org Subject: Re: [patch] GAS supports for MIPS32 MT ASE In-Reply-To: <001401c5aa8a$3f2698b0$a914a8c0@MIPS.COM> Message-ID: References: <001401c5aa8a$3f2698b0$a914a8c0@MIPS.COM> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Status: Clean X-SW-Source: 2005-08/txt/msg00383.txt.bz2 On Fri, 26 Aug 2005, Chao-ying Fu wrote: > Could you review this patch? We will revise the patch, if there are issues. Posting patches inline helps commenting significantly... Cutting & pasting for now. *** 220,229 **** {"andi", "t,r,i", 0x30000000, 0xfc000000, WR_t|RD_s, 0, /* b is at the top of the table. */ /* bal is at the top of the table. */ - {"bc0f", "p", 0x41000000, 0xffff0000, CBD|RD_CC, 0, - {"bc0fl", "p", 0x41020000, 0xffff0000, CBL|RD_CC, 0, - {"bc0t", "p", 0x41010000, 0xffff0000, CBD|RD_CC, 0, - {"bc0tl", "p", 0x41030000, 0xffff0000, CBL|RD_CC, 0, {"bc1any2f", "N,p", 0x45200000, 0xffe30000, CBD|RD_CC|FP_S, 0, {"bc1any2t", "N,p", 0x45210000, 0xffe30000, CBD|RD_CC|FP_S, 0, {"bc1any4f", "N,p", 0x45400000, 0xffe30000, CBD|RD_CC|FP_S, 0, --- 223,228 ---- A comment is missing about the instructions having been relocated (like one for "b" and "bal" seen immediately above!). --- 1351,1415 ---- {"subu_s.qb", "d,s,t", 0x7c000150, 0xfc0007ff, WR_d|RD_s|RD_t, {"wrdsp", "s", 0x7c1ffcf8, 0xfc1fffff, RD_s|DSP_VOLA, 0, {"wrdsp", "s,8", 0x7c0004f8, 0xfc1e07ff, RD_s|DSP_VOLA, 0, + /* MIPS MT ASE Instructions. */ + {"dmt", "", 0x41600bc1, 0xffffffff, TRAP, + {"dmt", "t", 0x41600bc1, 0xffe0ffff, TRAP|WR_t, 0, + {"dvpe", "", 0x41600001, 0xffffffff, TRAP, Note that the table is meant to be sorted alphabetically (except from when conflicts arise)... --- 14359,14367 ---- -mdsp generate DSP instructions\n\ -mno-dsp do not generate DSP instructions\n")); fprintf (stream, _("\ + -mt generate MT instructions\n\ + -mno-mt do not generate MT instructions\n")); + fprintf (stream, _("\ -mfix-vr4120 work around certain VR4120 errata\n\ -mfix-vr4130 work around VR4130 mflo/mfhi errata\n\ -mgp32 use 32-bit GPRs, regardless of the chosen ISA\n\ Hmm, there is an inconsistency here -- I think "-mmt/-mno-mt" sounds better than "-mt/-mno-t". dmt dmt $0 dvpe dvpe $1 Testing "dmt" with a non-$0 argument might be a bit more useful to assure `objdump' gets the disassembly right for the single-operand variation. I'll leave the rest to the maintainers... Maciej