From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12896 invoked by alias); 20 Sep 2006 12:40:28 -0000 Received: (qmail 12886 invoked by uid 22791); 20 Sep 2006 12:40:28 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Sep 2006 12:40:23 +0000 Received: (qmail 820 invoked from network); 20 Sep 2006 12:40:21 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Sep 2006 12:40:21 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.63) (envelope-from ) id 1GQ1NE-0002hL-4P; Wed, 20 Sep 2006 12:40:20 +0000 Date: Wed, 20 Sep 2006 14:39:00 -0000 From: "Joseph S. Myers" To: Bridge Wu cc: binutils Subject: Re: iwmmxt2 patch for binutils-2.16.92 In-Reply-To: <246188420609191945h3c0c0a90pee6d5d5f972674fd@mail.gmail.com> Message-ID: References: <246188420609190438l5846aaf2j39ebda2d989108fe@mail.gmail.com> <246188420609191945h3c0c0a90pee6d5d5f972674fd@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00193.txt.bz2 On Wed, 20 Sep 2006, Bridge Wu wrote: > There is a bug when integrating iwmmxt2. wldr[b/h] and wstr[b/h] will > be assembled into illegal instruction if the immediate number is #0. > This is because write_back bit is cleared in md_apply_fix(). I have > fixed it in my patch. > > Test case: > wldrb wr1, [r1], #0 > wldrh wr1, [r1], #0 > wstrb wr1, [r1], #0 > wstrh wr1, [r1], #0 > > Joseph, I did not find the fix to this issue in your patch. Could you > test it and merge it once confirmed? You do not say what you expect these instructions to assemble to, and your patch does not apply cleanly to current binutils CVS mainline so I cannot tell what they assemble to with your patch. They are valid iWMMXt1 instructions without needing an iWMMXt2 patch; with my patch, and with unpatched mainline, they assemble to 00000000 <.text> ec911000 wldrb wr1, [r1] 00000004 <.text+0x4> ecd11000 wldrh wr1, [r1] 00000008 <.text+0x8> ec811000 wstrb wr1, [r1] 0000000c <.text+0xc> ecc11000 wstrh wr1, [r1] If there is a bug here, it would not seem to be one in my patch, since the results are the same as without the patch. As such I hope this bug can be considered separately from my patch; you can enter a report in binutils Bugzilla, or submit a patch against current binutils mainline (currently 2.17.50 20060920) that fixes this bug (only) and includes testcases for the assembler testsuite. -- Joseph S. Myers joseph@codesourcery.com