From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Paul Brook <paul@codesourcery.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] C6X unwinding table generation
Date: Fri, 08 Apr 2011 19:22:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1104081910500.30412@digraph.polyomino.org.uk> (raw)
In-Reply-To: <201104071355.13054.paul@codesourcery.com>
Regarding the whole patch series, there still seem to be some bits missing
- are they going to come in subsequent patches?
* Testcase for linker handling of R_C6000_PREL31.
* Will the assembler properly generate CANTUNWIND markers for functions
without unwind information, if a function with unwind information is
followed by one without in the .s file? Will the linker generate such
markers for input objects without unwind information, and when doing a
final link for the address after the end of the input objects? This
(similar to what you implemented for ARM a while back) is expressly
required by the ABI (section 10.8.1 in version 0.9).
General comments on this individual patch (more later once I've gone
through the details of it):
* Please name functions and variables in tc-tic6x.c to contain "tic6x"
where possible.
* Assembler diagnostics should start with a lowercase letter.
* Each diagnostic in tc-tic6x.c should be tested by a testcase (if you
think it's unreachable, abort instead).
* It looks to me like the state you put in the "unwind" variable should
actually go in the tic6x_segment_info_type structure (maybe the c6x_unwind
structure as an element of the tic6x_segment_info_type structure); the
code generally tries to ensure that switching between sections works
properly by keeping state there rather than in global variables.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-04-08 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 12:55 Paul Brook
2011-04-08 16:15 ` Nick Clifton
2011-04-08 19:22 ` Joseph S. Myers [this message]
2011-04-08 20:16 ` Joseph S. Myers
2011-05-10 2:37 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1104081910500.30412@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).