From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24642 invoked by alias); 8 Apr 2011 20:16:15 -0000 Received: (qmail 24424 invoked by uid 22791); 8 Apr 2011 20:16:12 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Apr 2011 20:15:38 +0000 Received: (qmail 5287 invoked from network); 8 Apr 2011 20:15:37 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Apr 2011 20:15:37 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1Q8I5f-0001Sj-Rx; Fri, 08 Apr 2011 20:15:35 +0000 Date: Fri, 08 Apr 2011 20:16:00 -0000 From: "Joseph S. Myers" To: Paul Brook cc: binutils@sourceware.org Subject: Re: [PATCH] C6X unwinding table generation In-Reply-To: <201104071355.13054.paul@codesourcery.com> Message-ID: References: <201104071355.13054.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00131.txt.bz2 More specific comments on the assembler changes: In tic6x_regname_to_dw2regnum you should handle A16-A31 and B16-B31 properly (DWARF numbers 37-52 and 53-68) rather than quietly returning incorrect numbers for them. UNWIND_OP2_CANTUNWIND appears to be unused. -- Joseph S. Myers joseph@codesourcery.com