From: "Cui, Lili" <lili.cui@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: RE: [PATCH] x86: support APX forms of U{RD,WR}MSR
Date: Mon, 15 Jan 2024 06:41:32 +0000 [thread overview]
Message-ID: <SJ0PR11MB560045D29CE7FA8C1323DF149E6C2@SJ0PR11MB5600.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9bf44f10-4ed9-45f2-b490-7af710da720b@suse.com>
> This was missed in 6177c84d5edc ("Support APX GPR32 with extend evex
> prefix").
>
It was disclosed on December 15, 2023, we haven't added it yet, this patch LGTM, thank you.
> @@ -9090,6 +9094,9 @@ get_valid_dis386 (const struct dis386 *d
> case 0x6:
> vex_table_index = EVEX_MAP6;
> break;
> + case 0x7:
> + vex_table_index = EVEX_MAP7;
> + break;
> }
>
> /* The second byte after 0x62. */ @@ -9159,7 +9166,12 @@
> get_valid_dis386 (const struct dis386 *d
>
> ins->codep++;
> vindex = *ins->codep++;
> - dp = &evex_table[vex_table_index][vindex];
> + if (vex_table_index != EVEX_MAP7)
> + dp = &evex_table[vex_table_index][vindex];
> + else if (vindex == 0xf8)
> + dp = &map7_f8_opcode;
> + else
> + dp = &bad_opcode;
The processing of this part of MAP7 seems strange. Maybe we can restore it when more map7 instructions appear in the future.
Lili.
next prev parent reply other threads:[~2024-01-15 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 8:57 Jan Beulich
2024-01-15 6:41 ` Cui, Lili [this message]
2024-01-15 7:19 ` Jan Beulich
2024-01-16 8:19 ` Hu, Lin1
2024-01-16 8:31 ` Jan Beulich
2024-01-16 8:31 ` Hu, Lin1
2024-01-18 1:22 ` Cui, Lili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB560045D29CE7FA8C1323DF149E6C2@SJ0PR11MB5600.namprd11.prod.outlook.com \
--to=lili.cui@intel.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).