From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by sourceware.org (Postfix) with ESMTPS id 101233857C7E for ; Tue, 12 Dec 2023 08:16:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 101233857C7E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 101233857C7E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=192.198.163.11 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702369014; cv=pass; b=NbPYLJAP/Zo/E68DuIJm4W33ROCE8561LCDU14Y1WvoS6dP8xwKBjQVtTYaRRREZnm40D+vrQBbETVAn7pO/I9wrFEK/cwoBQAvdT7vfY0occ0d2lZcfXCASByi+ibu3P2+yJRWKipwJuDE8FYEUdr9wxkiRfCe3qMLzGOXSEZc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702369014; c=relaxed/simple; bh=NQk2l2EKMJyj0tlF8M+ROGHSgkYjmolH9y78boUP/0Q=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Y9lvuOVOLO1bcZ4Gx7mGpHsCR7zOw7owmH/Q+j6CYm0GYpNAp6YzoyawTIi9XV36M7zWiN97p2R03wefY62DwesNcw6CZoycP0r6Np/JzVuCPIoADFgq9orI490/4XEKuZrHz76Eg54+NtXfaN9EuVcndXolsfLhlJfNFyoZuJ8= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702369010; x=1733905010; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NQk2l2EKMJyj0tlF8M+ROGHSgkYjmolH9y78boUP/0Q=; b=L19EnpwLVb4230X2xG5+kubhd2sa/kDkKASrNFbmaejXdhL4ffVf6FVP qCHfHOkl+uouVSHyQdJptZ4GWsLh1CKXSES7lIJfvnon/3NAA1pv+rkhX +11GWaEdxAqWw9vr0vfs4iB/fyX6A6h5o0Nc8e19gkJhUpCdoJWrAiQM4 TokSoUaA/29nI61cGxneX8yDdBWsx5z9zvyNqVZyJii33+th3SxtlEjVO xflEMgIbAs8krvAOcW61CQejzcbalR2rGDX8Aegj92ErIHdQHFUque+Ln Tb3Er/KTDTUPadMYBJy26Mpn1RXdYv5OCOy2d3WCMv8XEkOA2vc2hnUMa w==; X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="1583403" X-IronPort-AV: E=Sophos;i="6.04,269,1695711600"; d="scan'208";a="1583403" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 00:16:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="864126498" X-IronPort-AV: E=Sophos;i="6.04,269,1695711600"; d="scan'208";a="864126498" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Dec 2023 00:16:48 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Dec 2023 00:16:48 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 12 Dec 2023 00:16:48 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 12 Dec 2023 00:16:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S7h1GIoHknSYIFkAkcKhbLcLUId6MENI6wzc7VwUaB6b7tdkP3oPtlPiZC095Xq9+jacsz4I3JI4pI7pSO9TTCoI5CJg9/xiHGu69dhzv/xzaQCiB2MEXNMUNZQWGJ9frDxqX4ecRo7ex13PMlIeyNGYfahaXMEUZLe+ECW5spNDJMlnCnBcmombQR9aQZ5O/tbXus+tP+YrR6Rm0sFtX89b8Q62F+D6WhnTw1qc1mIelu+/YgLxL1MYPBGaqjd619+OIxP95RfvMgoXNJwvDKV7xRebKHooCXEcYyzx7A78yeE5cDvaMetgDumfNsCK2OFVAYAKofnOlHdG7RTpoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PJo31fVZN+wQVnIzbWMfNwmgP3zHY86WBDVTxOnWMcw=; b=Ge50hMouzWRFMujHiheFlBqmx5tU1SXkGrRGJj3XnxdTlzCmElZFPZnWK30Tg6blZrO5mr+KpAm4YuPIyE4JcCJVM2pWsrA5dN5dJHYZh0sCPlrCCZ3on9S0BSVhqvoakhyANDZCo37NpFwBV9M7MS7c5cm2rj1amR9ratQ41tV8eE6AOzGvJTJRRH4pS8jFL+XDpBYUiFCLqTsU3Za4Is3ZozoW1hkxC8a5foDvVyKocmt82KE2NxK2shPJBcvfKJioT5myxOvVTAPlgaTt6AOTfP7iAx7WM0Wg9L/36SqDCc2I4E4d0rXNAue2yJPrlzef4LN8IWPCyyD99CP3Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5600.namprd11.prod.outlook.com (2603:10b6:a03:3ab::16) by CH3PR11MB8316.namprd11.prod.outlook.com (2603:10b6:610:17b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Tue, 12 Dec 2023 08:16:45 +0000 Received: from SJ0PR11MB5600.namprd11.prod.outlook.com ([fe80::f925:7c4b:8747:4549]) by SJ0PR11MB5600.namprd11.prod.outlook.com ([fe80::f925:7c4b:8747:4549%3]) with mapi id 15.20.7091.022; Tue, 12 Dec 2023 08:16:45 +0000 From: "Cui, Lili" To: "binutils@sourceware.org" CC: "Beulich, Jan" , "Lu, Hongjiu" Subject: RE: [PATCH 1/9] Make const_1_mode print $1 in AT&T syntax Thread-Topic: [PATCH 1/9] Make const_1_mode print $1 in AT&T syntax Thread-Index: AQHaHqRJkJprHKZ1iEOFuDBJ4qouGrClaBog Date: Tue, 12 Dec 2023 08:16:44 +0000 Message-ID: References: <20231124070213.3886483-1-lili.cui@intel.com> In-Reply-To: <20231124070213.3886483-1-lili.cui@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5600:EE_|CH3PR11MB8316:EE_ x-ms-office365-filtering-correlation-id: 051798d5-52e5-4208-b1db-08dbfaeaade2 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A7SsZYDn26vmsZrKIvA5g6ZgPIa6rfauDja9NFaLLhQauSx62yCYIZXRH+i/vdNPIgVuE04Sufd+8KuLTFfip62ois5R++bcCYZjgRF4+Ya98uaF4EFhjxwDmBjDzyMzoPcvhqcXNo77lHUdcRx27+el6IJG9aM6yM1as/hft3g/yy+9IUrjbKNtg5lFu5nxaDfQPJHqGfyj7MCalE1CPrgHUkgcfPyfmFrt7U1HI/GdCiUeos+UlY8i51xTuFpkhjlq6pqIzMfB+Swd025Kznorm+v9SLqJiMAVi5BRg6KHYcxGqHEBNHb7fk18WBzvagHzLKHCzPnc2TKOOXbvG1zFkFeduaV5AavpMTkT3YaYQztPRX9ASgwm4UOJT8O81LJWkUgIQS747NvUnYxxPxLfPnHhrAKJevmkwLrYp2Go5NqMBUoAx1hgdnj0AN5uDOFheUUV33+gA1kMbM9EUMFVJ47TD3XPr017wFRarbuKgGWB9ukrt2PsF7bsv1GcCd/v5nMjJ1Lq/yn9E9EF0wt4JiVt2iB4GsAZ3/9lR0r6DBl6PzxqKHjOGKPyTNFUmTltf/vER1Dk2hqt6zdgY6WchzfbekUcjTi8YIzZFYbmJw+yiZjhc+m5dpzadXJ3 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5600.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(396003)(136003)(366004)(39860400002)(346002)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(83380400001)(2906002)(86362001)(478600001)(41300700001)(82960400001)(38070700009)(76116006)(6916009)(54906003)(66556008)(64756008)(66946007)(66446008)(66476007)(30864003)(122000001)(71200400001)(38100700002)(316002)(55016003)(8676002)(7696005)(8936002)(4326008)(53546011)(6506007)(9686003)(52536014)(33656002)(5660300002)(107886003)(26005)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/mq8pEUU3Ue1FxjFhRj7fJVgBfqLfI11uwXkzGJbfI+jpaMgRX9q+tQ7w/lH?= =?us-ascii?Q?MBK7x4baxiSMgbQ8nQDPsUELTUl53v1ETrkopxZS4XjJKNB6bqtHZoQT72Qi?= =?us-ascii?Q?ICbRZ6STgJ872iETYI6MAMZoW330U7uIHHkbzzCPvE7pGCc86y6Lo64N/EfA?= =?us-ascii?Q?xgmEPAnNasDcx6obO1uRTajChWlRbrZfX4vV3N565Uw1UXUFhNkEpWAXo+Rw?= =?us-ascii?Q?3dCTSuDAZHq1Vwcjw1Bhvq6Gr7HJL5u1MJPhdNLqhmuvhs/CNQBIsJjgfOyb?= =?us-ascii?Q?wC1G0y8h7sC4/gRQvn4Div8oCTx1Guc3ZSQl19+7MSXfbqALOGATm66n2B+a?= =?us-ascii?Q?ZwF3+10AgXYX+uffifuNZOinEJrxPmFfYCw9yrxs1xnx4b3Jnw0LrbsjTBB6?= =?us-ascii?Q?Nn7fLy4qqFdC5wi1p+uSh5g3IrYbBuLj6jxIrVeukqZlJxtOSCW2E1lf4sV0?= =?us-ascii?Q?NSeQpbGYKzbU1G8/MSATRzPbcU5qVZOmk5CMUIjiiEQ4t+gx5ShMhFISq84K?= =?us-ascii?Q?+5W86MRznFTCxL8lccM1jCg2XkKR0ho6A87adFawNTX9GyizVE8IOADw8OG/?= =?us-ascii?Q?OiW+b96hwOCo1i8XylxyP69pQSsN3ubWMR7D/MjWAD/gZph+G2n8NPVc5/gq?= =?us-ascii?Q?r+HFU1kZZexy7hbTVvPjDC+m4PAYdLzlmFeZW4d8SoDpjkHiL7s+aRCxs6jU?= =?us-ascii?Q?A9YYSc1D9UrPAoWMv2SOQc8yy5p6UzPE4PrURb3NTmCEN14Ql1y+qkESebdL?= =?us-ascii?Q?YyRC2Qka1e4fS4kFnyzLb/VSArnOEQeRLI9W0ez1OGh/4TcDbLiO9P/EjK4l?= =?us-ascii?Q?N7WEc6Q2DIjbJyqeQ0rP8a9QbcTw7c+6zOe2rE/ggXzcsxhALrGNF3BXNRo/?= =?us-ascii?Q?LPcNUkJLJmHzqNjPMh0HaouLf+YHkqdFRlyvDYxiGe84+XLyNORSXfZi4AuZ?= =?us-ascii?Q?m8VOSuip7gdzrXaXl86i73AbzPFwseUHBkw0IkBP626Tl9C14E2SvPdgU4t6?= =?us-ascii?Q?DkZxcZjOMbvVvx7GogfUtB4WDPwqvAgOf8VkCvJqdhygLlXLizRC1d0k3xA2?= =?us-ascii?Q?ZQiorv0KKr1AxIDXQAP0PUu2Y7NjdhLFvFI1UskVHcIwmhTboWTcB6Fo9oi+?= =?us-ascii?Q?3LgrushtErdBtL7WJqlo1k9vroQdHk017caLHDmEGrMt4oGcdaN8yea1kUJk?= =?us-ascii?Q?ntNm/5s4BQIb4u5BQ8ee5mIlwTGKuFyeF4gzgVb4UKiBsG7wVJGgAHtc2+MG?= =?us-ascii?Q?XbMcALZ2eZ+khUuduK+vPNLJ1VyU5tJAnzz3oWG1FvjPAn7E59IK1awEr9Zv?= =?us-ascii?Q?cHByHabgAbsODGLDbu9a+Ss7/oZrKIyUgqIPAuiW4ZmDe4vAe8oG9MN/jI9n?= =?us-ascii?Q?VF31I7X9rd2cXw7X+wZRhB+lxoIt96RtToBolRFnU0/hwEVY5Pvqqyvfy3QX?= =?us-ascii?Q?6uNs17sWhYCpP2/RLVWI8yDYqevJgFW7GzNEM1d04bVi8LRgJ1HBOBKgjaBf?= =?us-ascii?Q?Ey7cHOcC5EFwEnVHWiJhAfw5pBECpsMgJDXFKd929ZfgNgAXoTTCgRor/HuQ?= =?us-ascii?Q?W2z8zdinjxyrcdrdneC9rYmkU5Y5tnApzWUfYrM8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5600.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 051798d5-52e5-4208-b1db-08dbfaeaade2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2023 08:16:44.9348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S4vKg7RheCty7nQN8v0ALyTdhDn2W6/NqMuEEMid8C7UtYdPmkV1qyUGnNLMJzS76Tkzov6sqzqfm0Uf/KQLOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8316 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi H.J, Could you help review this patch ? thanks. Lili. > -----Original Message----- > From: Cui, Lili > Sent: Friday, November 24, 2023 3:02 PM > To: binutils@sourceware.org > Cc: Beulich, Jan ; Lu, Hongjiu > Subject: [PATCH 1/9] Make const_1_mode print $1 in AT&T syntax >=20 > Make const_1_mode print $1 in AT&T syntax, otherwise there will be > correctness issues when it is extended to support APX NDD, >=20 > gas/ChangeLog: >=20 > * testsuite/gas/i386/intel.d: Adjust testcase. > * testsuite/gas/i386/lfence-load.d: Ditto. > * testsuite/gas/i386/noreg16-data32.d: Ditto. > * testsuite/gas/i386/noreg16.d: Ditto. > * testsuite/gas/i386/noreg32-data16.d: Ditto. > * testsuite/gas/i386/noreg32.d: Ditto. > * testsuite/gas/i386/noreg64-data16.d: Ditto. > * testsuite/gas/i386/noreg64-rex64.d: Ditto. > * testsuite/gas/i386/noreg64.d: Ditto. > * testsuite/gas/i386/opcode-suffix.d: Ditto. > * testsuite/gas/i386/opcode.d: Ditto. > * testsuite/gas/i386/x86-64-lfence-load.d: Ditto. > * testsuite/gas/i386/x86-64-opcode.d: Ditto. >=20 > opcodes/ChangeLog: >=20 > * i386-dis.c (OP_I): Make const_1_mode print $1 in AT&T syntax. > --- > gas/testsuite/gas/i386/intel.d | 6 ++-- > gas/testsuite/gas/i386/lfence-load.d | 2 +- > gas/testsuite/gas/i386/noreg16-data32.d | 32 ++++++++++----------- > gas/testsuite/gas/i386/noreg16.d | 32 ++++++++++----------- > gas/testsuite/gas/i386/noreg32-data16.d | 32 ++++++++++----------- > gas/testsuite/gas/i386/noreg32.d | 32 ++++++++++----------- > gas/testsuite/gas/i386/noreg64-data16.d | 32 ++++++++++----------- > gas/testsuite/gas/i386/noreg64-rex64.d | 32 ++++++++++----------- > gas/testsuite/gas/i386/noreg64.d | 32 ++++++++++----------- > gas/testsuite/gas/i386/opcode-suffix.d | 6 ++-- > gas/testsuite/gas/i386/opcode.d | 10 +++---- > gas/testsuite/gas/i386/x86-64-lfence-load.d | 2 +- > gas/testsuite/gas/i386/x86-64-opcode.d | 6 ++-- > opcodes/i386-dis.c | 2 ++ > 14 files changed, 130 insertions(+), 128 deletions(-) >=20 > diff --git a/gas/testsuite/gas/i386/intel.d b/gas/testsuite/gas/i386/inte= l.d > index bc212893853..c3e45c2e38c 100644 > --- a/gas/testsuite/gas/i386/intel.d > +++ b/gas/testsuite/gas/i386/intel.d > @@ -208,8 +208,8 @@ Disassembly of section .text: > [ ]*[a-f0-9]+: cd 90 [ ]*int \$0x90 > [ ]*[a-f0-9]+: ce [ ]*into > [ ]*[a-f0-9]+: cf [ ]*iret > -[ ]*[a-f0-9]+: d0 90 90 90 90 90 [ ]*rclb -0x6f6f6f70\(%eax\) > -[ ]*[a-f0-9]+: d1 90 90 90 90 90 [ ]*rcll -0x6f6f6f70\(%eax\) > +[ ]*[a-f0-9]+: d0 90 90 90 90 90 [ ]*rclb \$1,- > 0x6f6f6f70\(%eax\) > +[ ]*[a-f0-9]+: d1 90 90 90 90 90 [ ]*rcll \$1,- > 0x6f6f6f70\(%eax\) > [ ]*[a-f0-9]+: d2 90 90 90 90 90 [ ]*rclb %cl,- > 0x6f6f6f70\(%eax\) > [ ]*[a-f0-9]+: d3 90 90 90 90 90 [ ]*rcll %cl,- > 0x6f6f6f70\(%eax\) > [ ]*[a-f0-9]+: d4 90 [ ]*aam \$0x90 > @@ -527,7 +527,7 @@ Disassembly of section .text: > [ ]*[a-f0-9]+: 66 ca 90 90 [ ]*lretw \$0x9090 > [ ]*[a-f0-9]+: 66 cb [ ]*lretw > [ ]*[a-f0-9]+: 66 cf [ ]*iretw > -[ ]*[a-f0-9]+: 66 d1 90 90 90 90 90 [ ]*rclw -0x6f6f6f70\(%eax\) > +[ ]*[a-f0-9]+: 66 d1 90 90 90 90 90 [ ]*rclw \$1,- > 0x6f6f6f70\(%eax\) > [ ]*[a-f0-9]+: 66 d3 90 90 90 90 90 [ ]*rclw %cl,- > 0x6f6f6f70\(%eax\) > [ ]*[a-f0-9]+: 66 e5 90 [ ]*in \$0x90,%ax > [ ]*[a-f0-9]+: 66 e7 90 [ ]*out %ax,\$0x90 > diff --git a/gas/testsuite/gas/i386/lfence-load.d > b/gas/testsuite/gas/i386/lfence-load.d > index 33ebef5432f..eb94bdcbb68 100644 > --- a/gas/testsuite/gas/i386/lfence-load.d > +++ b/gas/testsuite/gas/i386/lfence-load.d > @@ -83,7 +83,7 @@ Disassembly of section .text: > +[a-f0-9]+: 0f ae e8 lfence > +[a-f0-9]+: 58 pop %eax > +[a-f0-9]+: 0f ae e8 lfence > - +[a-f0-9]+: 66 d1 11 rclw \(%ecx\) > + +[a-f0-9]+: 66 d1 11 rclw \$1,\(%ecx\) > +[a-f0-9]+: 0f ae e8 lfence > +[a-f0-9]+: f7 01 01 00 00 00 testl \$0x1,\(%ecx\) > +[a-f0-9]+: 0f ae e8 lfence > diff --git a/gas/testsuite/gas/i386/noreg16-data32.d > b/gas/testsuite/gas/i386/noreg16-data32.d > index 7561b549ebb..237e25dd0e1 100644 > --- a/gas/testsuite/gas/i386/noreg16-data32.d > +++ b/gas/testsuite/gas/i386/noreg16-data32.d > @@ -96,43 +96,43 @@ Disassembly of section .text: > *[a-f0-9]+: f3 0f ae 27 ptwrite \(%bx\) > *[a-f0-9]+: 66 ff 37 pushl \(%bx\) > *[a-f0-9]+: 66 06 pushl %es > - *[a-f0-9]+: 66 d1 17 rcll \(%bx\) > + *[a-f0-9]+: 66 d1 17 rcll \$1,\(%bx\) > *[a-f0-9]+: 66 c1 17 02 rcll \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 17 rcll %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 17 rcll \(%bx\) > - *[a-f0-9]+: 66 d1 1f rcrl \(%bx\) > + *[a-f0-9]+: 66 d1 17 rcll \$1,\(%bx\) > + *[a-f0-9]+: 66 d1 1f rcrl \$1,\(%bx\) > *[a-f0-9]+: 66 c1 1f 02 rcrl \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 1f rcrl %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 1f rcrl \(%bx\) > - *[a-f0-9]+: 66 d1 07 roll \(%bx\) > + *[a-f0-9]+: 66 d1 1f rcrl \$1,\(%bx\) > + *[a-f0-9]+: 66 d1 07 roll \$1,\(%bx\) > *[a-f0-9]+: 66 c1 07 02 roll \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 07 roll %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 07 roll \(%bx\) > - *[a-f0-9]+: 66 d1 0f rorl \(%bx\) > + *[a-f0-9]+: 66 d1 07 roll \$1,\(%bx\) > + *[a-f0-9]+: 66 d1 0f rorl \$1,\(%bx\) > *[a-f0-9]+: 66 c1 0f 02 rorl \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 0f rorl %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 0f rorl \(%bx\) > + *[a-f0-9]+: 66 d1 0f rorl \$1,\(%bx\) > *[a-f0-9]+: 66 83 1f 01 sbbl \$0x1,\(%bx\) > *[a-f0-9]+: 66 81 1f 89 00 00 00 sbbl \$0x89,\(%bx\) > *[a-f0-9]+: 66 81 1f 34 12 00 00 sbbl \$0x1234,\(%bx\) > *[a-f0-9]+: 66 af scas %es:\(%di\),%eax > *[a-f0-9]+: 66 af scas %es:\(%di\),%eax > - *[a-f0-9]+: 66 d1 27 shll \(%bx\) > + *[a-f0-9]+: 66 d1 27 shll \$1,\(%bx\) > *[a-f0-9]+: 66 c1 27 02 shll \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 27 shll %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 27 shll \(%bx\) > - *[a-f0-9]+: 66 d1 3f sarl \(%bx\) > + *[a-f0-9]+: 66 d1 27 shll \$1,\(%bx\) > + *[a-f0-9]+: 66 d1 3f sarl \$1,\(%bx\) > *[a-f0-9]+: 66 c1 3f 02 sarl \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 3f sarl %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 3f sarl \(%bx\) > - *[a-f0-9]+: 66 d1 27 shll \(%bx\) > + *[a-f0-9]+: 66 d1 3f sarl \$1,\(%bx\) > + *[a-f0-9]+: 66 d1 27 shll \$1,\(%bx\) > *[a-f0-9]+: 66 c1 27 02 shll \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 27 shll %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 27 shll \(%bx\) > - *[a-f0-9]+: 66 d1 2f shrl \(%bx\) > + *[a-f0-9]+: 66 d1 27 shll \$1,\(%bx\) > + *[a-f0-9]+: 66 d1 2f shrl \$1,\(%bx\) > *[a-f0-9]+: 66 c1 2f 02 shrl \$0x2,\(%bx\) > *[a-f0-9]+: 66 d3 2f shrl %cl,\(%bx\) > - *[a-f0-9]+: 66 d1 2f shrl \(%bx\) > + *[a-f0-9]+: 66 d1 2f shrl \$1,\(%bx\) > *[a-f0-9]+: 66 ab stos %eax,%es:\(%di\) > *[a-f0-9]+: 66 ab stos %eax,%es:\(%di\) > *[a-f0-9]+: 66 83 2f 01 subl \$0x1,\(%bx\) > diff --git a/gas/testsuite/gas/i386/noreg16.d > b/gas/testsuite/gas/i386/noreg16.d > index 86f852fb4ca..e4149b03a6e 100644 > --- a/gas/testsuite/gas/i386/noreg16.d > +++ b/gas/testsuite/gas/i386/noreg16.d > @@ -95,43 +95,43 @@ Disassembly of section .text: > *[a-f0-9]+: f3 0f ae 27 ptwrite \(%bx\) > *[a-f0-9]+: ff 37 push \(%bx\) > *[a-f0-9]+: 06 push %es > - *[a-f0-9]+: d1 17 rclw \(%bx\) > + *[a-f0-9]+: d1 17 rclw \$1,\(%bx\) > *[a-f0-9]+: c1 17 02 rclw \$0x2,\(%bx\) > *[a-f0-9]+: d3 17 rclw %cl,\(%bx\) > - *[a-f0-9]+: d1 17 rclw \(%bx\) > - *[a-f0-9]+: d1 1f rcrw \(%bx\) > + *[a-f0-9]+: d1 17 rclw \$1,\(%bx\) > + *[a-f0-9]+: d1 1f rcrw \$1,\(%bx\) > *[a-f0-9]+: c1 1f 02 rcrw \$0x2,\(%bx\) > *[a-f0-9]+: d3 1f rcrw %cl,\(%bx\) > - *[a-f0-9]+: d1 1f rcrw \(%bx\) > - *[a-f0-9]+: d1 07 rolw \(%bx\) > + *[a-f0-9]+: d1 1f rcrw \$1,\(%bx\) > + *[a-f0-9]+: d1 07 rolw \$1,\(%bx\) > *[a-f0-9]+: c1 07 02 rolw \$0x2,\(%bx\) > *[a-f0-9]+: d3 07 rolw %cl,\(%bx\) > - *[a-f0-9]+: d1 07 rolw \(%bx\) > - *[a-f0-9]+: d1 0f rorw \(%bx\) > + *[a-f0-9]+: d1 07 rolw \$1,\(%bx\) > + *[a-f0-9]+: d1 0f rorw \$1,\(%bx\) > *[a-f0-9]+: c1 0f 02 rorw \$0x2,\(%bx\) > *[a-f0-9]+: d3 0f rorw %cl,\(%bx\) > - *[a-f0-9]+: d1 0f rorw \(%bx\) > + *[a-f0-9]+: d1 0f rorw \$1,\(%bx\) > *[a-f0-9]+: 83 1f 01 sbbw \$0x1,\(%bx\) > *[a-f0-9]+: 81 1f 89 00 sbbw \$0x89,\(%bx\) > *[a-f0-9]+: 81 1f 34 12 sbbw \$0x1234,\(%bx\) > *[a-f0-9]+: af scas %es:\(%di\),%ax > *[a-f0-9]+: af scas %es:\(%di\),%ax > - *[a-f0-9]+: d1 27 shlw \(%bx\) > + *[a-f0-9]+: d1 27 shlw \$1,\(%bx\) > *[a-f0-9]+: c1 27 02 shlw \$0x2,\(%bx\) > *[a-f0-9]+: d3 27 shlw %cl,\(%bx\) > - *[a-f0-9]+: d1 27 shlw \(%bx\) > - *[a-f0-9]+: d1 3f sarw \(%bx\) > + *[a-f0-9]+: d1 27 shlw \$1,\(%bx\) > + *[a-f0-9]+: d1 3f sarw \$1,\(%bx\) > *[a-f0-9]+: c1 3f 02 sarw \$0x2,\(%bx\) > *[a-f0-9]+: d3 3f sarw %cl,\(%bx\) > - *[a-f0-9]+: d1 3f sarw \(%bx\) > - *[a-f0-9]+: d1 27 shlw \(%bx\) > + *[a-f0-9]+: d1 3f sarw \$1,\(%bx\) > + *[a-f0-9]+: d1 27 shlw \$1,\(%bx\) > *[a-f0-9]+: c1 27 02 shlw \$0x2,\(%bx\) > *[a-f0-9]+: d3 27 shlw %cl,\(%bx\) > - *[a-f0-9]+: d1 27 shlw \(%bx\) > - *[a-f0-9]+: d1 2f shrw \(%bx\) > + *[a-f0-9]+: d1 27 shlw \$1,\(%bx\) > + *[a-f0-9]+: d1 2f shrw \$1,\(%bx\) > *[a-f0-9]+: c1 2f 02 shrw \$0x2,\(%bx\) > *[a-f0-9]+: d3 2f shrw %cl,\(%bx\) > - *[a-f0-9]+: d1 2f shrw \(%bx\) > + *[a-f0-9]+: d1 2f shrw \$1,\(%bx\) > *[a-f0-9]+: ab stos %ax,%es:\(%di\) > *[a-f0-9]+: ab stos %ax,%es:\(%di\) > *[a-f0-9]+: 83 2f 01 subw \$0x1,\(%bx\) > diff --git a/gas/testsuite/gas/i386/noreg32-data16.d > b/gas/testsuite/gas/i386/noreg32-data16.d > index 1ec6b9e8670..e3ae2116bb1 100644 > --- a/gas/testsuite/gas/i386/noreg32-data16.d > +++ b/gas/testsuite/gas/i386/noreg32-data16.d > @@ -103,44 +103,44 @@ Disassembly of section .text: > *[a-f0-9]+: f3 0f ae 20 ptwrite \(%eax\) > *[a-f0-9]+: 66 ff 30 pushw \(%eax\) > *[a-f0-9]+: 66 06 pushw %es > - *[a-f0-9]+: 66 d1 10 rclw \(%eax\) > + *[a-f0-9]+: 66 d1 10 rclw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 10 02 rclw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 10 rclw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 10 rclw \(%eax\) > - *[a-f0-9]+: 66 d1 18 rcrw \(%eax\) > + *[a-f0-9]+: 66 d1 10 rclw \$1,\(%eax\) > + *[a-f0-9]+: 66 d1 18 rcrw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 18 02 rcrw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 18 rcrw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 18 rcrw \(%eax\) > - *[a-f0-9]+: 66 d1 00 rolw \(%eax\) > + *[a-f0-9]+: 66 d1 18 rcrw \$1,\(%eax\) > + *[a-f0-9]+: 66 d1 00 rolw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 00 02 rolw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 00 rolw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 00 rolw \(%eax\) > - *[a-f0-9]+: 66 d1 08 rorw \(%eax\) > + *[a-f0-9]+: 66 d1 00 rolw \$1,\(%eax\) > + *[a-f0-9]+: 66 d1 08 rorw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 08 02 rorw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 08 rorw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 08 rorw \(%eax\) > + *[a-f0-9]+: 66 d1 08 rorw \$1,\(%eax\) > *[a-f0-9]+: 66 83 18 01 sbbw \$0x1,\(%eax\) > *[a-f0-9]+: 66 81 18 89 00 sbbw \$0x89,\(%eax\) > *[a-f0-9]+: 66 81 18 34 12 sbbw \$0x1234,\(%eax\) > *[a-f0-9]+: 66 81 18 78 56 sbbw \$0x5678,\(%eax\) > *[a-f0-9]+: 66 af scas %es:\(%edi\),%ax > *[a-f0-9]+: 66 af scas %es:\(%edi\),%ax > - *[a-f0-9]+: 66 d1 20 shlw \(%eax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 20 02 shlw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 20 shlw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 20 shlw \(%eax\) > - *[a-f0-9]+: 66 d1 38 sarw \(%eax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%eax\) > + *[a-f0-9]+: 66 d1 38 sarw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 38 02 sarw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 38 sarw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 38 sarw \(%eax\) > - *[a-f0-9]+: 66 d1 20 shlw \(%eax\) > + *[a-f0-9]+: 66 d1 38 sarw \$1,\(%eax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 20 02 shlw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 20 shlw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 20 shlw \(%eax\) > - *[a-f0-9]+: 66 d1 28 shrw \(%eax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%eax\) > + *[a-f0-9]+: 66 d1 28 shrw \$1,\(%eax\) > *[a-f0-9]+: 66 c1 28 02 shrw \$0x2,\(%eax\) > *[a-f0-9]+: 66 d3 28 shrw %cl,\(%eax\) > - *[a-f0-9]+: 66 d1 28 shrw \(%eax\) > + *[a-f0-9]+: 66 d1 28 shrw \$1,\(%eax\) > *[a-f0-9]+: 66 ab stos %ax,%es:\(%edi\) > *[a-f0-9]+: 66 ab stos %ax,%es:\(%edi\) > *[a-f0-9]+: 66 83 28 01 subw \$0x1,\(%eax\) > diff --git a/gas/testsuite/gas/i386/noreg32.d > b/gas/testsuite/gas/i386/noreg32.d > index 9dbef908ce7..8bb08ca73c6 100644 > --- a/gas/testsuite/gas/i386/noreg32.d > +++ b/gas/testsuite/gas/i386/noreg32.d > @@ -101,44 +101,44 @@ Disassembly of section .text: > *[a-f0-9]+: f3 0f ae 20 ptwrite \(%eax\) > *[a-f0-9]+: ff 30 push \(%eax\) > *[a-f0-9]+: 06 push %es > - *[a-f0-9]+: d1 10 rcll \(%eax\) > + *[a-f0-9]+: d1 10 rcll \$1,\(%eax\) > *[a-f0-9]+: c1 10 02 rcll \$0x2,\(%eax\) > *[a-f0-9]+: d3 10 rcll %cl,\(%eax\) > - *[a-f0-9]+: d1 10 rcll \(%eax\) > - *[a-f0-9]+: d1 18 rcrl \(%eax\) > + *[a-f0-9]+: d1 10 rcll \$1,\(%eax\) > + *[a-f0-9]+: d1 18 rcrl \$1,\(%eax\) > *[a-f0-9]+: c1 18 02 rcrl \$0x2,\(%eax\) > *[a-f0-9]+: d3 18 rcrl %cl,\(%eax\) > - *[a-f0-9]+: d1 18 rcrl \(%eax\) > - *[a-f0-9]+: d1 00 roll \(%eax\) > + *[a-f0-9]+: d1 18 rcrl \$1,\(%eax\) > + *[a-f0-9]+: d1 00 roll \$1,\(%eax\) > *[a-f0-9]+: c1 00 02 roll \$0x2,\(%eax\) > *[a-f0-9]+: d3 00 roll %cl,\(%eax\) > - *[a-f0-9]+: d1 00 roll \(%eax\) > - *[a-f0-9]+: d1 08 rorl \(%eax\) > + *[a-f0-9]+: d1 00 roll \$1,\(%eax\) > + *[a-f0-9]+: d1 08 rorl \$1,\(%eax\) > *[a-f0-9]+: c1 08 02 rorl \$0x2,\(%eax\) > *[a-f0-9]+: d3 08 rorl %cl,\(%eax\) > - *[a-f0-9]+: d1 08 rorl \(%eax\) > + *[a-f0-9]+: d1 08 rorl \$1,\(%eax\) > *[a-f0-9]+: 83 18 01 sbbl \$0x1,\(%eax\) > *[a-f0-9]+: 81 18 89 00 00 00 sbbl \$0x89,\(%eax\) > *[a-f0-9]+: 81 18 34 12 00 00 sbbl \$0x1234,\(%eax\) > *[a-f0-9]+: 81 18 78 56 34 12 sbbl \$0x12345678,\(%eax\) > *[a-f0-9]+: af scas %es:\(%edi\),%eax > *[a-f0-9]+: af scas %es:\(%edi\),%eax > - *[a-f0-9]+: d1 20 shll \(%eax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%eax\) > *[a-f0-9]+: c1 20 02 shll \$0x2,\(%eax\) > *[a-f0-9]+: d3 20 shll %cl,\(%eax\) > - *[a-f0-9]+: d1 20 shll \(%eax\) > - *[a-f0-9]+: d1 38 sarl \(%eax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%eax\) > + *[a-f0-9]+: d1 38 sarl \$1,\(%eax\) > *[a-f0-9]+: c1 38 02 sarl \$0x2,\(%eax\) > *[a-f0-9]+: d3 38 sarl %cl,\(%eax\) > - *[a-f0-9]+: d1 38 sarl \(%eax\) > - *[a-f0-9]+: d1 20 shll \(%eax\) > + *[a-f0-9]+: d1 38 sarl \$1,\(%eax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%eax\) > *[a-f0-9]+: c1 20 02 shll \$0x2,\(%eax\) > *[a-f0-9]+: d3 20 shll %cl,\(%eax\) > - *[a-f0-9]+: d1 20 shll \(%eax\) > - *[a-f0-9]+: d1 28 shrl \(%eax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%eax\) > + *[a-f0-9]+: d1 28 shrl \$1,\(%eax\) > *[a-f0-9]+: c1 28 02 shrl \$0x2,\(%eax\) > *[a-f0-9]+: d3 28 shrl %cl,\(%eax\) > - *[a-f0-9]+: d1 28 shrl \(%eax\) > + *[a-f0-9]+: d1 28 shrl \$1,\(%eax\) > *[a-f0-9]+: ab stos %eax,%es:\(%edi\) > *[a-f0-9]+: ab stos %eax,%es:\(%edi\) > *[a-f0-9]+: 83 28 01 subl \$0x1,\(%eax\) > diff --git a/gas/testsuite/gas/i386/noreg64-data16.d > b/gas/testsuite/gas/i386/noreg64-data16.d > index f1e67096a58..802eb4053d3 100644 > --- a/gas/testsuite/gas/i386/noreg64-data16.d > +++ b/gas/testsuite/gas/i386/noreg64-data16.d > @@ -106,44 +106,44 @@ Disassembly of section .text: > *[a-f0-9]+: 66 0f a1 popw %fs > *[a-f0-9]+: 66 ff 30 pushw \(%rax\) > *[a-f0-9]+: 66 0f a0 pushw %fs > - *[a-f0-9]+: 66 d1 10 rclw \(%rax\) > + *[a-f0-9]+: 66 d1 10 rclw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 10 02 rclw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 10 rclw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 10 rclw \(%rax\) > - *[a-f0-9]+: 66 d1 18 rcrw \(%rax\) > + *[a-f0-9]+: 66 d1 10 rclw \$1,\(%rax\) > + *[a-f0-9]+: 66 d1 18 rcrw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 18 02 rcrw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 18 rcrw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 18 rcrw \(%rax\) > - *[a-f0-9]+: 66 d1 00 rolw \(%rax\) > + *[a-f0-9]+: 66 d1 18 rcrw \$1,\(%rax\) > + *[a-f0-9]+: 66 d1 00 rolw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 00 02 rolw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 00 rolw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 00 rolw \(%rax\) > - *[a-f0-9]+: 66 d1 08 rorw \(%rax\) > + *[a-f0-9]+: 66 d1 00 rolw \$1,\(%rax\) > + *[a-f0-9]+: 66 d1 08 rorw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 08 02 rorw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 08 rorw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 08 rorw \(%rax\) > + *[a-f0-9]+: 66 d1 08 rorw \$1,\(%rax\) > *[a-f0-9]+: 66 83 18 01 sbbw \$0x1,\(%rax\) > *[a-f0-9]+: 66 81 18 89 00 sbbw \$0x89,\(%rax\) > *[a-f0-9]+: 66 81 18 34 12 sbbw \$0x1234,\(%rax\) > *[a-f0-9]+: 66 81 18 78 56 sbbw \$0x5678,\(%rax\) > *[a-f0-9]+: 66 af scas %es:\(%rdi\),%ax > *[a-f0-9]+: 66 af scas %es:\(%rdi\),%ax > - *[a-f0-9]+: 66 d1 20 shlw \(%rax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 20 02 shlw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 20 shlw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 20 shlw \(%rax\) > - *[a-f0-9]+: 66 d1 38 sarw \(%rax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%rax\) > + *[a-f0-9]+: 66 d1 38 sarw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 38 02 sarw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 38 sarw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 38 sarw \(%rax\) > - *[a-f0-9]+: 66 d1 20 shlw \(%rax\) > + *[a-f0-9]+: 66 d1 38 sarw \$1,\(%rax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 20 02 shlw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 20 shlw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 20 shlw \(%rax\) > - *[a-f0-9]+: 66 d1 28 shrw \(%rax\) > + *[a-f0-9]+: 66 d1 20 shlw \$1,\(%rax\) > + *[a-f0-9]+: 66 d1 28 shrw \$1,\(%rax\) > *[a-f0-9]+: 66 c1 28 02 shrw \$0x2,\(%rax\) > *[a-f0-9]+: 66 d3 28 shrw %cl,\(%rax\) > - *[a-f0-9]+: 66 d1 28 shrw \(%rax\) > + *[a-f0-9]+: 66 d1 28 shrw \$1,\(%rax\) > *[a-f0-9]+: 66 ab stos %ax,%es:\(%rdi\) > *[a-f0-9]+: 66 ab stos %ax,%es:\(%rdi\) > *[a-f0-9]+: 66 83 28 01 subw \$0x1,\(%rax\) > diff --git a/gas/testsuite/gas/i386/noreg64-rex64.d > b/gas/testsuite/gas/i386/noreg64-rex64.d > index cd8679e626a..e33851d8093 100644 > --- a/gas/testsuite/gas/i386/noreg64-rex64.d > +++ b/gas/testsuite/gas/i386/noreg64-rex64.d > @@ -105,44 +105,44 @@ Disassembly of section .text: > *[a-f0-9]+: f3 48 0f ae 20 ptwriteq \(%rax\) > *[a-f0-9]+: 48 ff 30 rex\.W push \(%rax\) > *[a-f0-9]+: 48 0f a0 rex\.W push %fs > - *[a-f0-9]+: 48 d1 10 rclq \(%rax\) > + *[a-f0-9]+: 48 d1 10 rclq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 10 02 rclq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 10 rclq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 10 rclq \(%rax\) > - *[a-f0-9]+: 48 d1 18 rcrq \(%rax\) > + *[a-f0-9]+: 48 d1 10 rclq \$1,\(%rax\) > + *[a-f0-9]+: 48 d1 18 rcrq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 18 02 rcrq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 18 rcrq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 18 rcrq \(%rax\) > - *[a-f0-9]+: 48 d1 00 rolq \(%rax\) > + *[a-f0-9]+: 48 d1 18 rcrq \$1,\(%rax\) > + *[a-f0-9]+: 48 d1 00 rolq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 00 02 rolq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 00 rolq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 00 rolq \(%rax\) > - *[a-f0-9]+: 48 d1 08 rorq \(%rax\) > + *[a-f0-9]+: 48 d1 00 rolq \$1,\(%rax\) > + *[a-f0-9]+: 48 d1 08 rorq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 08 02 rorq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 08 rorq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 08 rorq \(%rax\) > + *[a-f0-9]+: 48 d1 08 rorq \$1,\(%rax\) > *[a-f0-9]+: 48 83 18 01 sbbq \$0x1,\(%rax\) > *[a-f0-9]+: 48 81 18 89 00 00 00 sbbq \$0x89,\(%rax\) > *[a-f0-9]+: 48 81 18 34 12 00 00 sbbq \$0x1234,\(%rax\) > *[a-f0-9]+: 48 81 18 78 56 34 12 sbbq \$0x12345678,\(%rax\) > *[a-f0-9]+: 48 af scas %es:\(%rdi\),%rax > *[a-f0-9]+: 48 af scas %es:\(%rdi\),%rax > - *[a-f0-9]+: 48 d1 20 shlq \(%rax\) > + *[a-f0-9]+: 48 d1 20 shlq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 20 02 shlq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 20 shlq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 20 shlq \(%rax\) > - *[a-f0-9]+: 48 d1 38 sarq \(%rax\) > + *[a-f0-9]+: 48 d1 20 shlq \$1,\(%rax\) > + *[a-f0-9]+: 48 d1 38 sarq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 38 02 sarq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 38 sarq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 38 sarq \(%rax\) > - *[a-f0-9]+: 48 d1 20 shlq \(%rax\) > + *[a-f0-9]+: 48 d1 38 sarq \$1,\(%rax\) > + *[a-f0-9]+: 48 d1 20 shlq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 20 02 shlq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 20 shlq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 20 shlq \(%rax\) > - *[a-f0-9]+: 48 d1 28 shrq \(%rax\) > + *[a-f0-9]+: 48 d1 20 shlq \$1,\(%rax\) > + *[a-f0-9]+: 48 d1 28 shrq \$1,\(%rax\) > *[a-f0-9]+: 48 c1 28 02 shrq \$0x2,\(%rax\) > *[a-f0-9]+: 48 d3 28 shrq %cl,\(%rax\) > - *[a-f0-9]+: 48 d1 28 shrq \(%rax\) > + *[a-f0-9]+: 48 d1 28 shrq \$1,\(%rax\) > *[a-f0-9]+: 48 ab stos %rax,%es:\(%rdi\) > *[a-f0-9]+: 48 ab stos %rax,%es:\(%rdi\) > *[a-f0-9]+: 48 83 28 01 subq \$0x1,\(%rax\) > diff --git a/gas/testsuite/gas/i386/noreg64.d > b/gas/testsuite/gas/i386/noreg64.d > index 354d89069ae..2afdef38f92 100644 > --- a/gas/testsuite/gas/i386/noreg64.d > +++ b/gas/testsuite/gas/i386/noreg64.d > @@ -107,44 +107,44 @@ Disassembly of section .text: > *[a-f0-9]+: f3 0f ae 20 ptwritel \(%rax\) > *[a-f0-9]+: ff 30 push \(%rax\) > *[a-f0-9]+: 0f a0 push %fs > - *[a-f0-9]+: d1 10 rcll \(%rax\) > + *[a-f0-9]+: d1 10 rcll \$1,\(%rax\) > *[a-f0-9]+: c1 10 02 rcll \$0x2,\(%rax\) > *[a-f0-9]+: d3 10 rcll %cl,\(%rax\) > - *[a-f0-9]+: d1 10 rcll \(%rax\) > - *[a-f0-9]+: d1 18 rcrl \(%rax\) > + *[a-f0-9]+: d1 10 rcll \$1,\(%rax\) > + *[a-f0-9]+: d1 18 rcrl \$1,\(%rax\) > *[a-f0-9]+: c1 18 02 rcrl \$0x2,\(%rax\) > *[a-f0-9]+: d3 18 rcrl %cl,\(%rax\) > - *[a-f0-9]+: d1 18 rcrl \(%rax\) > - *[a-f0-9]+: d1 00 roll \(%rax\) > + *[a-f0-9]+: d1 18 rcrl \$1,\(%rax\) > + *[a-f0-9]+: d1 00 roll \$1,\(%rax\) > *[a-f0-9]+: c1 00 02 roll \$0x2,\(%rax\) > *[a-f0-9]+: d3 00 roll %cl,\(%rax\) > - *[a-f0-9]+: d1 00 roll \(%rax\) > - *[a-f0-9]+: d1 08 rorl \(%rax\) > + *[a-f0-9]+: d1 00 roll \$1,\(%rax\) > + *[a-f0-9]+: d1 08 rorl \$1,\(%rax\) > *[a-f0-9]+: c1 08 02 rorl \$0x2,\(%rax\) > *[a-f0-9]+: d3 08 rorl %cl,\(%rax\) > - *[a-f0-9]+: d1 08 rorl \(%rax\) > + *[a-f0-9]+: d1 08 rorl \$1,\(%rax\) > *[a-f0-9]+: 83 18 01 sbbl \$0x1,\(%rax\) > *[a-f0-9]+: 81 18 89 00 00 00 sbbl \$0x89,\(%rax\) > *[a-f0-9]+: 81 18 34 12 00 00 sbbl \$0x1234,\(%rax\) > *[a-f0-9]+: 81 18 78 56 34 12 sbbl \$0x12345678,\(%rax\) > *[a-f0-9]+: af scas %es:\(%rdi\),%eax > *[a-f0-9]+: af scas %es:\(%rdi\),%eax > - *[a-f0-9]+: d1 20 shll \(%rax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%rax\) > *[a-f0-9]+: c1 20 02 shll \$0x2,\(%rax\) > *[a-f0-9]+: d3 20 shll %cl,\(%rax\) > - *[a-f0-9]+: d1 20 shll \(%rax\) > - *[a-f0-9]+: d1 38 sarl \(%rax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%rax\) > + *[a-f0-9]+: d1 38 sarl \$1,\(%rax\) > *[a-f0-9]+: c1 38 02 sarl \$0x2,\(%rax\) > *[a-f0-9]+: d3 38 sarl %cl,\(%rax\) > - *[a-f0-9]+: d1 38 sarl \(%rax\) > - *[a-f0-9]+: d1 20 shll \(%rax\) > + *[a-f0-9]+: d1 38 sarl \$1,\(%rax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%rax\) > *[a-f0-9]+: c1 20 02 shll \$0x2,\(%rax\) > *[a-f0-9]+: d3 20 shll %cl,\(%rax\) > - *[a-f0-9]+: d1 20 shll \(%rax\) > - *[a-f0-9]+: d1 28 shrl \(%rax\) > + *[a-f0-9]+: d1 20 shll \$1,\(%rax\) > + *[a-f0-9]+: d1 28 shrl \$1,\(%rax\) > *[a-f0-9]+: c1 28 02 shrl \$0x2,\(%rax\) > *[a-f0-9]+: d3 28 shrl %cl,\(%rax\) > - *[a-f0-9]+: d1 28 shrl \(%rax\) > + *[a-f0-9]+: d1 28 shrl \$1,\(%rax\) > *[a-f0-9]+: ab stos %eax,%es:\(%rdi\) > *[a-f0-9]+: ab stos %eax,%es:\(%rdi\) > *[a-f0-9]+: 83 28 01 subl \$0x1,\(%rax\) > diff --git a/gas/testsuite/gas/i386/opcode-suffix.d > b/gas/testsuite/gas/i386/opcode-suffix.d > index 946a0a4d7a0..ca6af50c9cf 100644 > --- a/gas/testsuite/gas/i386/opcode-suffix.d > +++ b/gas/testsuite/gas/i386/opcode-suffix.d > @@ -206,8 +206,8 @@ Disassembly of section .text: > *[0-9a-f]+: cd 90[ ]+int[ ]+\$0x90 > *[0-9a-f]+: ce[ ]+into > *[0-9a-f]+: cf[ ]+iretl > - *[0-9a-f]+: d0 90 90 90 90 90[ ]+rclb[ ]+-0x6f6f6f70\(%eax\) > - *[0-9a-f]+: d1 90 90 90 90 90[ ]+rcll[ ]+-0x6f6f6f70\(%eax\) > + *[0-9a-f]+: d0 90 90 90 90 90[ ]+rclb[ ]+\$1,-0x6f6f6f70\(%eax\) > + *[0-9a-f]+: d1 90 90 90 90 90[ ]+rcll[ ]+\$1,-0x6f6f6f70\(%eax\) > *[0-9a-f]+: d2 90 90 90 90 90[ ]+rclb[ ]+%cl,-0x6f6f6f70\(%eax\) > *[0-9a-f]+: d3 90 90 90 90 90[ ]+rcll[ ]+%cl,-0x6f6f6f70\(%eax\) > *[0-9a-f]+: d4 90[ ]+aam[ ]+\$0x90 > @@ -523,7 +523,7 @@ Disassembly of section .text: > *[0-9a-f]+: 66 ca 90 90[ ]+lretw[ ]+\$0x9090 > *[0-9a-f]+: 66 cb[ ]+lretw > *[0-9a-f]+: 66 cf[ ]+iretw > - *[0-9a-f]+: 66 d1 90 90 90 90 90[ ]+rclw[ ]+-0x6f6f6f70\(%eax\) > + *[0-9a-f]+: 66 d1 90 90 90 90 90[ ]+rclw[ ]+\$1,-0x6f6f6f70\(%eax\) > *[0-9a-f]+: 66 d3 90 90 90 90 90[ ]+rclw[ ]+%cl,-0x6f6f6f70\(%eax\) > *[0-9a-f]+: 66 e5 90[ ]+inw[ ]+\$0x90,%ax > *[0-9a-f]+: 66 e7 90[ ]+outw[ ]+%ax,\$0x90 > diff --git a/gas/testsuite/gas/i386/opcode.d > b/gas/testsuite/gas/i386/opcode.d index 7631195d8d4..f7af22518e2 100644 > --- a/gas/testsuite/gas/i386/opcode.d > +++ b/gas/testsuite/gas/i386/opcode.d > @@ -205,8 +205,8 @@ Disassembly of section .text: > 279: cd 90 [ ]*int \$0x90 > 27b: ce [ ]*into > 27c: cf [ ]*iret > - 27d: d0 90 90 90 90 90 [ ]*rclb -0x6f6f6f70\(%eax\) > - 283: d1 90 90 90 90 90 [ ]*rcll -0x6f6f6f70\(%eax\) > + 27d: d0 90 90 90 90 90 [ ]*rclb \$1,-0x6f6f6f70\(%eax\) > + 283: d1 90 90 90 90 90 [ ]*rcll \$1,-0x6f6f6f70\(%eax\) > 289: d2 90 90 90 90 90 [ ]*rclb %cl,-0x6f6f6f70\(%eax\) > 28f: d3 90 90 90 90 90 [ ]*rcll %cl,-0x6f6f6f70\(%eax\) > 295: d4 90 [ ]*aam \$0x90 > @@ -522,7 +522,7 @@ Disassembly of section .text: > 869: 66 ca 90 90 [ ]*lretw \$0x9090 > 86d: 66 cb [ ]*lretw > 86f: 66 cf [ ]*iretw > - 871: 66 d1 90 90 90 90 90 [ ]*rclw -0x6f6f6f70\(%eax\) > + 871: 66 d1 90 90 90 90 90 [ ]*rclw \$1,-0x6f6f6f70\(%eax\) > 878: 66 d3 90 90 90 90 90 [ ]*rclw %cl,-0x6f6f6f70\(%eax\) > 87f: 66 e5 90 [ ]*in \$0x90,%ax > 882: 66 e7 90 [ ]*out %ax,\$0x90 > @@ -610,8 +610,8 @@ Disassembly of section .text: > +[a-f0-9]+: f7 c9 04 00 00 00 test \$(0x)?0*4,%ecx > +[a-f0-9]+: c0 f0 02 shl \$0x2,%al > +[a-f0-9]+: c1 f0 01 shl \$0x1,%eax > - +[a-f0-9]+: d0 f0 shl %al > - +[a-f0-9]+: d1 f0 shl %eax > + +[a-f0-9]+: d0 f0 shl \$1,%al > + +[a-f0-9]+: d1 f0 shl \$1,%eax > +[a-f0-9]+: d2 f0 shl %cl,%al > +[a-f0-9]+: d3 f0 shl %cl,%eax > #pass > diff --git a/gas/testsuite/gas/i386/x86-64-lfence-load.d > b/gas/testsuite/gas/i386/x86-64-lfence-load.d > index b4a03db811d..726236826e8 100644 > --- a/gas/testsuite/gas/i386/x86-64-lfence-load.d > +++ b/gas/testsuite/gas/i386/x86-64-lfence-load.d > @@ -90,7 +90,7 @@ Disassembly of section .text: > +[a-f0-9]+: 0f ae e8 lfence > +[a-f0-9]+: 58 pop %rax > +[a-f0-9]+: 0f ae e8 lfence > - +[a-f0-9]+: 66 d1 11 rclw \(%rcx\) > + +[a-f0-9]+: 66 d1 11 rclw \$1,\(%rcx\) > +[a-f0-9]+: 0f ae e8 lfence > +[a-f0-9]+: f7 01 01 00 00 00 testl \$0x1,\(%rcx\) > +[a-f0-9]+: 0f ae e8 lfence > diff --git a/gas/testsuite/gas/i386/x86-64-opcode.d > b/gas/testsuite/gas/i386/x86-64-opcode.d > index ee6d0f5f4bd..1b8a9fa9014 100644 > --- a/gas/testsuite/gas/i386/x86-64-opcode.d > +++ b/gas/testsuite/gas/i386/x86-64-opcode.d > @@ -335,9 +335,9 @@ Disassembly of section .text: > [ ]*[a-f0-9]+: c0 f0 02 shl \$0x2,%al > [ ]*[a-f0-9]+: c1 f0 01 shl \$0x1,%eax > [ ]*[a-f0-9]+: 48 c1 f0 01 shl \$0x1,%rax > -[ ]*[a-f0-9]+: d0 f0 shl %al > -[ ]*[a-f0-9]+: d1 f0 shl %eax > -[ ]*[a-f0-9]+: 48 d1 f0 shl %rax > +[ ]*[a-f0-9]+: d0 f0 shl \$1,%al > +[ ]*[a-f0-9]+: d1 f0 shl \$1,%eax > +[ ]*[a-f0-9]+: 48 d1 f0 shl \$1,%rax > [ ]*[a-f0-9]+: d2 f0 shl %cl,%al > [ ]*[a-f0-9]+: d3 f0 shl %cl,%eax > [ ]*[a-f0-9]+: 48 d3 f0 shl %cl,%rax > diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index > 2e2043d467b..e432b61a6cd 100644 > --- a/opcodes/i386-dis.c > +++ b/opcodes/i386-dis.c > @@ -12090,6 +12090,8 @@ OP_I (instr_info *ins, int bytemode, int sizeflag= ) > case const_1_mode: > if (ins->intel_syntax) > oappend (ins, "1"); > + else > + oappend (ins, "$1"); > return true; > default: > oappend (ins, INTERNAL_DISASSEMBLER_ERROR); > -- > 2.25.1