From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 77D113858C74 for ; Fri, 17 Nov 2023 03:27:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77D113858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77D113858C74 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=192.55.52.43 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700191629; cv=pass; b=Pr9HhDK4WF2bfQdvMgEJBYFmbtksaaf0Mut1zhQJrYA+37PXrTN1SqSrjFmA+ir99fsdVSCmxK+L7ovPqodYdo+U7L0DWwrgesrqKR+V+08/NUDZu8P3akBrfREaKmCMrkrLiC9SzzMOKXI2eddiRMGuocJCWxwGUnsZJYADwSc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700191629; c=relaxed/simple; bh=B/NTQZJ7W2Fuk4mx5TonT3oT4GpSjBjwQwpCTpOQ5n4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=exqmI7/IsDXMfbduDLMekctg0SS2kJSqXgee9sz5PSuc2Dz0vRM4lHwkFiICMoav+c6dOlUHGbWkzttm2KHPRisPG3B1RQxl3zSL5G7MRL6yTeIl0RqniJ+Gl1ick1UdZY1h5u8xdQWrl5dt1YwSsvL5cmVKoq9B1FS5rXvvcDE= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700191627; x=1731727627; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=B/NTQZJ7W2Fuk4mx5TonT3oT4GpSjBjwQwpCTpOQ5n4=; b=l5+bhGyWvP0B9RfiNlesnux3qRtDnF0A4PJGxjrYKsaZWhHlNlQ/nb/G p+Vh8vqQ8ZYw2j90yd5b9Mqs+yMzYd5gc1WjmBcjRBZBp/JrMB9J/HDL5 Y1UraFsf4i74dH65gCFGcw/uHwTeo0l/xeP5wqvhlYBqE3XMKrRZNCoDR LEPtDAC2ARoTwm0anRN3/gysCNfOXKfQM8wSEYh08Sb/FpjxiUhIsaIcS pfAVZaroC/o9bj7V46Msuaw/VZXVHzihYi7ZeiyLSPQj0+NGdVbCT5iWh pu5yQdvNAjJYcqZcb6nfDFF4GzNI3lStFCg1x4fNhufD8JpJekBYrTla9 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="477446097" X-IronPort-AV: E=Sophos;i="6.04,205,1695711600"; d="scan'208";a="477446097" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2023 19:27:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,205,1695711600"; d="scan'208";a="6905211" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Nov 2023 19:27:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 16 Nov 2023 19:27:05 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 16 Nov 2023 19:27:05 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 16 Nov 2023 19:27:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fw02g+jpbxISkVqwj9PFf9q9HrGNVtExVJnXEEPERKQ7I9oCGtOFi5F6B+EgkJm7OStWVa9v+y+N/00s3aGp+GTJ8dEKJ44chm2keh70vVoX2rQ2r8QmWJ23PAHiY9oTsVblhjDw+Y1RonKw8hci/0u3o4rYqsgUumXcD9o7pIZ03ja2f0TQsX0DVMwvVQKOZ7vk7EGXHHiSO9g+dsprV+ktOOGplY9svVVPVeKjoJpBVUravkTaGmemfhxN34tPUzVKzhdhg7ChxpEgyM+ipb/s8KcAxM0JoeRsWKqbz64kJbrjj/lJZ7gg3uJtoRaujaNF+OBpb6Nhyp30o9UPzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QlQ4/rQ+JwURjaEjoYiSuRVBhtKlg3t12cMC+AUx/Eg=; b=SNENIW4H8A/lAL5gQ8qMuZS8Yq+lPRrIopHSaffWArLjW5DX6B1kBDB79APPJxQ4meJPmaPkZg5tL94Y4QNFBhMeSNkEfGRxjOFlU8eWctBWQ7xwKCUjOevOX64zejlCQ0Qs75934+hCLPrM2c3mu1hyDr4gTTKIQs4mlmaSMF0s1PDBFbAGV/naUWI+bkq9t/73QFgzPXB+pubAkar5qOzQqavd9NtNMOru8aP8RL9kvQH4gAF5thhjTmZMJcWKFuzOP2LF8xkLg3UM0qY5N5uXuLmMduIW/muUZBugzoqHAV4Bs1p3yQouq0LVPsOmphDS0K99Ywn8P/HU5e/aaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5940.namprd11.prod.outlook.com (2603:10b6:a03:42f::18) by PH8PR11MB7118.namprd11.prod.outlook.com (2603:10b6:510:216::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 03:27:03 +0000 Received: from SJ0PR11MB5940.namprd11.prod.outlook.com ([fe80::8a10:338f:c17e:dd7f]) by SJ0PR11MB5940.namprd11.prod.outlook.com ([fe80::8a10:338f:c17e:dd7f%7]) with mapi id 15.20.7002.019; Fri, 17 Nov 2023 03:27:03 +0000 From: "Hu, Lin1" To: "Beulich, Jan" CC: "Lu, Hongjiu" , "binutils@sourceware.org" Subject: RE: [PATCH 1/2] Reorder APX insns in i386.tbl Thread-Topic: [PATCH 1/2] Reorder APX insns in i386.tbl Thread-Index: AQHaFuysmtVkqyupUkS2uOjkHqa7M7B6mqrAgAB5lYCAAXRQYA== Date: Fri, 17 Nov 2023 03:27:02 +0000 Message-ID: References: <20231114025856.863065-1-lin1.hu@intel.com> <5c3a03b9-86a0-4982-a88c-f1d7ac8e229e@suse.com> In-Reply-To: <5c3a03b9-86a0-4982-a88c-f1d7ac8e229e@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5940:EE_|PH8PR11MB7118:EE_ x-ms-office365-filtering-correlation-id: 80b8a035-3c62-41e7-569f-08dbe71d10d6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NaNIV5rAf9XAQZSCKUX/RKlE5UDgZGcAH8ptzbplcRYqapCL1X3xMvPb3aenYpevjemcf2t7+mUG4OO7FNnq1Ap9L3B+BRk9H7+0jArQpk60NndiJOWuZSZBS0MGmLPFDgFkMq+HMa4xubqHBdt4L9Q9Uf5k39Zly/Gk9dWnues7O/11BqnZRnfaw1rEYL5AQ6hCyyLGHxoQc7qL1YtUyCqE7QFNU/EU3Hh0YbNaovvWym5Nnzz5424hGG6cMRGuGZldrbSaZEE91dSaDLb8PUfmctqJS1PUxUfqMAFmX9B3KHx4K1h1B3xV9Mr3SDHrWIhHbooPM21lntUththuwr846PLOkPgHoTNzIUreAR5d459SH8s7cH5qZEI1UpVa54J0iQIhB+2QTYnSRNh2FcQCKjoCMxSPb62G7si34nWPU6XEVP9GqfmBc8In97hj3WqnXj8BzNwb1Qou9HQ6GTJoncLi9b1+PKLdy/nuTqD625lkLTXpVYkeQyBi2JzdiXuUJDj4/+ye3ixDUa1i1LwYUjOw5i3qlITsNfgE6UVlbSM3KygU49qFCYClWIMLPAghPWVLz0x8len9rwyj/tSB1DL0Ja70YSGaEpecbM89x66WMwOSuzwQsr+MXlgP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5940.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(366004)(376002)(136003)(346002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(41300700001)(52536014)(2906002)(5660300002)(86362001)(33656002)(38070700009)(53546011)(26005)(9686003)(83380400001)(82960400001)(55016003)(7696005)(71200400001)(478600001)(6506007)(122000001)(38100700002)(316002)(54906003)(64756008)(6916009)(4326008)(8676002)(8936002)(66476007)(66556008)(66946007)(76116006)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vHUbLuQ/qKs5RMadGnHvFsJH90l2rgvFRUh+/TPLNHIQvv4gAlMQ9pJaTcPm?= =?us-ascii?Q?QlvDTkOfUljYAHEsZ53/eTJ++HpfnNebWneb/ekS6oc/6WSvPFwQzfKlnmcC?= =?us-ascii?Q?PJ6tYdltGtHyeJueB5zT+LQbn0SjUhyFp5gk9wddGIWEJullG3G2p2LFwzcs?= =?us-ascii?Q?VZ5T5NN8KCOHiDbaaI3EY74k+r0DdhcqUk0ml9AriQt5lCATaKDXPjQCsmMM?= =?us-ascii?Q?Dmo+DTjXgIg83h+XHqET9zTQlrMj0H6ZUpWZRpxiL9VSIQx3U0n8ZwW3Y/3v?= =?us-ascii?Q?YI6bFz4NyTLkAYbLJ0m943+FJTfM+hwrs5fQErivv7n0rTw3XAr6giuaxKRT?= =?us-ascii?Q?mIYekx2za6qEje6SvCz4gi517GDCDRgiI7iky/0oSpYNsZHIzizKOQ1QOB/u?= =?us-ascii?Q?IolAyWERRHiIojtDptxqAXpE7w3sQnn6XIMcUiqmRgre5miJz9UBWRJo5m/b?= =?us-ascii?Q?8FAv8t/vYIlDYs+mNpPi/ENA++dlr1D5sHzX1E+OdKX2fIKIQWxgIvco0N2M?= =?us-ascii?Q?PSk/48hp0qEmzC1VEB6IumcRVUYyUYwbEZ+1FfNDF+XcfIJt/FKkE2nyX0xI?= =?us-ascii?Q?ahan0F2XyO35Y8Tqv9a64Q+kLMz55bv2xGz5PExMaY7wGS/pBATOl0/DLrEl?= =?us-ascii?Q?owr0DQbWRKy28eGYVTdwEkx81+qGXD9MADAdW+4APO/4nO0F/ip+/gdrjxHY?= =?us-ascii?Q?A+kwzm4wJUin/Ve+NrpPdE3OAymD783Hh/UzIUL/MQFYrTsB/OvEUT+baotc?= =?us-ascii?Q?X/fdxeoVqtdG5jgkdkd8gFB2qInkw3+8TGtkrkfXRUFLmm6Vs4Faqv9hVYa0?= =?us-ascii?Q?WDNsV2GJPsO5nb5KANMmZXX/kmve1mh6UwUFJ7pn6gI4SwPqsb3ZL6SVzgcg?= =?us-ascii?Q?u37vyD94uuPxNBV75Izr5cMwzMMyt6XeXvhfINuedntZUr50MLtLiOjCrmKu?= =?us-ascii?Q?Urc9RkkIsAndVOji6suAF5+EFGxsl+GPBSsXbXQF7TovGJrtWA1i8tQmSKn8?= =?us-ascii?Q?NStwInEFqSP2MT6K3qqJKLrlh5Qw/0+2fuaUfKNU+J+5Yf6KOCUUbdY5qtMN?= =?us-ascii?Q?K+3DTvFkhIPvde4RBfhT+QfVejVYJp+RNhrs7SQatA8S+akpwA9IDltwitCE?= =?us-ascii?Q?apd8rSvxNUdjcu1r+TB+thpCf3WbWniT5VXz1rj5BMwcHxv9+Kxuk1360vtU?= =?us-ascii?Q?twENrcMq/FMRyxmtuaj1RceriZFw4SDQvRzvVZxVOe104XwN1XScxrXQQq3+?= =?us-ascii?Q?VJXhsXgdic/Qqr3pLOPwWadAQfTj25Y/Ll/zt3HAwNj/iaZKTwx2YpgS59mO?= =?us-ascii?Q?p43umSyk/MNWI6jifzRyVM4Iajzyhn8pyY0b3qa3RikQxfu6qgU3uwPk2Bg2?= =?us-ascii?Q?iuLM0ss5WT94+SRR7UzD2NhFFSf0Ib4aKDT50eH2LgLq8+GwEmVXFZc0y6Sj?= =?us-ascii?Q?xEV7ZrLpFtsX++GKQLhb52JN1yrDTNUmGduD+4vaT5NBvGqURKACfpfdJ0nb?= =?us-ascii?Q?13QB9/NpUDOAtDNwVU6KzpybZewjAFdliY95QVtabt9TGWM23L0/28J0O8ux?= =?us-ascii?Q?WGIS7gWZISdwJSqvHYs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5940.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80b8a035-3c62-41e7-569f-08dbe71d10d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 03:27:02.5454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yHFNPeBxrDgRZEkwsyR77LpGKp2abWPa5xY6UQGgHsXwuqo2uRKP2Lis/aJO57dVaRVht1EBy8AEojmYvgLstw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7118 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Jan Beulich > Sent: Wednesday, November 15, 2023 4:52 PM > To: Hu, Lin1 > Cc: Lu, Hongjiu ; binutils@sourceware.org > Subject: Re: [PATCH 1/2] Reorder APX insns in i386.tbl >=20 > On 15.11.2023 02:49, Hu, Lin1 wrote: > >> -----Original Message----- > >> From: Jan Beulich > >> Sent: Tuesday, November 14, 2023 7:21 PM > >> To: Hu, Lin1 > >> Cc: Lu, Hongjiu ; binutils@sourceware.org > >> Subject: Re: [PATCH 1/2] Reorder APX insns in i386.tbl > >> > >> On 14.11.2023 03:58, Hu, Lin1 wrote: > >>> --- > >>> gas/config/tc-i386.c | 4 +- > >>> opcodes/i386-opc.tbl | 156 +- > >>> 5 files changed, 13189 insertions(+), 10771 deletions(-) > >> > >> What was the goal of sending this patch to the list, without any > >> further comments or explanations? It quite clearly doesn't apply to > >> the present code base. > >> > >> The diffstat is pretty odd, too: There clearly aren't as many files/li= nes > changed. > > > > This patch is just to show you the changes I would need to make if I > reorder .tbl, the big difference in lines is because I removed the change= s to > mnem.h, init.h, etc. in the email. >=20 > Okay, but this isn't going to be a separate patch. It ought to be merged = into > the patch introducing the new templates, so there's not going to be extra > diff or churn. > Don't worry, it won't be a standalone patch, it just seems like lili hasn't= changed it to NDD yet, I send it out for you to look at first. =20 > > >>> @@ -2124,12 +2126,12 @@ xcryptofb, 0xf30fa7e8, PadLock, > >>> NoSuf|RepPrefixOk, {} xstore, 0xfa7c0, PadLock, NoSuf|RepPrefixOk, > >>> NoSuf|{} > >>> > >>> // Multy-precision Add Carry, rdseed instructions. > >>> +adcx, 0x6666, ADX|APX_F, > >>> > >> > +C|Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexV > VV > >> VDe > >>> +st|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, > >>> +Reg32|Reg64, Reg32|Reg64 } > >>> adcx, 0x660f38f6, ADX, > >>> Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf, { > >>> Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } adcx, 0x6666, > >>> ADX|APX_F, > >>> > >> > Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|EVex128 > |E > >> Vex > >>> Map4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } -adcx, > >>> 0x6666, ADX|APX_F, > >>> > >> > Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexVVVV > D > >> est| > >>> EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, > Reg32|Reg64, > >>> Reg32|Reg64 } > >>> +adox, 0xf366, ADX|APX_F, > >>> > >> > +C|Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexV > VV > >> VDe > >>> +st|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, > >>> +Reg32|Reg64, Reg32|Reg64 } > >>> adox, 0xf30f38f6, ADX, > >>> Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf, { > >>> Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } adox, 0xf366, > >>> ADX|APX_F, > >>> > >> > Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|EVex128 > |E > >> Vex > >>> Map4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } -adox, > >>> 0xf366, ADX|APX_F, > >>> > >> > Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexVVVV > D > >> est| > >>> EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, > Reg32|Reg64, > >>> Reg32|Reg64 } > >> > >> What is this part about? I thought we agreed that ADCX/ADOX aren't > >> suitable for > >> NDD->REX2 optimization, at which point the ordering of templates here > >> NDD->could as > >> well be left alone. > >> > > 62 54 bd 18 66 c7 adcx %r15,%r8,%r8 > > 66 4d 0f 38 f6 c7 adcx %r15,%r8 > > > > The code can optimize adcx/adox from NDD to legacy, currently. Do you > mean we don't consider the optimization If the code length remain the sam= e? >=20 > As said before, any optimization we do has to actually result in some sor= t of > win. If neither performance nor code size change, there's no point in mak= ing > any adjustments to what the user has written. >=20 > That said, though: Looks like there would still be a 1-byte win for 32-bi= t > ADCX/ADOX with just the low 8 registers used as operands, i.e. when no RE= X > prefix is needed in the encoding. > OK, I will try to optimize adcx/adox with the low 8 register. =20 > > Jan