From: Alex Coplan <Alex.Coplan@arm.com>
To: Alex Coplan <Alex.Coplan@arm.com>, "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: RE: [PATCH] gas: Fix internal error in S_SET_SEGMENT
Date: Mon, 17 Aug 2020 09:07:33 +0000 [thread overview]
Message-ID: <VI1PR08MB402938855D18FD0D36B9FCCCEA5F0@VI1PR08MB4029.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200803142241.jxtqma5ijk3243vg@arm.com>
Ping.
> -----Original Message-----
> From: Binutils <binutils-bounces@sourceware.org> On Behalf Of Alex Coplan
> Sent: 03 August 2020 15:23
> To: H.J. Lu <hjl.tools@gmail.com>
> Cc: Binutils <binutils@sourceware.org>
> Subject: Re: [PATCH] gas: Fix internal error in S_SET_SEGMENT
>
> Hi H.J,
>
> Sorry for the delay; just got back from some time off.
>
> > -----Original Message-----
> > From: H.J. Lu <hjl.tools@gmail.com>
> > Sent: 22 July 2020 15:40
> > To: Alex Coplan <Alex.Coplan@arm.com>
> > Cc: Binutils <binutils@sourceware.org>
> > Subject: Re: [PATCH] gas: Fix internal error in S_SET_SEGMENT
> >
> > > gas/ChangeLog:
> > >
> > > 2020-07-22 Alex Coplan <alex.coplan@arm.com>
> > >
> > > * config/obj-elf.c (obj_elf_change_section): When
> > > repurposing an existing symbol, ensure that we set sy_value
> as
> > > per other (fresh) section symbols.
> > > * testsuite/gas/aarch64/section-symbol-redef.d: New test.
> > > * testsuite/gas/aarch64/section-symbol-redef.s: Input for
> test.
> > >
> >
> > Why are tests arm specific? Can you put them to ELF tests?
>
> Thanks for pointing this out. I wasn't sure if there was a
> suitably-generic place for these to go, but it seems that the ELF test
> directory is the right place.
>
> See the updated patch attached. The test has been tweaked to fix the
> indentation for targets that assume anything in the first column is a
> label, and to skip on targets that either don't support assignment
> (bfin) or require attributes for sections (h8300).
>
> Is the updated version OK for master?
>
> Thanks,
> Alex
>
> ---
>
> gas/ChangeLog:
>
> 2020-08-03 Alex Coplan <alex.coplan@arm.com>
>
> * config/obj-elf.c (obj_elf_change_section): When repurposing an
> existing symbol, ensure that we set sy_value as per other (fresh)
> section symbols.
> * testsuite/gas/elf/elf.exp: Add new test.
> * testsuite/gas/elf/section-symbol-redef.d: New test.
> * testsuite/gas/elf/section-symbol-redef.s: Input for test.
next prev parent reply other threads:[~2020-08-17 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:23 Alex Coplan
2020-07-22 14:40 ` H.J. Lu
2020-08-03 14:22 ` Alex Coplan
2020-08-17 9:07 ` Alex Coplan [this message]
2020-08-17 11:26 ` Nick Clifton
2020-08-17 13:28 ` Alex Coplan
2020-09-01 15:47 ` Alex Coplan
2020-09-01 23:44 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB402938855D18FD0D36B9FCCCEA5F0@VI1PR08MB4029.eurprd08.prod.outlook.com \
--to=alex.coplan@arm.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).