From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by sourceware.org (Postfix) with ESMTPS id 92AA43857C6C for ; Thu, 6 Aug 2020 16:48:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92AA43857C6C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Alex.Coplan@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zf5pmNWVNu2Un2pBL9EoKp+0q4/pJEO0SRGuU7mkCXI=; b=x/hKXdytTlB77zPFGw2sG7k5nqpMaWMFGIXfp3e8hT5X+3AgYN+hfffve1XKyvicOgd34GeFB+DwfXNfF6GnWNp8/UwZXKeqBqVUUh9t83yqItKMSolxGIZbny4iHVPIMEfjXuJXZg/SaXxytpcfGYG/Skelx9AtavDdNOoJSL0= Received: from DB6PR07CA0098.eurprd07.prod.outlook.com (2603:10a6:6:2c::12) by DBBPR08MB4726.eurprd08.prod.outlook.com (2603:10a6:10:f0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Thu, 6 Aug 2020 16:48:27 +0000 Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::fa) by DB6PR07CA0098.outlook.office365.com (2603:10a6:6:2c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.7 via Frontend Transport; Thu, 6 Aug 2020 16:48:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Thu, 6 Aug 2020 16:48:27 +0000 Received: ("Tessian outbound e8cdb8c6f386:v64"); Thu, 06 Aug 2020 16:48:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 64e40b9f919403a9 X-CR-MTA-TID: 64aa7808 Received: from b647005794ab.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5C5A63EF-FB27-4618-80EC-0FA1D39E3A19.1; Thu, 06 Aug 2020 16:48:21 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b647005794ab.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 06 Aug 2020 16:48:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WGvjWF7D7TG4kpr+cAxYS+1eeebPAYVS/Ko2kzg4oFBMH+nb/dAsL6ELrCBaxsERyreYDpoYtmNzYq+JooThvtH0fnqupc5sI6fVaAH8fJ+cU0/koiJj+RNZXty8M5NCTh+iEF1Hlg4ZnNCXPiyeHhTBA9is4hxI4OKKvrHP5Wk3zt8pUyOe0uyxebEhafF3dQrbPN8zaTVjBOORY5o1DZTxKssb1/4+3NGURf+q8hbl1Pr5PPfBXIhmfqEFB78G/TQ9rLzOsNehz7hQuB1U8WIlYKnhTBAIc7cbQxJ75cUEJ8vjOwuAFyYNvAGTnNphQ3xnS8fLMAeIA0XxG3uHxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zf5pmNWVNu2Un2pBL9EoKp+0q4/pJEO0SRGuU7mkCXI=; b=eLfUXHmisx7EfomPQ0FrcWnMHyQSRBW213WrmTTMKVmSASOo5dRwHPLkieSM8mwt24ANd1eCzRqiLBbKKtv3oyka/VSxRYxW8q56tQGcewc8lZvaLwmFCmOiLJBa7M+6CFLoJQ+4kBdGxzhbBeMSOxaGdmIqY0XpLHGIJoCrn0Bt3gj15oKm2B/ivsxhnoDSIHj5H986vwwja0PDY7Mbq36EM66+oT/yh1dNA+HWdylIl2+tcg+DcecnVB2tsbNkVwrlI/zJjEDVWVPUAZKXEnQlQ3WvkDFA6vb4pi4b/gEU6HsKWgJtosuFkqNROgmhVWGToZXSZJKfGPMiG3qOKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zf5pmNWVNu2Un2pBL9EoKp+0q4/pJEO0SRGuU7mkCXI=; b=x/hKXdytTlB77zPFGw2sG7k5nqpMaWMFGIXfp3e8hT5X+3AgYN+hfffve1XKyvicOgd34GeFB+DwfXNfF6GnWNp8/UwZXKeqBqVUUh9t83yqItKMSolxGIZbny4iHVPIMEfjXuJXZg/SaXxytpcfGYG/Skelx9AtavDdNOoJSL0= Received: from VI1PR08MB4029.eurprd08.prod.outlook.com (2603:10a6:803:ec::14) by VE1PR08MB5023.eurprd08.prod.outlook.com (2603:10a6:803:107::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Thu, 6 Aug 2020 16:48:20 +0000 Received: from VI1PR08MB4029.eurprd08.prod.outlook.com ([fe80::b8ed:5041:249f:6770]) by VI1PR08MB4029.eurprd08.prod.outlook.com ([fe80::b8ed:5041:249f:6770%2]) with mapi id 15.20.3261.016; Thu, 6 Aug 2020 16:48:20 +0000 From: Alex Coplan To: Alan Modra CC: "binutils@sourceware.org" Subject: RE: [PATCH] gas: Fix internal error on long local labels Thread-Topic: [PATCH] gas: Fix internal error on long local labels Thread-Index: AQHWay92hcdq7nsEb0SCNkLCXQwTYKkrHEQAgAAu6WA= Date: Thu, 6 Aug 2020 16:48:20 +0000 Message-ID: References: <20200805135105.vtbqtd5lqcdrqzkm@arm.com> <20200806135602.GG15695@bubble.grove.modra.org> In-Reply-To: <20200806135602.GG15695@bubble.grove.modra.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.1.50.43] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8e0a1363-0f27-45c1-a6bf-08d83a288ab8 x-ms-traffictypediagnostic: VE1PR08MB5023:|DBBPR08MB4726: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eRg9+d/hNk0h5EaK4qYgfFSut2Qz2/WxvgoNs2vvwgGAyVevsEsQXJY3MjwE2CjYap63lyZgbvG31r0Dm8njV4aVOlQrmEYa3fY+Rlv5o8Lh4hBhUutSucpQ8/sir4tRc8bMCvuhPhFK+esHgH2t3MXp5t5cV/OImBSdFExv7G3E0aH7KrpR4UhhbmGE5j6DWhKTTG1iFvj3GPfddOCZe5cVcJDPD8HYfm/3CaD6Ff7SwSzIqHVOaHz2ZrTveiVFl0jLZ9Q71oFg59/amQzHGLzhMWOC/yD5rLZEGf5YBjaxxgug9VQtB7MUQpKho0S89tzCZzpuELq+uGK+QgyMsA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB4029.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(366004)(39860400002)(136003)(346002)(26005)(33656002)(83380400001)(53546011)(6506007)(7696005)(86362001)(8676002)(71200400001)(6916009)(478600001)(4326008)(55016002)(8936002)(316002)(76116006)(66476007)(9686003)(186003)(5660300002)(66946007)(66556008)(66446008)(64756008)(52536014)(4744005)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: L3xyxmHeLe5fxYTcS+TBjyau7wm79kunFaBlPXaZI3j0IYpAFEkQur7kklmLFzRRa58uM39c1smI6Nk1438QqWchjz3zRfTeMz9Y/7QZP4pp3xOGDCcOFv618+3ogTPnJR1dzbvyebO5Zuebnx2PJoMwcj6gVE/HM0mOcyh+u/RKRA8X3Mxp3L22wLOdRaPKKqlxEoDGaYHA25xiOnclN9UPWaAivOpNu5CSBaRyhwnDIwASx186ix4LBL1Sowu/y9t4Tdl4JUUVVb2ySwdCMYSourQhnL2FaOoGVI612ojO2LfLEQvQ0pSpx7sW6J3GEsxXwbxdwxxJ1vPYECKKmzi/Ri8w+Y2dzd/Y1I8Nm/rnQ5Z3ZNTEkuA0mV9D6rI/IPslrf/Pv5M+st6HswxdYgoJAUDkSBQOLYtuNbt5HhFMaqjW5NH/DR0uVobHx2Sbxr54Ci1Xm/fbzNUvG/VU2Ys9m2LeKy/mGmca9nyfzjJAIiyh7fo8og1YpNeFWwQ3sBBBua2fpYeiqWZnPtDuH2ZdJrEm4dseJFirnvEUA/DpdU/CBVMqhXY1qZhD+orx4YRfUZ9p54iylGEYxtn+/NVepvUNMkeYKgKxKSh0DZ33AAwyuSBnrptjAJpmQeFYfjWSyssUO8fr0d4r124PXA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5023 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 14ede8b6-c0a6-4557-c607-08d83a2886a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RATRBkON6ETRz7oF8CfI/cddnYDy8susHZ0scbKxh1sdJ4hmSWa734Zalws1dytW+60KrVi9X1dyEJdDSFyZMJxaELEfuGQ8+EUqs77DER9RNX3Ltp6DP9ri91cYDIwXwZalbRz2idWCmuGfNHZpn3MbZQ4AclkBi7CajrW6bFnnxUkXDlEGLr1AUGb4bTlo5xFGMyjhUONR9NfHUBO57PhPhLmszOAiAp4Sx04biZ5YBTHH+vD6tUCAAUdk2VibrBCBiYFVMEqI1pfsTApN8D0zCjdOz9pgjfot94RqS6juh/Ec4B2tAfFf6v/iu4zcDKEyOPFy50aSE2Vd5mr5rgTBrvoaSZEVSgZQfWlN6uWL7pjpr62W1fyrdXdmf2FQm17Zh4BVvvpiCx9HCsOREg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(346002)(376002)(136003)(46966005)(186003)(55016002)(8936002)(356005)(6862004)(316002)(81166007)(82310400002)(83380400001)(53546011)(70206006)(47076004)(82740400003)(70586007)(52536014)(86362001)(8676002)(478600001)(4326008)(336012)(9686003)(33656002)(5660300002)(6506007)(2906002)(4744005)(7696005)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2020 16:48:27.3315 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e0a1363-0f27-45c1-a6bf-08d83a288ab8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4726 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 16:48:37 -0000 > -----Original Message----- > From: Alan Modra > Sent: 06 August 2020 14:56 > To: Alex Coplan > Cc: binutils@sourceware.org > Subject: Re: [PATCH] gas: Fix internal error on long local labels >=20 > On Wed, Aug 05, 2020 at 02:51:05PM +0100, Alex Coplan wrote: > > * read.c (read_a_source_file): Use long for local labels, detect > > overflow and raise an error for overly-long labels. > > * testsuite/gas/all/gas.exp: Add local-label-overflow test. > > * testsuite/gas/all/local-label-overflow.d: New test. > > * testsuite/gas/all/local-label-overflow.l: Error output. > > * testsuite/gas/all/local-label-overflow.s: Input. >=20 > OK, but fix the following nits please. Thanks. Pushed to master with nits fixed as d27aad4ec307d91a6b9056127c6c248044391d7f. Is it worth backporting? Alex