From: Alex Coplan <Alex.Coplan@arm.com>
To: "nickc@redhat.com" <nickc@redhat.com>, "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: RE: [PATCH] gas: Fix internal error in S_SET_SEGMENT
Date: Mon, 17 Aug 2020 13:28:46 +0000 [thread overview]
Message-ID: <VI1PR08MB4029870F0BEDC7D3028537BEEA5F0@VI1PR08MB4029.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <cddbe47d-60f7-307b-3938-5156f1f09f30@redhat.com>
Hi Nick,
> -----Original Message-----
> From: Nick Clifton <nickc@redhat.com>
> Sent: 17 August 2020 12:26
> To: Alex Coplan <Alex.Coplan@arm.com>; H.J. Lu <hjl.tools@gmail.com>
> Cc: Binutils <binutils@sourceware.org>
> Subject: Re: [PATCH] gas: Fix internal error in S_SET_SEGMENT
>
> Hi Alex,
>
> > Ping.
>
> Oops - sorry.
>
> >> 2020-08-03 Alex Coplan <alex.coplan@arm.com>
> >>
> >> * config/obj-elf.c (obj_elf_change_section): When repurposing an
> >> existing symbol, ensure that we set sy_value as per other (fresh)
> >> section symbols.
> >> * testsuite/gas/elf/elf.exp: Add new test.
> >> * testsuite/gas/elf/section-symbol-redef.d: New test.
> >> * testsuite/gas/elf/section-symbol-redef.s: Input for test.
>
> Approved - please apply.
Committed with one obvious change: as Alan pointed out here [0], it's
best to use #notarget rather than #skip in order to skip tests on
certain targets.
So the test is now:
--- /dev/null
+++ b/gas/testsuite/gas/elf/section-symbol-redef.d
@@ -0,0 +1,5 @@
+#readelf: -x myseg
+#notarget: bfin-*-* h8300-*
+
+Hex dump of section .*:
+ 0x0+ 2a\s+\*
Thanks,
Alex
[0] : https://sourceware.org/pipermail/binutils/2020-August/112743.html
next prev parent reply other threads:[~2020-08-17 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:23 Alex Coplan
2020-07-22 14:40 ` H.J. Lu
2020-08-03 14:22 ` Alex Coplan
2020-08-17 9:07 ` Alex Coplan
2020-08-17 11:26 ` Nick Clifton
2020-08-17 13:28 ` Alex Coplan [this message]
2020-09-01 15:47 ` Alex Coplan
2020-09-01 23:44 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB4029870F0BEDC7D3028537BEEA5F0@VI1PR08MB4029.eurprd08.prod.outlook.com \
--to=alex.coplan@arm.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).