From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10086.outbound.protection.outlook.com [40.107.1.86]) by sourceware.org (Postfix) with ESMTPS id 9DBBE3840C14 for ; Tue, 9 Jun 2020 14:06:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9DBBE3840C14 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Alex.Coplan@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7eesHGWTrtSqYN9u4GqpTCuBFvGBLEMH0u/6xXhLbmU=; b=zXKAHBy1UxOW/bh57BJ3XgPr+zKNyg8Yvs59PKhjw7oUS9crJ9cnnqKZsl/P2tVJcYYDQ7sW7FN8FCMANbSZOfVp9J8RwxMHU2N8fxBnsHdgqJBQGzZbwk1xux0p3i1fIpSAAb+Oo6St0PK4gGDoy4smqC3ObyJMlVPKp60+Vrw= Received: from PR3P189CA0002.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::7) by HE1PR0802MB2489.eurprd08.prod.outlook.com (2603:10a6:3:d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.20; Tue, 9 Jun 2020 14:06:50 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:102:52:cafe::ba) by PR3P189CA0002.outlook.office365.com (2603:10a6:102:52::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18 via Frontend Transport; Tue, 9 Jun 2020 14:06:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; sourceware.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18 via Frontend Transport; Tue, 9 Jun 2020 14:06:50 +0000 Received: ("Tessian outbound 56dbe829191e:v59"); Tue, 09 Jun 2020 14:06:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: de052bb697b618c2 X-CR-MTA-TID: 64aa7808 Received: from 331f1bb5a2a2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 473D16E6-3458-4834-BBED-8C73A19B9A60.1; Tue, 09 Jun 2020 14:06:44 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 331f1bb5a2a2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Jun 2020 14:06:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhbIT+6Htn1zgDYohOcYb5zX+hrvEKicAdaeyVizpzCAR5AwdL0QNV8S1XgIK1FtAN3AeQ51WM/45QiqrqmNvNaX+tczTmmUZaKH8pHlG5rgqvtAUJlQdGpwyqqGi9YGFlUa8xELxRTnYNHxlbm7hBjNG0/+YnEwwMNqXZNG30hvxrEHUsdDAm5LpHfp0k4VuAlP4gMfA4FVbRiOASXH1Ds9LuMp0uvFSANlPMA62VMGwsf1yK/Jsq733uf/R0kRtcSfIBBNSsENleOT/T08GHzSpxs5CYe0VYZIMRK4mqrJgNtGYJrIb2uuVLOKYS0S7woxfwkfGUHGbkqqC2NH8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7eesHGWTrtSqYN9u4GqpTCuBFvGBLEMH0u/6xXhLbmU=; b=hKzzmqgfeEi+fskJZ38Gd6uTQqLUO1QMMZfwMtvyR4b6C8/T7F7p+Fiay9dfk14MxA7px7bw7dt4Pv2cjBDyWEQgIofDuKaqgzz0dd6OV5HVrmo9MHFpUTcOscwK5urxYxlsuTCPwWuOxwdavg7ecf2+/lE50JdMhOlhyY/o0+fPW5+bVgnmpq/i88dytnP2iWYWTkDamGYy4/9BQ4BicrDtYDDA7KDmAH71/CF0rJpe3Hg5V3kTUX/nL5RT1wCdrj++84ZQnzKxgWycSwpeQ3XjOqKQ/jTrzCfPI3hFSowwYU0ftmr7Ifag+20BSPDhCiaB64ai7pcq6P98ATE0rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7eesHGWTrtSqYN9u4GqpTCuBFvGBLEMH0u/6xXhLbmU=; b=zXKAHBy1UxOW/bh57BJ3XgPr+zKNyg8Yvs59PKhjw7oUS9crJ9cnnqKZsl/P2tVJcYYDQ7sW7FN8FCMANbSZOfVp9J8RwxMHU2N8fxBnsHdgqJBQGzZbwk1xux0p3i1fIpSAAb+Oo6St0PK4gGDoy4smqC3ObyJMlVPKp60+Vrw= Received: from VI1PR08MB4029.eurprd08.prod.outlook.com (2603:10a6:803:ec::14) by VI1PR08MB3551.eurprd08.prod.outlook.com (2603:10a6:803:79::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.22; Tue, 9 Jun 2020 14:06:41 +0000 Received: from VI1PR08MB4029.eurprd08.prod.outlook.com ([fe80::88b4:476f:5960:5ae4]) by VI1PR08MB4029.eurprd08.prod.outlook.com ([fe80::88b4:476f:5960:5ae4%6]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 14:06:41 +0000 From: Alex Coplan To: Alan Modra CC: "binutils@sourceware.org" Subject: RE: [PATCH] gas: Fix checking for backwards .org with negative offset Thread-Topic: [PATCH] gas: Fix checking for backwards .org with negative offset Thread-Index: AQHWNcqAewp2bjJxwk2Y+iGAjnKGo6jC0J6AgACaInCADPcYgA== Date: Tue, 9 Jun 2020 14:06:41 +0000 Message-ID: References: <20200529150449.nhukb7pjbyo2cjf5@arm.com> <20200531225203.GJ5475@bubble.grove.modra.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [80.1.50.43] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f971bccb-7d67-4f76-e91c-08d80c7e5aeb x-ms-traffictypediagnostic: VI1PR08MB3551:|HE1PR0802MB2489: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:208;OLM:208; x-forefront-prvs: 042957ACD7 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hw0bD1uRmOEo6inPIllDvmwOAplZL6jKHqrCjDOlAXqKb93zcNxVfhePB+7wgfGq/+577h9Wi+uo3gzsgJZzrxUVUA5P8Sf99odQ//4oQycsKGIbOI3HWbSMig5jE+dXghbl2cegUO5qqjkulrhscYVqyT7K5uYhWLhpsB9EOq8oEpuxX4Zr7tnuhPzi6bd0JBkVAUrke34+CH/dwAv7rogiBqInTyJ42gNC3ME321FJFpaUX1iXOlL80sEEloblTtGKVLZOpFbbmq81OD/nQJEXRHfVlzgmMHvF8KP8dCx8xecZrTnuI99hD1uc52kjWFOonYIRY8AmgDxs1QbUvOHPe7TqC/j2Hy0PbFoU9DYJhUd1DLhnrXtn1AgzQiO9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB4029.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(7696005)(8676002)(4326008)(83380400001)(9686003)(316002)(66476007)(66556008)(2906002)(76116006)(66946007)(64756008)(66446008)(5660300002)(52536014)(33656002)(8936002)(26005)(71200400001)(186003)(53546011)(478600001)(6916009)(55016002)(86362001)(6506007)(142923001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jrlokKmnc4MP3fPsdpRwqWVP0qQ1/6pRJGHkjz/5XRjpjTxgVb2XKErJ+3AmGtYEqFxJfGfVQCXDRHmbeqtNyyFGhy8mB/uVoaUpHr7FYzaV68dfKydECnxM4RhANzKX7QhRSjc4GgdMu9J/yHwgoE1hWVWzuXdy1npExhNtQ+IN22MI/vcJ9w0rQpz+Lf9TVcnqFsRZzJQ3pdboQH6rcQDm3tMhKLr1lCxZY1YVDcnlRMu5RFVJRkPIUIglHlJmctrhqAnW7EOeGKYAkBHiojMc8S4ti3KGNHh11HnpWeQX/V7xY2DxLBZnOtHP8bFgiEeiF2bAA/BvllEsgZO/bFK+RjhVih5+hceXOwXLwvPKTt9Xc/Tr/8Keb4/0Mc6c/TagvJ3MRlWBHWNQqXtmIJMjvCsBeYHrcIeQa0dYrqxNvT15+fgObY/3wiJq1BQhodn1GVBP9rqUWb8GR83Wvt4ptsppc96FEOg+5DOcGSg= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3551 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(136003)(376002)(346002)(46966005)(7696005)(186003)(26005)(6506007)(4326008)(55016002)(478600001)(36906005)(53546011)(9686003)(316002)(6862004)(336012)(86362001)(70586007)(33656002)(81166007)(82310400002)(8936002)(70206006)(52536014)(47076004)(356005)(83380400001)(82740400003)(5660300002)(2906002)(8676002)(142923001); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 6d0314c5-f020-45cc-029e-08d80c7e55c5 X-Forefront-PRVS: 042957ACD7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +umbse7FjCaHwaH32T5wQnesq+2bcMEZWWZ+dBaS4gpKEP3qYqOvfSAKdQBsgQuHr4UQWDEIz4cG0UsCzIRwEb7TWoIbLlApJxNL+Mjn+vsq3elEheSXTG5stDrqq945yw8ZkEeDYwb1jw94mEJqHu5ovlyoa3nI1gVxOdWOYflFQXZhr8/AxAwozC/gLtsn2wvthmIp+3EYMsLeleXAbc5kpsP59g2iiAciW6jMfuyuGxP6lDnjnRu2plJdOnAk1e6cSIQI5rWOj436IM3YK42Imwv5zYkdvc6fIOG0IzjPPZeb2TPVKt4+uEXV2uu0D5VFNJESzbo91ShZ0f9CEAu9btLDubH9VQw5Wfwbi/kr4qGwhBG3zatMWYSWLy1TJEetwEWLTzHN/rZYbQoC4W5iFaMY2EbACk6iIqM/4oA= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2020 14:06:50.2618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f971bccb-7d67-4f76-e91c-08d80c7e5aeb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2489 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 14:06:56 -0000 > -----Original Message----- > From: Alex Coplan > Sent: 01 June 2020 09:07 > To: Alan Modra > Cc: binutils@sourceware.org; Ramana Radhakrishnan > ; nd ; Richard Earnshaw > ; Marcus Shawcroft > Subject: RE: [PATCH] gas: Fix checking for backwards .org with negative > offset >=20 > > -----Original Message----- > > From: Alan Modra > > Sent: 31 May 2020 23:52 > > To: Alex Coplan > > Cc: binutils@sourceware.org; Ramana Radhakrishnan > > ; nd ; Richard Earnshaw > > ; Marcus Shawcroft > > Subject: Re: [PATCH] gas: Fix checking for backwards .org with negative > > offset > > > > On Fri, May 29, 2020 at 04:04:50PM +0100, Alex Coplan wrote: > > > * testsuite/gas/aarch64/org-neg.d: New test. > > > * testsuite/gas/aarch64/org-neg.l: Error output for test. > > > * testsuite/gas/aarch64/org-neg.s: Input for test. > > > * testsuite/gas/arm/org-neg.d: New test. > > > * testsuite/gas/arm/org-neg.l: Error output for test. > > > * testsuite/gas/arm/org-neg.s: Input for test. > > > * write.c (relax_segment): Fix handling of negative offset when > > > relaxing an rs_org frag. > > > > This is OK everywhere with the formatting fixed. > > > > > - if (address + fragP->fr_fix > target) > > > + if ((offsetT)(address + fragP->fr_fix) > target) > > > > if ((offsetT) (address + fragP->fr_fix) > target) > > >=20 > Hi Alan, >=20 > Thanks. I should have mentioned in my original email that I don't have > commit access so I'll need a maintainer to commit on my behalf. >=20 > Alex Does this also need backporting to binutils-2.34? If so, I'll need a maintainer to do it on my behalf. Thanks, Alex