From: Tamar Christina <Tamar.Christina@arm.com>
To: Jedidiah Thompson <wej22007@outlook.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH} Add aarch64-pe support to LD and GAS; refine support in BFD
Date: Fri, 24 Dec 2021 15:57:12 +0000 [thread overview]
Message-ID: <VI1PR08MB5325C4EF3B45AACB27916648FF7F9@VI1PR08MB5325.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BL0PR02MB49004156222C6326360BD9C6937E9@BL0PR02MB4900.namprd02.prod.outlook.com>
Hi Jedidiah,
> +#include "coff-aarch64.c"
> diff --git a/bfd/pei-aarch64.c b/bfd/pei-aarch64.c index
> 99326d16126..a0f926e31ce 100644
> --- a/bfd/pei-aarch64.c
> +++ b/bfd/pei-aarch64.c
> @@ -22,7 +22,7 @@
> #include "bfd.h"
>
> #define TARGET_SYM aarch64_pei_vec
> -#define TARGET_NAME "pei-aarch64-little"
> +#define TARGET_NAME "pei-aarch64"
I don't understand the renaming from pei-aarch64-little to pei-aarch64.
The architecture supports both little and big endian so I would like the endianness to stay in the name.
Additionally this looks like it'll break efi support as the object mapping is now broken in objcopy, so please
undo the renaming and name the new object format with -little as we need to be able to tell from the name
which format it is.
Thanks,
Tamar
next prev parent reply other threads:[~2021-12-24 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 13:07 Jedidiah Thompson
2021-12-24 15:57 ` Tamar Christina [this message]
2021-12-27 17:07 ` Jedidiah Thompson
2021-12-29 11:38 ` Tamar Christina
2021-12-29 18:36 ` Jedidiah Thompson
2021-12-29 21:29 ` Jedidiah Thompson
2021-12-30 11:00 ` Tamar Christina
2021-12-30 13:54 ` Jedidiah Thompson
2021-12-30 10:51 ` Tamar Christina
-- strict thread matches above, loose matches on Subject: below --
2021-12-22 23:19 [PATCH] " Jedidiah Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB5325C4EF3B45AACB27916648FF7F9@VI1PR08MB5325.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=binutils@sourceware.org \
--cc=wej22007@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).