From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id DB34B3858C5F for ; Mon, 20 Feb 2023 10:59:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB34B3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x632.google.com with SMTP id q12so991645pln.7 for ; Mon, 20 Feb 2023 02:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5hZDJytaixYuEias86mNk1aN9rEH0T7yxQyOqc8P0W0=; b=fkjjOOFcnytl2hk1mfkwP5XCy7MJHDeBA/IlJdJ+EkvIefbdcQFS6QR/xxU/FQ94Li i46PM09EWc2W2IDw1ZaOk0lVnz7lVxAbgouDApbcP69/L7wSrNTnGjkpMat8iH1bm2cT +6RuZZ1n/ooxd8W44W8T0ptDAV8bHoWuMIbR8bbzKkQKge3JVE6B4HIY/Mry0XK+DeUN ODyN5ywQDs394O7uH0d1sDtOwnJ0+OcZn0sd361g/uu4dw/Bq5DJG4/b9xL+L8Q23BYv FrXmhpGhPYuW4sUdpq8wUxuMSPmMlQpDvl8lYBRfk5lJOjucHZrcHQOFkSaAydQGX0oK ZUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5hZDJytaixYuEias86mNk1aN9rEH0T7yxQyOqc8P0W0=; b=ymZcTTnK9leNRkOLROlZbdipP+03kntlu3yD8NYh2HSko9Bk9ZS99VeZ9FVccReTX7 N5S1xflD1lrMkclJCElEcITNyir/FSvI2iPiV0Vs9/7NwR2VMlmfEgDp71DfkjQp5Cmu DfBDus/PD6Yw4OAsRWF6aLG65OxmHQChmx5YiqKegH/i1Ubj9De0nLM4vQEehof8hLNS IjDXlOAW9Koh/7NUgavD9u7ElR8K+6xazlPm+Kb1WiCyqeXhs1ZA4QbT+PEYyAqgP0qD 4LO7s170EwWer4FUtQMtjy9DWkczvO0VhO5nY1UOx+NcVr1fFqH7Va9CKokPU0nd67av nyGw== X-Gm-Message-State: AO0yUKWjGk0cKPQWhIlvxzGZtfb5yBp7otMsWBfz9qKzeza95yZyK4d7 YouVrfzdJE6P5kRq/1YFFjVUPVOXjfE= X-Google-Smtp-Source: AK7set85mFHPtMJOv35IlsGKPvhrNzXG3fFQNjTqMdlwJ96a6wv9Y3OEoxPeDjCcCdi1DAXFymhOKw== X-Received: by 2002:a17:902:d489:b0:19a:68b2:5458 with SMTP id c9-20020a170902d48900b0019a68b25458mr3793015plg.63.1676890794872; Mon, 20 Feb 2023 02:59:54 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:dcfd:f62d:8c9e:f515]) by smtp.gmail.com with ESMTPSA id b12-20020a170902b60c00b0019472226769sm1033490pls.251.2023.02.20.02.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 02:59:54 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 508791142824; Mon, 20 Feb 2023 21:29:52 +1030 (ACDT) Date: Mon, 20 Feb 2023 21:29:52 +1030 From: Alan Modra To: =?iso-8859-1?Q?Cl=E9ment?= Chigot Cc: binutils@sourceware.org Subject: Re: [PATCH 2/4] ld/testsuite: don't output to /dev/null on mingw hosts Message-ID: References: <20230220082224.415968-1-chigot@adacore.com> <20230220082224.415968-2-chigot@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230220082224.415968-2-chigot@adacore.com> X-Spam-Status: No, score=-3034.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Feb 20, 2023 at 09:22:22AM +0100, Clément Chigot via Binutils wrote: > Mingw doesn't have /dev/null and thus "-o /dev/null" will fail. > Currently, all the options are checked using this "-o /dev/null", > resulting in them being disabled on mingw hosts. Fix that by > outputting to a real .exe file. > > ld/ChangeLog: > > * testsuite/config/default.exp: Replace "-o /dev/null" by a file > on mingw hosts. I think I'd prefer this to always output to a file, which you should delete afterwards. > --- > ld/testsuite/config/default.exp | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/ld/testsuite/config/default.exp b/ld/testsuite/config/default.exp > index 257fd4ba985..776b33842c2 100644 > --- a/ld/testsuite/config/default.exp > +++ b/ld/testsuite/config/default.exp > @@ -383,6 +383,9 @@ proc compiler_supports { flag args } { > append flags " [board_info [target_info name] ldflags]" > } > set fn "cs[pid].c" > + if [ishost "*-*-mingw*"] { > + set fno "cs[pid].exe" > + } > set f [open $fn "w"] > if { [llength $args] > 0 } { > puts $f [lindex $args 0] > @@ -391,7 +394,12 @@ proc compiler_supports { flag args } { > } > close $f > set rfn [remote_download host $fn] > - set avail [run_host_cmd_yesno "$CC_FOR_TARGET" "$flags $flag $rfn -o /dev/null"] > + if [ishost "*-*-mingw*"] { > + set avail [run_host_cmd_yesno "$CC_FOR_TARGET" "$flags $flag $rfn -o $fno"] > + file delete $fno > + } else { > + set avail [run_host_cmd_yesno "$CC_FOR_TARGET" "$flags $flag $rfn -o /dev/null"] > + } > remote_file host delete $rfn > file delete $fn > return $avail > -- > 2.25.1 -- Alan Modra Australia Development Lab, IBM