From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id DD3953858C3A for ; Tue, 21 Feb 2023 05:54:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD3953858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1029.google.com with SMTP id x34so131948pjj.0 for ; Mon, 20 Feb 2023 21:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=UAJ47cF4NbiiTwty51vaMQOV32FVwV+1ZKrMZiFg3h8=; b=kBe09AYcdID5iPpFNDiSqi6azQZlLE+yJLCRL5pyxxVHGmpap0MRrnNaks1Jvlx2b0 oIW5YJQZX4891arFfh3NcmXtg5ka0kmbUa2ViBoDnlM7bX5fujzot3dqKgebFDfl/0ZI ACMuOUDBpEzAMyNnWb2PhM4dRN6pocZU46T+wMv/6BiCT91YbQiP7kafzuVSuWORl/+5 YL1x7usAYkojiIlK+e3/JB55XWRysm6bFWmBgTRFRMIpwUtWBWeVFsHl3XBDnESjq2DT yRlCmZZI0ISvSmUJVyG7HPyYs5dKOy5jhmhYf635fEevZ7UYGEax9skH9GUNGsHw5fUH DvxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UAJ47cF4NbiiTwty51vaMQOV32FVwV+1ZKrMZiFg3h8=; b=CmaQkgZxVFdk5Ea1kU5EVf5G0lCMk2inM/LUvAfpptTJEMIXB8QGNBSujNYluFfZIn VMqmgKCMBfMtnXBNdacvPa70sgXK3bTvYmbnRUX3Kh/Knb6hdBSU+Y+ArW1dUPWL6w2E wVHbqREBJZ/Kp6Y2Dn7lE92jT5FUrb4J1jilOpiC1w7UjKGFvXtvf8jWuQuc5pqniMm7 fuwnEVxXneNUgaLVR2HW9kjJb8iG7Ejs+gRQrPQmGqNSjzZ1OYDX+mkFFPFXdxVkUWom PHGKEFYijn+mqUYX99Jg3srrIviVVYj+7/FPCuTApBQneRMXl1xT6HyqXkM88DwPUFyv rCyw== X-Gm-Message-State: AO0yUKWGY2EvH3B7SxnZNQq/LsSuFMIErTB6UKHQ8QbeFmL+XH8ORHoP +vPZZbvbNbaN/Mnqti25QFL+gVs1JXE= X-Google-Smtp-Source: AK7set//qsjOy+sdHzxHRnPhNF3lxXW2xEJGyhv5h6iMFGPA05VBjl+RjyVfJ6+zjv5D7aW9Fv2WWw== X-Received: by 2002:a17:902:fb4d:b0:196:8a80:4d91 with SMTP id lf13-20020a170902fb4d00b001968a804d91mr3676982plb.35.1676958840760; Mon, 20 Feb 2023 21:54:00 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id x5-20020a170902ea8500b0019c32968271sm2491345plb.11.2023.02.20.21.54.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 21:54:00 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 172751142D4E; Tue, 21 Feb 2023 16:23:58 +1030 (ACDT) Date: Tue, 21 Feb 2023 16:23:58 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Both FAIL and PASS "check sections 2"? Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * testsuite/ld-checks/checks.exp (check sections 2): Don't continue on with rest of test past first fail. diff --git a/ld/testsuite/ld-checks/checks.exp b/ld/testsuite/ld-checks/checks.exp index a0b6ade00c3..52b4088637a 100644 --- a/ld/testsuite/ld-checks/checks.exp +++ b/ld/testsuite/ld-checks/checks.exp @@ -61,17 +61,18 @@ proc section_check {} { # Make sure that we got some output from the linker if [string match "" $exec_output] then { fail $test - } + } else { - # Now remove our expected error message - regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output + # Now remove our expected error message + regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output - # And check to see if anything else, (unexpected) was left - if [string match "" $exec_output] then { - pass $test - } else { - verbose -log "Unexpected linker message(s): $exec_output" - fail $test + # And check to see if anything else, (unexpected) was left + if [string match "" $exec_output] then { + pass $test + } else { + verbose -log "Unexpected linker message(s): $exec_output" + fail $test + } } } -- Alan Modra Australia Development Lab, IBM