Re: `strip: X.so could not create temporary file to hold stripped copy: cause of error unknown`

[Alan Modra <amodra@gmail.com>]

On Wed, Feb 22, 2023 at 01:24:57AM +0100, Andreas Schwab wrote:
> On Feb 22 2023, Alan Modra via Binutils wrote:
> 
> > On Tue, Feb 21, 2023 at 08:43:56PM +0000, Paul Naidoo wrote:
> >> |strip --remove-section=.note.ABI-tag
> >> /usr/lib/x86_64-linux-gnu/libQt5Core.so.5|
> >> 
> >> However executing the command returns the error: |strip:
> >> /usr/lib/x86_64-linux-gnu/libQt5Core.so.5: could not create temporary file
> >> to hold stripped copy: cause of error unknown|
> >
> > You don't have write access in /usr/lib/x86_64-linux-gnu/.
> 
> I think this will improve the error message:
> 
> diff --git a/binutils/objcopy.c b/binutils/objcopy.c
> index cf830442b3c..98c567bd955 100644
> --- a/binutils/objcopy.c
> +++ b/binutils/objcopy.c
> @@ -4884,6 +4884,7 @@ strip_main (int argc, char *argv[])
>  
>        if (tmpname == NULL)
>  	{
> +	  bfd_set_error (bfd_error_system_call);
>  	  bfd_nonfatal_message (argv[i], NULL, NULL,
>  				_("could not create temporary file to hold stripped copy"));
>  	  status = 1;

Yes, or even better:

	* bucomm.c (make_tempname, make_tempdir): Set bfd_error on error.

diff --git a/binutils/bucomm.c b/binutils/bucomm.c
index df60ce06547..c268fd3d913 100644
--- a/binutils/bucomm.c
+++ b/binutils/bucomm.c
@@ -555,6 +555,7 @@ make_tempname (const char *filename, int *ofd)
   if (fd == -1)
     {
       free (tmpname);
+      bfd_set_error (bfd_error_system_call);
       return NULL;
     }
   *ofd = fd;
@@ -583,7 +584,10 @@ make_tempdir (const char *filename)
 #endif
 #endif
   if (ret == NULL)
-    free (tmpname);
+    {
+      free (tmpname);
+      bfd_set_error (bfd_error_system_call);
+    }
   return ret;
 }
 

-- 
Alan Modra
Australia Development Lab, IBM