From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 303C93858D33 for ; Thu, 16 Feb 2023 22:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 303C93858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x634.google.com with SMTP id v23so3607391plo.1 for ; Thu, 16 Feb 2023 14:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Cke/HonRH3WZfcLmQoVn6z4Ldaw0hHOnQK74EOa1lwM=; b=FXRdpPgpvTAj9IN6kc/gQZ5OVXQf7B3kowAHaPPmY/uRdClzQXxh2Qt7jByZ193qoZ b2j9//TpdRMUpKE790/gbWyNJ6w/Yv+EveW2regqlUDI3V6Ap/vwFQuMhtp6ek4U7Pzk KWXsmM/dFkoTX1jXlDu1cG0jZKT4mxlN/na7owOWH0TD8tBneHYLrLj/iNWNANOFCE89 C+p7BASW1HpyznxzuWoyjJhFMzFDm8fUwZTVDNeWWBvTpCYqgpMit+9S38el3q6Svv/T xnfwg6C5OEIh6nQPV9cyH82anmmLt/doOen4BSaH7ApR9hkvgNvqGUulue+rFRv0xoPD RkgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cke/HonRH3WZfcLmQoVn6z4Ldaw0hHOnQK74EOa1lwM=; b=K7AX/UITh+4pZY6Kt2OzZQth2PWdLUtHxu7CKhn4XCj6EBjSLEGrmw4TUcHa7brfHc gjRfp9sunO+plMKrQS5VYuzQkYuMoQRBPxMEcw0Ov7DNu0TgOw2Wa/TAAq2XjRp3tC/H 8LAj0BHohskRxnvnxQOABrpyHG03WmFm82TXaWs4q6FXzHFOXl9RJVlCFgNyOhKGt4ms gcIqItJlXsiuqG6qt/FA2vTQUts20cJzHIxeKnV2/y+lwM2oyuQqt34EDa7jJbvMHQIK tlDlIXb9Tdkci6ckbcFSxaGNDZv0YcEHPbw3nylVphcXbL929Q0g4CqVTMltuOLJ0Mrh bwIg== X-Gm-Message-State: AO0yUKWtFbzg7mQHVvaUhGUlEk8UoJWVgpTUwAXVubA7g6pJ2lCHhqiZ DMxDEAWST2kUtvWKrmHlt7UOY5YroAQ= X-Google-Smtp-Source: AK7set/o3LIBU+jjRBgD45WNdRwSCDrO4QQ3QhMQ/k4cDpuhJOXKWnvHXEsuH22EjDOqbVCMfZpNng== X-Received: by 2002:a17:902:d489:b0:19a:b033:2bb0 with SMTP id c9-20020a170902d48900b0019ab0332bb0mr9539454plg.46.1676584831842; Thu, 16 Feb 2023 14:00:31 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:e39e:7b87:db68:a9f9]) by smtp.gmail.com with ESMTPSA id j4-20020a170902c08400b00189743ed3b6sm1797057pld.64.2023.02.16.14.00.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 14:00:31 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 277181140C4B; Fri, 17 Feb 2023 08:30:29 +1030 (ACDT) Date: Fri, 17 Feb 2023 08:30:29 +1030 From: Alan Modra To: binutils@sourceware.org Subject: PR30046, power cmpi leads to unknown architecture Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PowerPC ELF always uses bfd_arch_powerpc, so we shouldn't allow the gas -mpwr, -mpwr2 or -mpwrx options to choose bfd_arch_rs6000. Given the possible values of ppc_cpu, I think the as_fatal at the end of ppc_arch will never be reached, so it can be deleted and the code simplified a little. PR 30046 * config/tc-ppc.c (ppc_arch): Return bfd_arch_powerpc for ELF. Delete dead code. diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c index 9450fa74de1..a3af5f5e276 100644 --- a/gas/config/tc-ppc.c +++ b/gas/config/tc-ppc.c @@ -1496,9 +1496,11 @@ ppc_set_cpu (void) enum bfd_architecture ppc_arch (void) { - const char *default_cpu = TARGET_CPU; ppc_set_cpu (); +#ifdef OBJ_ELF + return bfd_arch_powerpc; +#else if ((ppc_cpu & PPC_OPCODE_PPC) != 0) return bfd_arch_powerpc; if ((ppc_cpu & PPC_OPCODE_VLE) != 0) @@ -1507,14 +1509,12 @@ ppc_arch (void) return bfd_arch_rs6000; if ((ppc_cpu & (PPC_OPCODE_COMMON | PPC_OPCODE_ANY)) != 0) { - if (strcmp (default_cpu, "rs6000") == 0) - return bfd_arch_rs6000; - else if (startswith (default_cpu, "powerpc")) + const char *default_cpu = TARGET_CPU; + if (startswith (default_cpu, "powerpc")) return bfd_arch_powerpc; } - - as_fatal (_("neither Power nor PowerPC opcodes were selected.")); - return bfd_arch_unknown; + return bfd_arch_rs6000; +#endif } unsigned long -- Alan Modra Australia Development Lab, IBM