From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Re: Resetting section vma after _bfd_dwarf2_find_nearest_line
Date: Wed, 8 Feb 2023 11:29:46 +1030 [thread overview]
Message-ID: <Y+L0Asdf4CEaMoQF@squeak.grove.modra.org> (raw)
In-Reply-To: <Y+DKOkv+GiK5JKLG@squeak.grove.modra.org>
f.bfd_ptr is set too early to be a reliable indicator of good debug
info.
* dwarf2.c (_bfd_dwarf2_slurp_debug_info): Correct test for
debug info being previously found.
diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
index ab5a9f37ec1..b16ae11e5f2 100644
--- a/bfd/dwarf2.c
+++ b/bfd/dwarf2.c
@@ -5382,7 +5382,7 @@ _bfd_dwarf2_slurp_debug_info (bfd *abfd, bfd *debug_bfd,
{
/* Check that we did previously find some debug information
before attempting to make use of it. */
- if (stash->f.bfd_ptr != NULL)
+ if (stash->f.dwarf_info_size != 0)
{
if (do_place && !place_sections (abfd, stash))
return false;
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2023-02-08 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 9:36 Alan Modra
2023-02-08 0:59 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+L0Asdf4CEaMoQF@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).