From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id ADC693858413 for ; Wed, 8 Feb 2023 23:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADC693858413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1035.google.com with SMTP id pj3so422196pjb.1 for ; Wed, 08 Feb 2023 15:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=9ruWzWkr3DMOTewMoR4gC38tMUM4sSQXw3OcNztOigI=; b=JB7kNrS2Pot3dKYhneoZbuAsvhdwmzOioKMF7BzJn8KxUWL2b/fGqeU2UcMwXG+krl VPt+0wKj8GJXOoiydlcpVjqNVuA7sNhJSAF3+r/W1wMKA8i+GUjfjE5hIlGk/tCOjlNc bOj1fU43q+p51FYax7x4+WKSAEIqNZwKWzXAmfnGkxBID6n+Qz3G85n/pINKfIOFkx2t pGOvzH42QJg46/v7qly9fA2Dn99ZnHjzdIfpgxYhqc4wximkHcwK5bW7CAXDmtIVuZud 0ZC9T9xmhW2TSCZLU8aEL51V7REQNxl5bN7goWnyGxOXQU/S/5/hV+1J0J2QPK0oFNTN Jsig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9ruWzWkr3DMOTewMoR4gC38tMUM4sSQXw3OcNztOigI=; b=A2az3QXfvoB/iVRAQwAI4UJbgeKVrAoQG/K9kP8ONKx7uMngXqcyPg6p92MmXZPHPL y6PCDXi9R83nWi79nLp44dX0erJDsg3ph9mxsDP8glq1jzcCTn+lK9vrWQ67LaTqRq/I 0+B/Lm11jwkdCOdxbMvPKs4aZO3EiqFYUSglKa8db7qGtECV/o1j1+0Z67e5g5nMi8Ve dULvdNzF7kiuTrJTmeH8Sh7FQoR0owmX5eAV5+2EfhzZwGwQGjBftd+QMhtrz87Kz2/8 lYHLHo02lpLbEivKPfPcoLDt8zYzT6mz+ENwtqs901LWfjQn8q/SZHsTTKmfuN+77dON +8Hg== X-Gm-Message-State: AO0yUKUv8+cw9+6LYzuSAD3G4/nxZ0yeuqsRY3J4OdWVDkpQHh9Tu6Pi sM2lKwvHksNasV2y58HzJk0/3wKbpQM= X-Google-Smtp-Source: AK7set9Wb/KI4u+4zKprOWs8+x/zobabQgjZGmjsWSwyUrsfVDRFaNS5x+ebFzNQLTEU+PT+UDOOBQ== X-Received: by 2002:a17:902:cad1:b0:198:fb56:1a0a with SMTP id y17-20020a170902cad100b00198fb561a0amr5948599pld.34.1675898018573; Wed, 08 Feb 2023 15:13:38 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id w22-20020a170902d71600b00174c1855cd9sm7230591ply.267.2023.02.08.15.13.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 15:13:38 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2C53C1142D73; Thu, 9 Feb 2023 09:43:36 +1030 (ACDT) Date: Thu, 9 Feb 2023 09:43:36 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Memory leak in bfd_init_section_compress_status Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * compress.c (bfd_init_section_compress_status): Free uncompressed_buffer on error return. diff --git a/bfd/compress.c b/bfd/compress.c index 2cf8a6c28c9..2a402c3f65c 100644 --- a/bfd/compress.c +++ b/bfd/compress.c @@ -1083,7 +1083,10 @@ bfd_init_section_compress_status (bfd *abfd, sec_ptr sec) if (!bfd_get_section_contents (abfd, sec, uncompressed_buffer, 0, uncompressed_size)) - return false; + { + free (uncompressed_buffer); + return false; + } sec->contents = uncompressed_buffer; if (bfd_compress_section_contents (abfd, sec) == 0) -- Alan Modra Australia Development Lab, IBM