From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id AB8A83858C60 for ; Wed, 8 Feb 2023 23:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB8A83858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x533.google.com with SMTP id v3so433384pgh.4 for ; Wed, 08 Feb 2023 15:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ym57lUnHHdLU5DZ9bA/gfTaKfYr6BA19/xSTw2m9eNs=; b=JyyS64eXcuuLaAuvrXbyGkq0XF9MThRLg2NyT10Q4NcD1Saak+E9qW+KoTDd8oLPyN 5lBf4ZkdDmf8QNS9I5GHgA74d7kpQRmpkrJ8uhSrkdC3OQ3D9ek6O4wbeRnupMxuxUc1 ILM0LkKWDnt0u1J+t5OWQF0ZSy6ZQWb51OBsFYo3kFHHeRcm4NqD4fnmWOy6djVsV1n3 xA1pMDJ6KHvlUqDy7MgmnVldizG8fPP3PTlhtFNBcSGYQlZ3w3NfaVXOgTtvF76wQZOr KedIXY1/72B3zvRASCqXiS6UFZe3BKonaK7Seq1cYF0SUu5Q/sj4MdOUJiuIQOAkgNKG lMoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ym57lUnHHdLU5DZ9bA/gfTaKfYr6BA19/xSTw2m9eNs=; b=XKp+QT8GLUNW+CWH07n79f/LigWU0N/FwrPpUImbkuE3wz6mPcI6U86Tk5CRSIu/vU 8lg7nOMUC8yMNSqjNhfEoQm+04/Lo9l+TvrF4P8o6Opg0CKpZ5RWetMGjwg6+QNCLr8G vsG6aq5wQTd2v2vqN0Atdww8tRJajxEfPNuHnJc9v9GN5gGHSBMT8KRlj9vDNzomBRAB 7Zf0unKPkI2MKEC1pqGZVi8jB5NsKAFcTLTHds9Fel+PcNbsWwgg0vFI9DHEOzANd3aT cjqeqZWA8v1JBrH/r8sLm/pcmrivrFQZ95w+IY+xxSie0PH1bo0+xu1sO9KxqlzfhiR6 2cVA== X-Gm-Message-State: AO0yUKU2+4WJPA8vFzM97w0BnIpcXsHaOfyS3Qi+cQ/Tz1vUiRS2FuSM rF+lU79ZV+boZwmKf4KSVyf+WY8ttVc= X-Google-Smtp-Source: AK7set95rM1ZmiV8KliKcksUlHlzYAS9RVLwxV0k+5ZNvT3XFrRvGfpBh1000WORwZEi6LbwUZExrA== X-Received: by 2002:a62:19d0:0:b0:5a8:455a:694f with SMTP id 199-20020a6219d0000000b005a8455a694fmr3262396pfz.4.1675898065584; Wed, 08 Feb 2023 15:14:25 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:2c19:e063:cb3b:da4]) by smtp.gmail.com with ESMTPSA id b205-20020a621bd6000000b0058bc37f3d1csm11774985pfb.44.2023.02.08.15.14.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 15:14:25 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 186821142D73; Thu, 9 Feb 2023 09:44:23 +1030 (ACDT) Date: Thu, 9 Feb 2023 09:44:23 +1030 From: Alan Modra To: binutils@sourceware.org Subject: coff-sh.c keep_relocs, keep_contents and keep_syms Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: keep_relocs and keep_contents are unused nowadays except by xcofflink.c, and I can't see a reason why keep_syms needs to be set. The external syms are read and used by sh_relax_section and used by sh_relax_delete_bytes. There doesn't appear to be any way that freeing them will cause trouble. * coff-sh.c (sh_relax_section): Don't set keep_relocs, keep_contents or keep_syms. (sh_relax_delete_bytes): Don't set keep_contents. diff --git a/bfd/coff-sh.c b/bfd/coff-sh.c index cc6faac4e80..314b796ac8b 100644 --- a/bfd/coff-sh.c +++ b/bfd/coff-sh.c @@ -905,12 +905,7 @@ sh_relax_section (bfd *abfd, the linker is run. */ coff_section_data (abfd, sec)->relocs = internal_relocs; - coff_section_data (abfd, sec)->keep_relocs = true; - coff_section_data (abfd, sec)->contents = contents; - coff_section_data (abfd, sec)->keep_contents = true; - - obj_coff_keep_syms (abfd) = true; /* Replace the jsr with a bsr. */ @@ -1027,12 +1022,7 @@ sh_relax_section (bfd *abfd, if (swapped) { coff_section_data (abfd, sec)->relocs = internal_relocs; - coff_section_data (abfd, sec)->keep_relocs = true; - coff_section_data (abfd, sec)->contents = contents; - coff_section_data (abfd, sec)->keep_contents = true; - - obj_coff_keep_syms (abfd) = true; } } @@ -1435,8 +1425,6 @@ sh_relax_delete_bytes (bfd *abfd, if (val > addr && val < toaddr) bfd_put_32 (abfd, val - count, ocontents + irelscan->r_vaddr - o->vma); - - coff_section_data (abfd, o)->keep_contents = true; } } } -- Alan Modra Australia Development Lab, IBM