From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 1C9EC385AC30 for ; Tue, 11 Oct 2022 13:03:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C9EC385AC30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x632.google.com with SMTP id z20so13109264plb.10 for ; Tue, 11 Oct 2022 06:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PmLk6RytGu8y6vzPJuG+KD3Ft4usBYrtxY2JZT0AV9A=; b=pZhG6cqmhYR8d5WEHQePq/CLIT+eNbblNdXDqHXoRtfTSpGG0xaDccg7nzI6rCClJs srxbCpbPLZerhM1jG8NploWxoYiyuzFjViJ9yf+wq6Ypq3i74emJRoljrB0uxGQ3Iptd ShdQ6de4Pzz+785WA10E6FzBGIlLbKYLJgIUED+/NNKMQCeBX7Jsw7QRkcjFiiaE5PQa 8kJ7Q96KmHmHOc3/sv/ENBezBGUmFQ1U4erda5pv2xFJ68/kNcGZWz2quSZBNltdVGgU 62zB6U14BF4o6qwHAkfcKVgkPWEbT1AwaTE86+B/N5gNuBtWh+odHW7wm6dvtO9JbxC8 zHow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PmLk6RytGu8y6vzPJuG+KD3Ft4usBYrtxY2JZT0AV9A=; b=EjaXfIihN0X+Fm6uxSwl1jTvmHUYvai17/lsrZGX1LP0dcbjlZAgu5GOWgu21oTKBl x/Xg5hN60TCaV/906YxzvjIusvIAdRkhbHwGoajoWZyWg2WUPC4JT4ucBjOmfcF8SHpT EwFGkuUtoa2rzob1ccBgZXjgeDQyjMIRy2EBUhh1wFld7NnxIECvoZbhn0rYbRsLGN89 5kl3PgusZ2WHynME+evIYmD6bEOIruOeqXpBpCMWHeiD2dpSrm+y6Dm/ImU/isihAiPe vbSXY+Yi0VIcEf9ML4o2EmhBLlP/4X+V6VgzT1lzZt7R+VFUVK9ZN8yo0sab4SKcq7xp wLIQ== X-Gm-Message-State: ACrzQf0oOXuRofI5dixrDwP5xUo0TOp8XoeNNiCrm8w3bRVtCDdhg/ej gmY4cUfUu6EiDV3bJ7uOWyao4dx7+iw= X-Google-Smtp-Source: AMsMyM5lELkRJM+oK46J3iTJkwDqnnxDZ23a7D7+pPoyALTyqJzA0cPnlZMof6xZbFB6UYzgqRDCfQ== X-Received: by 2002:a17:902:b283:b0:182:dcf0:4a24 with SMTP id u3-20020a170902b28300b00182dcf04a24mr8198172plr.76.1665493414329; Tue, 11 Oct 2022 06:03:34 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:ac9:7610:5cb5:4577]) by smtp.gmail.com with ESMTPSA id q4-20020a170902dac400b001728ac8af94sm8584677plx.248.2022.10.11.06.03.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 06:03:33 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 701931142DE2; Tue, 11 Oct 2022 23:33:30 +1030 (ACDT) Date: Tue, 11 Oct 2022 23:33:30 +1030 From: Alan Modra To: Tsukasa OI , Fangrui Song Cc: Jan Beulich , binutils@sourceware.org Subject: Re: @CPP_FOR_BUILD@ problem since binutils-2.38 Message-ID: References: <3e8b00a1-6101-0b75-712b-f5b0ea29a24a@irq.a4lg.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e8b00a1-6101-0b75-712b-f5b0ea29a24a@irq.a4lg.com> X-Spam-Status: No, score=-3027.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 10, 2022 at 03:50:31PM +0900, Tsukasa OI wrote: > On 2022/10/10 9:43, Alan Modra via Binutils wrote: > > To merge with gcc's copy of configure.ac we need to revert changes to > > configure.ac in the following gcc commits: > > dc832fb39fc0 2022-08-25 > > fc259b522c0f 2022-06-25 > > Then reapply configure.ac changes in binutils from these binutils > > commits: > > 50ad1254d503 2021-01-09 > > bb368aad297f 2022-03-11 > > e5f2f7d901ee 2022-07-26 > > 2cac01e3ffff 2022-09-26 > > Plus copy over gcc's config/ax_cxx_compile_stdcxx.m4, then regenerate > > configure. configure.ac diff from current binutila shown below. > > Hmm, generally good (I wasn't sure that applying GCC's configuration > script's DSYMUTIL and OTOOL substitution is safe enough [because I don't > have any modern Mac]. As long as this is tested on the GCC side, this > change is okay). > > One thing I have to point out is, this commit creates an unsubstituted > variable: PKG_CONFIG_PATH. Commit 2cac01e3ffff you mean. Fangrui, would you take a look please? > So, we have to create a GCC patch to subst > this and sync with Binutils. Am I right? At one time there was interest in combined binutils+gcc builds, but I think that is no longer supported by gcc. At least not actively supported. That naturally results in less interest by gcc maintainers in binutils specific top level patches. Despite that, some of the gcc maintainers have done a stellar job in the past of handling these sort of patches. However, I know at least one of the four binutils configure patches I identified has been submitted to the gcc project already. No OK given. I can't tell people to submit patches to gcc that are ignored, and I also can't reasonably expect gcc folk to review binutils or gdb patches. If we're going to continue with shared top level files, with the gcc repo being the master, then I think the gcc project needs to extend review and commit rights to binutils and gdb maintainers for areas that affect binutils and gdb. -- Alan Modra Australia Development Lab, IBM