From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id D4870385C407 for ; Mon, 31 Oct 2022 10:18:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4870385C407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52b.google.com with SMTP id s196so10299031pgs.3 for ; Mon, 31 Oct 2022 03:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GHN0wlwOU6uiUdcjBdeR+rJ9vCyebyG8+RPplMT82bk=; b=N7PDZZK84UkSBQD5iEvQ+g2gswOl8awdFIqu/nZOqXtZNGmXnr21WTkKuT6hdFzPzX hw0nXeqq+9Adog8MU0RxjiK1MDWDpJX+6/ecBI27QKXd7k84H/LowZbSM+PajeExoSEc scU5tkejSJ5fRjnX3HoTx5sIDDMIABlCUpUGnq9pGGN5tTkeZx+tQxcA4G2yyyRDDxw5 VjrvDp27NWT9JG8XVTlG9JQ7pWoX1pV9hSVxd7bvddsI0isIzpjGC51SSUSXDRFrIMJK zhrt11OnMDxXpkPAeLgzH2bc974aL212BG+eYORncGUL6iYmpIVGcx5ydDWMfeZf19GQ ovdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GHN0wlwOU6uiUdcjBdeR+rJ9vCyebyG8+RPplMT82bk=; b=4ISRtS6EIsmKZ6NmGmOPTU1sBVookC2ZgUUatpJeLjOfSc3R9IycC0K/wvn2nYeZj1 3xNhdvB+bduyenwgwUHWzoeZ/3G7xBiMC5agjMf9IBnyU4ixUF3KLK/W07t/4FCgFSgz /PW2MPXa0Sw13nhB34Eec2OfuP/8Ubpp6Bs5qVm+YyJTUh8WLsK4TV8aa+iKEz8voAXE ZHeFbBL1oR+e8KcIcG4IGFiG5hwzVqCi4MXJkghFP77V8tDwlhVsYhk269CHJ9lgQfEx 2EUbTDx0ctoGZCIol5h7gajG5FXBkoHQCvORyDypWUIPT8eCRHlEg1rW51nxQHbnU6f7 zbZg== X-Gm-Message-State: ACrzQf2Z0Cp9RX3M1T2ZxY8NbCPRA+o11BC1vJCZcVYZ88RRkx4dShi5 fRs8r5looBVRoLwhu9ozQZAt+OsQJQg= X-Google-Smtp-Source: AMsMyM54MxE6pXsqXJI7v86dC/bDyMq3LbgM2eXGcxIsz/lfvUIQAjC2SGFvkqnXJV7d6qT9AHrUig== X-Received: by 2002:a63:ce0f:0:b0:46f:868f:291 with SMTP id y15-20020a63ce0f000000b0046f868f0291mr10013935pgf.23.1667211487397; Mon, 31 Oct 2022 03:18:07 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:bae2:45cd:8c9a:d18b]) by smtp.gmail.com with ESMTPSA id mz9-20020a17090b378900b0020a0571b354sm3814298pjb.57.2022.10.31.03.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 03:18:06 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 05F42114003E; Mon, 31 Oct 2022 20:48:04 +1030 (ACDT) Date: Mon, 31 Oct 2022 20:48:04 +1030 From: Alan Modra To: Michael Tokarev Cc: binutils@sourceware.org Subject: Re: Fix small objcopy memory leak Message-ID: References: <21691094-d184-2eef-8bcc-7eb6d355d7e8@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21691094-d184-2eef-8bcc-7eb6d355d7e8@msgid.tls.msk.ru> X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 31, 2022 at 12:24:21PM +0300, Michael Tokarev wrote: > 29.10.2022 07:52, Alan Modra via Binutils wrote: > > * objcopy.c (copy_archive): Free l->name. > > > > diff --git a/binutils/objcopy.c b/binutils/objcopy.c > > index d20aaef9f4f..03350babb69 100644 > > --- a/binutils/objcopy.c > > +++ b/binutils/objcopy.c > > @@ -3744,6 +3744,7 @@ copy_archive (bfd *ibfd, bfd *obfd, const char *output_target, > > bfd_close (l->obfd); > > unlink (l->name); > > } > > + free ((char *) l->name); > > btw, why you cast it to char* ? To explicitly remove the const qualifier. Otherwise we hit a -Wdiscarded-qualifiers warning when l->name, a const char*, is implicitly cast to void* by the free() prototype. -- Alan Modra Australia Development Lab, IBM