From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 171EC3858CDB for ; Sun, 30 Oct 2022 14:42:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 171EC3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 48BF0340EC5; Sun, 30 Oct 2022 14:42:05 +0000 (UTC) Date: Sun, 30 Oct 2022 19:12:43 +0545 From: Mike Frysinger To: Indu Bhagat Cc: binutils@sourceware.org Subject: Re: [PATCH,V3 11/15] libctf: add libsframe to LDFLAGS and LIBS Message-ID: Mail-Followup-To: Indu Bhagat , binutils@sourceware.org References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-12-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="86l5hN87xBFgJvcW" Content-Disposition: inline In-Reply-To: <20221030074450.1956074-12-indu.bhagat@oracle.com> X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --86l5hN87xBFgJvcW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: > --- a/libctf/configure.ac > +++ b/libctf/configure.ac > > -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS" > +LDFLAGS="-L../bfd -L../libiberty -L../libsframe/.libs/ $ZLIBDIR $LDFLAGS" libbfd is using libtool which generates libbfd.la which should contain the libsframe linking info, so do you really need this manual -L ? and if you really do, doesn't -L../libsframe suffice ? > -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS" > +LIBS="-lbfd -liberty -lz -lsframe $ZSTD_LIBS $intl $LIBS" similarly here, the libbfd->libsframe dependency should be tracked by the libtool linker script ... -mike --86l5hN87xBFgJvcW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNee88ACgkQQWM7n+g3 9YHflQ/+Omv4ri+ZoxLatHCRNqUOhwC9By4GW0tH9HfvPjVFCANg46AeTfUN5RoU HXRsTXMY5ug9XpfbhCb2caXEEeWrRJjid8femTguJfVXPBQs7XkT57y23Jroqg6H K0n/pV08PNDJNzXixSCzTfsrRnKoUDZNpN0ldJjnSPHJvuCVdgyicsMIf5bQgwZk 7vInyOGyXjcoVkPO1gqJXY4ns5q/rvk3gXoltgm5oJGzSOStVJZZHlnYYXRi+R6y kcWIqzEbuOGy7GNO0ynEAZ6fs/F0E9z/rva6Bs/+X7Nc6KwBWgx6foWQOVIpXHSu MmmVgphFxYgBBVmnzry4rSl/addbxzZ1KyBpIkcW656YTQ/1mySGPfjm/C/TcT1v IwDpaurvpxMxSxgu7yVEeJ4ObFU2GeCR5eMn7fBOarOhWanyHybrUaGOdpKyt9U1 AZMHR3HZSUPO+Ga/Blu5/E1jWth5Uqxn/AzofoZwEM+gUK/2R5Kb2hrD0pQ4Fs/L U5PBrblaH9A6HgPJp3b9IRxmyY1XIDZKxXpkfCFiWV1xBe7a9WXUZOUPH8GePtY9 382plnEQJKAoxzG1G1w20F6PCo81EE1V9qgbvJkd4fxSIh4ILfvBQQL3ZbGyN4F1 GvNSdGynXoLGpOzVJh9xv/qx8aunpgi7ln0pn6fM614750z71TM= =Zs+J -----END PGP SIGNATURE----- --86l5hN87xBFgJvcW--