From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 054183858D32 for ; Sun, 30 Oct 2022 15:29:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 054183858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 81C0B340F30; Sun, 30 Oct 2022 15:29:13 +0000 (UTC) Date: Sun, 30 Oct 2022 19:59:51 +0545 From: Mike Frysinger To: Indu Bhagat Cc: binutils@sourceware.org Subject: Re: [PATCH,V3 09/15] unwinder: Add SFrame unwinder tests Message-ID: Mail-Followup-To: Indu Bhagat , binutils@sourceware.org References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-10-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jfBoaYsqj7f/0aAA" Content-Disposition: inline In-Reply-To: <20221030074450.1956074-10-indu.bhagat@oracle.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --jfBoaYsqj7f/0aAA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: > --- a/libsframe/configure.ac > +++ b/libsframe/configure.ac > =20 > +# Determine if we are cross compiling use `dnl` for comments in .ac files > +AC_CANONICAL_HOST this only sets up $host, but you're also checking $target. you should be using AC_CANONICAL_TARGET. https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/ht= ml_node/Canonicalizing.html > --- /dev/null > +++ b/libsframe/testsuite/lib/sframe-lib.exp > > +load_file $srcdir/../../ld/testsuite/lib/ld-lib.exp this doesn't seem right to me, but i guess if the ld maintainers are OK with it ... > --- /dev/null > +++ b/libsframe/testsuite/libsframe.unwind/solib.exp > > +# Run the tests only if we are not cross compiling. why ? people need to test cross-compilers too. some folks will never test it with a native compiler because they only ever make cross-compilers, which means these tests rarely (if ever) get run. especially for embedded arches that can't self-host (e.g. nommu). > --- /dev/null > +++ b/libsframe/testsuite/libsframe.unwind/unwind.exp > > +if {[info exists env(LC_ALL)]} { > + set old_lc_all $env(LC_ALL) > +} > +set env(LC_ALL) "C" why ? weird code like this really needs a comment. this is usually a read flag that the test/code is broken. -mike --jfBoaYsqj7f/0aAA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNehtsACgkQQWM7n+g3 9YESjQ/+PhvVdAWhtqPXpAnlrW1I0lr+1R99uprRcGqnnX1pgv8KA9jg177TCo0R IZPGZAO9ez0W8HpvP0aRZanbAPITOBK8qM4MzQks4gwhRcHrjokX71z5U5pOtxDR F9CywqsStMyieBKEn+J4VYJ1wxbCBqeyDOzVB6PZKR1WMqmNGSIIkM3W5NwLSg2y DPscLXsCG6lgR1tCSKExiJQT1MRgztvob1siRf4tcomhgrlboUzvGLT4Q9CiNW/w W6YH3CdP9YZWKpPVuH7au+Y3eyUZhMVsMs+zNah3NeCf0QM2SL1sqoHJA+l2b6wr 8MA5WtdfckQ9+n9GED/pbWvSow+e0RDmk17hHPdAsbW2IJN03nlrcCD3F2GE337J euyry055lV5+K1QTqc/Ht6a3r0evsW/MI9XUR/iEkhloA/IX6dFNeNLHrwOUW+JS ocykatEEy8NrrFuHLasrKJCe0XPJMGVHsAVR/Mlu59xriNEGLfgQjHCyt8Yf4xei E3s15D6lxszDzhcR9LLoYYn0cUn0KJnBo5S35J2Xsvrxy2ccnfOId5E0z/R4Rw7j 9aYv2zmnUN9RQEOlRM9K55V7oeDkoHDrWxEIGZNNn3QYMzehIxZU9t6UZ9iLIbOm 6wWJY6YFnVwDUjiAXstSPpX2IIstUqBZBMq8J/uNatX06BWdAaA= =/C5W -----END PGP SIGNATURE----- --jfBoaYsqj7f/0aAA--