From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 09B233858401 for ; Sun, 30 Oct 2022 15:30:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09B233858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id ABA7B340F30; Sun, 30 Oct 2022 15:30:06 +0000 (UTC) Date: Sun, 30 Oct 2022 20:00:45 +0545 From: Mike Frysinger To: Indu Bhagat Cc: binutils@sourceware.org Subject: Re: [PATCH, V3 10/15] gdb: sim: buildsystem changes to accommodate libsframe Message-ID: Mail-Followup-To: Indu Bhagat , binutils@sourceware.org References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-11-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cqOqL+GQNP9pZLQs" Content-Disposition: inline In-Reply-To: <20221030074450.1956074-11-indu.bhagat@oracle.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --cqOqL+GQNP9pZLQs Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: > [Changes in V3] > - Additional diff in sim/ppc/Makefile.in to accommodate libsframe. > This is needed to ensure --enable-targets=all continues to build. > - Addressed review comments by Mike Frysinger. this doesn't seem to actually address my comments. you're still poking the internals of libtool by accessing files under .libs/. -mike --cqOqL+GQNP9pZLQs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNehxAACgkQQWM7n+g3 9YF3MA//bFNzcbv3N77rolnHjUgsrD1WLBRsoFiUpcwi1HvUfkstshhf+9/gkPXB H5McSpk93YtnUkat3lO5HZgYj74WYrmyPnqmwVEEz0MMT4WIGmlb8SOhokAweiGY TKr2ucZ4nNNqiRkU0oX+YAbd4YNttKYKrB4yO6AWNQK7gi0CLGcGWdH6jruKCxTG 6CGovxOcWF/iilNmIoakvqyD30BnbAXPVgKHHBjNiWq2fUv0si0k2xmRjUYnWHI3 /S6lCA+JswW0E0IEn80BfSoE90uXW5bnhkD9/WItLS5LkAxnCzkWCq6/LOVxlHnD VCP9LNgjFMSxY2TaTKryYz+NuFj8g9LWIeGN92RpJyaUanliHIXmgArWu35Y+lc9 +b4zLHYmeYYs/3jIoC5k+mgL6tGVmZ1sR2SAJgrn9xx6NXoummly4IDie7Zu17yu 1mw2F91GMJU8bawsaCxO5xLOwuqiwthDF2u51KB9N6ZVL08skJZVaplxJ84I2l5n 6PE1e1b6ADD3+szdp8Mw88C277deh5CbFqT1O6XVawG2TMr8gvX+loBuzmRf6cVA vabx9+Wggb9Zc5t/9gofy6erreAQmiLOLAS6vIwFpgXwgcyM8mIT7Rs2t53xO22u FXqqNuM5y5wUgIL54D5UgrGNB042+rNbyVBtgApAAKoafy3Hjw0= =hiba -----END PGP SIGNATURE----- --cqOqL+GQNP9pZLQs--