From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 5BDB2385735F for ; Wed, 26 Oct 2022 06:51:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BDB2385735F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x532.google.com with SMTP id q1so13907568pgl.11 for ; Tue, 25 Oct 2022 23:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=5426nMHCi/LbOoUIWXYWYwsOkj6YECLayQycf5p/Mx4=; b=gnTwqKfhn30S6pN39cowyvV+ZJVPwCBKLKvbb3FwEv/+pEwiY2ndhwX6mb+4KIx2Je IW1PgKiANx8LqgIWX4795699+FUCJwOqbyQPOcCAZW79eG0rDz8flbGqlUrBjMiuj45m Botiq2wXCLe6laxRwLn2QQgmBN0GCj6Of53hGVTTmQ7PZnRE9PzeUubRAhK6SVz0ZdmV qMJBFC5LzPqhqJk0rYg2GggQ+uFdm+ScHzYCIi7PAMiwl/IGVfMHmDNYEQKAbOSxjdzW 4CyT19BNfmTbptwe+MNxFUEqKS0wnPyiSJ29ZlqW4tW7ZtF4nNviDDmCl93UWH7aCOtj P6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5426nMHCi/LbOoUIWXYWYwsOkj6YECLayQycf5p/Mx4=; b=MBK6NpHBB9n3FmXRBaMUvQ+gV+4icYCpG9gIXrKu2eIvJPu3WmsVn/s0lmuQHN1vXR rKDqvmEqnBsrP/Yd0BKrKrdsoKijFdhrlD4yJ5qc8NhhfQedLvycUGgDE0L31GFzPJ0f vR/VURyy5A5Xyh8qENrcvmwCowycbKsZcFV94eWUcWVZN1Q8RAWEAZqP0dYRZtG+TtUQ OniUTuXxe+7weoIM/+8IbdbQtUGMYmN0UKuWWtQSUxnVGNu98yB8I25T1YuebmXzd57O LzDPnEingymnJov1c2vy/QwibVkD0Gg3CKvEMDidUxbETxYzG2hJh6sZBj7oP765eKRL Px1Q== X-Gm-Message-State: ACrzQf0IdaDgDuabB5QinooiCdgJWme186m/K4ZPQMJPU+SLOXjbUgxM PxJnHRJfa6kNa8FnAQtUjRFUBoF9zJ0= X-Google-Smtp-Source: AMsMyM74U2eUVfUucA0SS0lWOgyjhusp12GUth5F6KpmrjkqXMRXk6k8VWSUUuhBhRsRr7YTY7X6aA== X-Received: by 2002:a63:cf48:0:b0:439:7d1c:fedc with SMTP id b8-20020a63cf48000000b004397d1cfedcmr36663027pgj.281.1666767089985; Tue, 25 Oct 2022 23:51:29 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id h14-20020a170902f54e00b00186e2123506sm121361plf.300.2022.10.25.23.51.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 23:51:28 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 3A5801142D9C; Wed, 26 Oct 2022 17:21:26 +1030 (ACDT) Date: Wed, 26 Oct 2022 17:21:26 +1030 From: Alan Modra To: binutils@sourceware.org Subject: segfault in objdump.c reloc_at Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: bfd_canonicalize_reloc returns -1L on errors. * objdump.c (load_specific_debug_section): Properly handle error return from bfd_canonicalize_reloc. diff --git a/binutils/objdump.c b/binutils/objdump.c index a4ab0dbd66c..0825e051ef6 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -4212,13 +4212,13 @@ load_specific_debug_section (enum dwarf_section_display_enum debug, if (reloc_size > 0) { - unsigned long reloc_count; + long reloc_count; arelent **relocs; relocs = (arelent **) xmalloc (reloc_size); reloc_count = bfd_canonicalize_reloc (abfd, sec, relocs, NULL); - if (reloc_count == 0) + if (reloc_count <= 0) free (relocs); else { -- Alan Modra Australia Development Lab, IBM