From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 56BCA382EA25 for ; Thu, 27 Oct 2022 01:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56BCA382EA25 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id p3so15070011pld.10 for ; Wed, 26 Oct 2022 18:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2HgM0m2EM5j6P3TSCLvtTFsAMXo2+fvaQMUXJkEQSVk=; b=OagSbnOH89Tlb7YTC5S9g4S1CEa4oOWKwotmOHbeATQ1lcYOeCR5y7Nhynz0IR22AW FBwGz1suHtXvD2zKDIvccXHX/LSpRCuPvEpCZfykiE8hARq2GG2msmB6qyK6X/CP+tKx KjB/eVwAi7S4e+bfA6DJTIvf9MZTCoH3pRLWSvI87tmHEZCxx08oiAJmfV1Xq/PTPM5p AAzEXp0Qh/BYV636RLI0JVojnFtznsR4u8F8/7f3tvQCQqLN2RwuLlQIalpi2llDyAxH aSZCmS+4CEIefl/TNYJBPaseJ6Ir+wzKTL90YbJPJnqQ5iRrPXN0jEaZy10BzlQBKI8X ReCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2HgM0m2EM5j6P3TSCLvtTFsAMXo2+fvaQMUXJkEQSVk=; b=Hgf00RKBJgmOBorWRItl7Qq+PzfL0ilJmjIzxuntlMVfXWhsieyADP2ylnn9Uq6X5P VOp3Xgfm+LMKXy55mCJyy5x1Ni2/hWF/2XmS05uD+C+K3Zg0M4YTOnk4IRqZc4iS8f/K fjDafbvm0nHTSnOgfFrI7Rlg506prCVa7mUzICn2mDT3cdxM+d4C6KiUHH66KhzNa+/O g+KnyDyxHXGwb0hdI9sCNhlfRk0fcYi1xu3ZyofdaE4G0tZGb2jS3cLtwIRC3zQ205ld 3wlM6kFeSa6L7SrlF3xO0lvqcGVTZMQggNbfuNLtP6QsvN8aUXE+UQ8ONmxHVYfxCEet d6DQ== X-Gm-Message-State: ACrzQf0KKIKRMYZ3VMK0GCoDzqsYFHbGVrQABQ+Z0PbhhV+NSGJa2lFs qks4gtJvd+otvZ57GnUDazNOnZ3dtq4= X-Google-Smtp-Source: AMsMyM7YZ0O3lmV+ahT3R19X1H2U+PSKoP/L51hSnLSCYpo2dsX0QnPzZ1zB/bhirEsUIVXgkN5shw== X-Received: by 2002:a17:90a:198a:b0:213:8a8:dbb with SMTP id 10-20020a17090a198a00b0021308a80dbbmr7248306pji.73.1666833660185; Wed, 26 Oct 2022 18:21:00 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:d42c:562d:4aa6:5ff3]) by smtp.gmail.com with ESMTPSA id p19-20020a170902c71300b001783f964fe3sm3510533plp.113.2022.10.26.18.20.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 18:20:58 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 484A31142D8A; Thu, 27 Oct 2022 11:50:55 +1030 (ACDT) Date: Thu, 27 Oct 2022 11:50:55 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Re: ld/testsuite: adjust ld-arm to run shared tests only when supported Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: commit 67527cffcd enabled previously disabled tests unresolved-1-dyn, thumb-plt and thumb-plt-got for nacl. The first fails due to trying to link against mixed-lib.so which isn't compiled for nacl. The last two fail with objdump: tmpdir/dump(.rel.plt): relocation 0 has invalid symbol index 14885104 and readelf: Error: bad symbol index: 00e320f0 in reloc Relocation section '.rel.plt' at offset 0x128 contains 1 entry: Offset Info Type Sym. Value Symbol's Name e320f000 e320f000 R_ARM_NONE That's weird enough that I figured I ought to mention it in case one of the ARM maintainers wants to look into why ld is producing this executable. Or mark nacl as obsolete due to lack of maintenance? * testsuite/ld-arm/arm-elf.exp: Disable unresolved-1-dyn, thumb-plt and thumb-plt-got for nacl. diff --git a/ld/testsuite/ld-arm/arm-elf.exp b/ld/testsuite/ld-arm/arm-elf.exp index 5a3df83e9f1..e53b9bba723 100644 --- a/ld/testsuite/ld-arm/arm-elf.exp +++ b/ld/testsuite/ld-arm/arm-elf.exp @@ -1247,7 +1247,7 @@ run_dump_test "attr-merge-nosection-1" run_dump_test "attr-merge-hardfp-use-1" run_dump_test "attr-merge-hardfp-use-2" run_dump_test "unresolved-1" -if { [check_shared_lib_support] } { +if { !$is_nacl && [check_shared_lib_support] } { run_dump_test "unresolved-1-dyn" } run_dump_test "unresolved-2" @@ -1272,7 +1272,7 @@ run_dump_test "non-contiguous-arm4" run_dump_test "non-contiguous-arm5" run_dump_test "non-contiguous-arm6" -if { [check_shared_lib_support] } { +if { !$is_nacl && [check_shared_lib_support] } { run_dump_test "thumb-plt" run_dump_test "thumb-plt-got" } -- Alan Modra Australia Development Lab, IBM