From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 002173857434 for ; Thu, 27 Oct 2022 18:50:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 002173857434 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 6AD16340F22; Thu, 27 Oct 2022 18:50:52 +0000 (UTC) Date: Thu, 27 Oct 2022 23:21:29 +0545 From: Mike Frysinger To: Indu Bhagat Cc: binutils@sourceware.org Subject: Re: [PATCH, V2 10/15] gdb: sim: buildsystem changes to accommodate libsframe Message-ID: Mail-Followup-To: Indu Bhagat , binutils@sourceware.org References: <20221017221612.495324-1-indu.bhagat@oracle.com> <20221017221612.495324-11-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6hAsJF6gmrd2G6NG" Content-Disposition: inline In-Reply-To: <20221017221612.495324-11-indu.bhagat@oracle.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --6hAsJF6gmrd2G6NG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 17 Oct 2022 15:16, Indu Bhagat via Binutils wrote: > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -2167,6 +2167,17 @@ fi > AC_SUBST(LIBCTF) > AC_SUBST(CTF_DEPS) > =20 > +GCC_ENABLE([libsframe], [yes], [], [Handle .sframe sections]) > +if test x${enable_static} =3D xno; then > + LIBSFRAME=3D"-Wl,--rpath,../libsframe/.libs ../libsframe/.libs/libsfra= me.so" > + SFRAME_DEPS=3D"../libsframe/.libs/libsframe.so" > +else > + LIBSFRAME=3D"../libsframe/.libs/libsframe.a" > + SFRAME_DEPS=3D"$LIBSFRAME" > +fi this logic is not portable. you're using libtool to generate this library, but then trying to go behind its back and hardcode paths that only libtool is supposed to know about. the "libsframe.so" path doesn't work on macOS, Windows, etc... -mike --6hAsJF6gmrd2G6NG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNawZwACgkQQWM7n+g3 9YF7ihAA1/lnqJotg2sP4Tl9S5DtQeG+nIdTEnh9CGFlQBMOUDU3Ed7b/pfnZlZH O8b/+8f1m5kU+uQdiKz94JXGeqmjKmt1nsDo39M9hGNVck2WBQVPd8DzYqzsb2bN C6WHNfzi5SrEGsZEi2jnIsdb1ygJ9KCuEjq8932/jVXOEI5GgLV+/519HKCxWG84 mujo1X3jqcpMX6JoW4+wukqmrliO/XHKjQ44iwdWypjxMEF8q6p78SCmI233sBbT B2XDbC1gvzRmfIbZEZuMUYayM2omS7pMkR0Sl5A86BDe0/qHmL8YgjTyGg23JRlH VCykHa53LlSkpJrVk/7j8AYiIHhTKhFpc69jTJMrg6kG7KKu/4A6QBDAgG2536tw GfC51lfMiorjzHAa/L09U6IPjHg2iV46x7GsEIo1iBRr6ESVZAlt9HKO/o/NvEY+ qVU7TYDO06+xEXYz9QmvjJ3LvohPSraKp0zMZwVSPjpbAYiOqguFgklBZOGqKPzC NggeiDJy34tg8+oLaz98Q8vlGLNPztfKe0jbtjc8fivcGA4GIQVqy3k+ltfzkAOj XuOOz3vJdGFcKpNtyb/xZqURXRSIES94oZMFRWdMi37I/ijA1p1jbBqLH4UoPo0H yX5jKXyH+2Y/CuF/yuWfI3Q7f3IA6/6JQ0uxDFn4uqP/x/+r3BQ= =New+ -----END PGP SIGNATURE----- --6hAsJF6gmrd2G6NG--