From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 74F41385AC3E for ; Fri, 28 Oct 2022 01:26:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74F41385AC3E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102e.google.com with SMTP id c15-20020a17090a1d0f00b0021365864446so3196629pjd.4 for ; Thu, 27 Oct 2022 18:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cMuYEyLWtvpoGf5Ewyll05tLeYTpl2lWxu7KpdMzBOo=; b=hXM1Te11s8tRCjD9UNvq91r8ej2Lf5yZV+c+7ggOf6XTecWZ6ke+dwcXFcsnwxC2a+ 4vKUyEQl4bq7YVG8bRMNNUxDrKfAibjahRU0KiF6/x+XuDZEhm0IdWCz9LWFV9w0Ldk9 vPe5k9Qqe9bQuHj97fFAQI6k/51lJ0ZPalyaXHkE1fNQarfX04Qvu36Wx/oQE+dBY7x5 /WfUJlYTnCeG+3LkqS3L/7TqwnTyXqp5fmm7HX4f/EmI46g4Zr6RZzV9vhcl01PFYYeR ChR0/argvbQ7O/866ft1Ab1fvH+esT4+TSoxBv0vi2yGVMu0TLnE/+nJMjsKN4AtCrgw /S6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cMuYEyLWtvpoGf5Ewyll05tLeYTpl2lWxu7KpdMzBOo=; b=sIBCzIvpDG8kUFk3VUcFMPQXAW22efXlunRvHIfkK6cv2L6gRWvxAa2nfrWG3yEp0c j9u8F60kXHiBSkcWW/PjrmjFmNeiM8sUMO23349qxgysxHrLj8Eo3ssy+sKCYM7+4lXW iSw9Jaa1r53BjC9L0Ao6IaX2qdMR9lSOwygrm/B5Yu1vEPaAFQVJL8uDG1/fKSLBUooN djmH6NPNKGrfahOnNGTG4Lq+U5qil6Dn62/9hD0pmSTRrKLxlpD9S9srnX3v+mY7Txh4 7xSAHQsLGa/rLAfh3mNUzmeWdekGTCzTvqpFYxvcBCFEygmlZv6cPWQlAwmrZl+dTPIM VA1g== X-Gm-Message-State: ACrzQf1tbCpFCYDNC2zSPs2eNax7rGHBQoL8v8z9ZppG0ZKOfCs9qSaw qBh77wQzaJZ5+BJj6Y/7i2zTul4OuqM= X-Google-Smtp-Source: AMsMyM5IzQkLfwtiJU+NdHnL3TISzhN7lXGJIa/bRTcyMyqnfDwDkd2bs3GKISVDbFccu3NC95LJXA== X-Received: by 2002:a17:902:ce08:b0:179:ed2b:8cd8 with SMTP id k8-20020a170902ce0800b00179ed2b8cd8mr52165980plg.23.1666920397408; Thu, 27 Oct 2022 18:26:37 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id y19-20020aa79af3000000b0056be2a3c87csm1763739pfp.154.2022.10.27.18.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 18:26:36 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 1F89A11427C2; Fri, 28 Oct 2022 11:56:34 +1030 (ACDT) Date: Fri, 28 Oct 2022 11:56:34 +1030 From: Alan Modra To: Mark Harmstone Cc: binutils@sourceware.org Subject: Re: [PATCH 2/2] ld: Add publics stream to PDB files Message-ID: References: <20221027190052.10536-1-mark@harmstone.com> <20221027190052.10536-2-mark@harmstone.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221027190052.10536-2-mark@harmstone.com> X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 27, 2022 at 08:00:52PM +0100, Mark Harmstone wrote: > + einfo (_("%P: warning: cannot create symbol record stream " > + "in PDB file: %s\n"), bfd_errmsg (bfd_get_error ())); You can use %E here and elsewhere rather than %s with bfd_errmsg. With that tweak the patches both look OK to commit. -- Alan Modra Australia Development Lab, IBM