From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: pef: sanity check before malloc
Date: Sat, 29 Oct 2022 15:23:25 +1030 [thread overview]
Message-ID: <Y1yxxfpJz+Jx4KTh@squeak.grove.modra.org> (raw)
And do the sanity check in a way that can't overflow.
* pef.c (bfd_pef_parse_function_stubs): Sanity check header
imported_library_count and total_imported_symbol_count before
allocating memory.
diff --git a/bfd/pef.c b/bfd/pef.c
index d9936f750c1..334d802eb75 100644
--- a/bfd/pef.c
+++ b/bfd/pef.c
@@ -751,6 +751,13 @@ bfd_pef_parse_function_stubs (bfd *abfd,
if (ret < 0)
goto error;
+ if ((loaderlen - 56) / 24 < header.imported_library_count)
+ goto error;
+
+ if ((loaderlen - 56 - header.imported_library_count * 24) / 4
+ < header.total_imported_symbol_count)
+ goto error;
+
libraries = bfd_malloc
(header.imported_library_count * sizeof (bfd_pef_imported_library));
imports = bfd_malloc
@@ -758,8 +765,6 @@ bfd_pef_parse_function_stubs (bfd *abfd,
if (libraries == NULL || imports == NULL)
goto error;
- if (loaderlen < (56 + (header.imported_library_count * 24)))
- goto error;
for (i = 0; i < header.imported_library_count; i++)
{
ret = bfd_pef_parse_imported_library
@@ -768,9 +773,6 @@ bfd_pef_parse_function_stubs (bfd *abfd,
goto error;
}
- if (loaderlen < (56 + (header.imported_library_count * 24)
- + (header.total_imported_symbol_count * 4)))
- goto error;
for (i = 0; i < header.total_imported_symbol_count; i++)
{
ret = (bfd_pef_parse_imported_symbol
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-10-29 4:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1yxxfpJz+Jx4KTh@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).