From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Sanity check SHT_MIPS_OPTIONS size
Date: Fri, 11 Nov 2022 18:03:55 +1030 [thread overview]
Message-ID: <Y23642YK4HTWnn3X@squeak.grove.modra.org> (raw)
* elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Use
bfd_malloc_and_get_section to read contents of .MIPS.options.
diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
index e0e23926f03..932167c15c6 100644
--- a/bfd/elfxx-mips.c
+++ b/bfd/elfxx-mips.c
@@ -7523,11 +7523,7 @@ _bfd_mips_elf_section_from_shdr (bfd *abfd,
{
bfd_byte *contents, *l, *lend;
- contents = bfd_malloc (hdr->sh_size);
- if (contents == NULL)
- return false;
- if (! bfd_get_section_contents (abfd, hdr->bfd_section, contents,
- 0, hdr->sh_size))
+ if (!bfd_malloc_and_get_section (abfd, hdr->bfd_section, &contents))
{
free (contents);
return false;
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-11-11 7:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y23642YK4HTWnn3X@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).