From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 8F3823858D1E for ; Fri, 11 Nov 2022 07:40:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F3823858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x633.google.com with SMTP id j12so3628031plj.5 for ; Thu, 10 Nov 2022 23:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9wbNEeR/xMTRnBp5ZEk1pbyRy4ukl86d5864K47riKw=; b=c8DDX+70X6Luh082arQdvlp6A2u6U6z523bDmS6Ky6cRKS1tdKp70O9RsAw/FmTke0 o+LhP/lgvmWgg75AiWlqlXUY2vTfTzCOX7qObw25kXF5yIfaZ/yanhKcr9OTB8ca2Ckb o48+7LPSQ5fvNEf68wCWcOaEZ/0yFdkCtfWwVMTQ0xqLx9D3UlyoV7W3eBuYJRetr4cV PaOyKCZmHrmycP7uTO6YKVjnmDSYScaBftt6IIDbpkor0ksrVZVAP1XzWJrunkO/Or+h gDtgRWwCXmMeNWHMhYY9HCD9YJgOFqeLb4v7PcRREEnEYlFAi44W4o4byFYv6Dxo75ii YnXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9wbNEeR/xMTRnBp5ZEk1pbyRy4ukl86d5864K47riKw=; b=PaCw8c9CmyfIoW+dzvZrFXT97Szpjda17OHNrKIUzvZal8odTg+B7O95gEk5Gj2L5F HU1l/3slt0W6FLDNhdesTETgk7A5IfuppUwiPDH4pW95kKOVInES+sH/tit97388l/L4 cWxRXc4Vr6qnjT6YpUE4bNsAUKAeMaB62qaGzEQVrzcrArsOppLD1wLmwilpexBCHwzA UMh+q1aThDjxF+f99F4CAxFXWh8sRLyjMtZxu3kKQTSkTmW4exvbWUtTaGo5dS3nX/oZ CYZ/Vkb9gAq2Q8tRftFBA3jH+Q8aXPCWYumb+jZX82Jtvdtm17D3WW5bDJaZ//jOgy+L DaLg== X-Gm-Message-State: ANoB5plyX1upNwc0Eek+9k2jPGg6knGet9B0HdCHOlS5CZkVDdQXvdDa CQyLmBX6DIuPUdppcK1YfSo+zole3KA= X-Google-Smtp-Source: AA0mqf5kxof9JHM1Je9KwZADLIxe6yTWtwtEFpuD23IZUNsOsrWYM722zohSfCnFt1woPlm3BeEekA== X-Received: by 2002:a17:902:daca:b0:17a:a81:2a52 with SMTP id q10-20020a170902daca00b0017a0a812a52mr1280470plx.159.1668152434593; Thu, 10 Nov 2022 23:40:34 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:2ea0:e07f:18a5:e51e]) by smtp.gmail.com with ESMTPSA id b16-20020a170902d51000b00186b9196cbesm958475plg.249.2022.11.10.23.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 23:40:33 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 987AB1142D91; Fri, 11 Nov 2022 18:10:31 +1030 (ACDT) Date: Fri, 11 Nov 2022 18:10:31 +1030 From: Alan Modra To: Cary Coutant Cc: Fangrui Song , binutils@sourceware.org Subject: Re: [PATCH] gold: add --compress-debug-sections=zstd [PR 29641] Message-ID: References: <20221001023846.590825-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3035.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied. Fix the following: compressed_output.cc:86:8: error: assignment of read-only variable ‘size’ 86 | size = ZSTD_compress(*compressed_data + header_size, size, uncompressed_data, diff --git a/gold/compressed_output.cc b/gold/compressed_output.cc index e9f12241f26..f192ddb5080 100644 --- a/gold/compressed_output.cc +++ b/gold/compressed_output.cc @@ -81,7 +81,7 @@ zstd_compress(int header_size, const unsigned char *uncompressed_data, unsigned long uncompressed_size, unsigned char **compressed_data, unsigned long *compressed_size) { - const size_t size = ZSTD_compressBound(uncompressed_size); + size_t size = ZSTD_compressBound(uncompressed_size); *compressed_data = new unsigned char[size + header_size]; size = ZSTD_compress(*compressed_data + header_size, size, uncompressed_data, uncompressed_size, ZSTD_CLEVEL_DEFAULT); -- Alan Modra Australia Development Lab, IBM