From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 207963858C56 for ; Wed, 2 Nov 2022 16:17:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 207963858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id B686134105E; Wed, 2 Nov 2022 16:17:06 +0000 (UTC) Date: Wed, 2 Nov 2022 20:47:46 +0545 From: Mike Frysinger To: Indu Bhagat Cc: binutils@sourceware.org Subject: Re: [PATCH, V3 10/15] gdb: sim: buildsystem changes to accommodate libsframe Message-ID: Mail-Followup-To: Indu Bhagat , binutils@sourceware.org References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-11-indu.bhagat@oracle.com> <0f7e9a96-61fb-22a2-f71e-f3bead83579e@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0bjewhI3UvHlAxo2" Content-Disposition: inline In-Reply-To: <0f7e9a96-61fb-22a2-f71e-f3bead83579e@oracle.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0bjewhI3UvHlAxo2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 31 Oct 2022 13:39, Indu Bhagat wrote: > On 10/30/22 07:15, Mike Frysinger wrote: > > On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: > >> [Changes in V3] > >> - Additional diff in sim/ppc/Makefile.in to accommodate libsframe. > >> This is needed to ensure --enable-targets=3Dall continues to buil= d. > >> - Addressed review comments by Mike Frysinger. > >=20 > > this doesn't seem to actually address my comments. you're still poking > > the internals of libtool by accessing files under .libs/. >=20 > gdb does not use libtool yet. you have access to the source. you can change these things. also, gdb & sim are sep projects. > I see that opcodes/Makefile.am bfd/Makefile.am each create a=20 > opcodes/libopcodes.a and bfd/libbfd.a by copying over from the=20 > respective artifact from the .libs/ at build-time. this forces static linking of libraries that are possibly available as shared ones which isn't really what we want -mike --0bjewhI3UvHlAxo2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNihpYACgkQQWM7n+g3 9YECmhAAvJBvGBC46I33AzRXRsqH3lZ8WNjWxo6/LwFfSbxr9QSosH6EoTGa0dy1 hyBJSlM3D/J18Qbr/Us7u0Di+c7C5hP1wP4U4XdFVqZ3j39awcXcK7u42TwFnAnS gzeHYgm6duxjwAapuONVCltGjRKxQebgokldJnjyGIs2QfgGgm1h1Q8hd4+IGjpJ CJIK45jZHJx8WoY4GfazVQ0SAPd2LSUqbkQXN01qhmocymKFyIvtUVWP2xKGnuBp RtlCXyn570QdEIYUGXz1/ENsx+t0wxkknl/X+6ksnCHtAn5GxQO0zC8oBFnyijqn D+NCSXq/PTPNcz/Oimn6x+nNgFOlZPQj4ZvX1Ayow6mOeTbIE5g5CoMSH2+0dbE7 poXDGQ6SrX/uF03gyKJFLfuEZmkcf522tEICxhKehzMfV6i9JPQ3lk8zI0atleup Y5QVrr0dBgRDZSY0bkvsK+w83t5/IxC/ZSq6R94CwQpV60ghgSiV4vT1ojzy34v3 C7gOqg7KDvB1uVD1cOl21ZuEEBZtd6BhT7fDB9WeCwV0rzEk/4iakffc1psYxov3 YGqlZCMnpgoomKPqV3bSvQCPVKxsswkwd5JQ1gqQ9aohbthnnDALK0UZd+bMmGfy i88/XwWNm7nkFwZpIHATIEgg7CM/JmSPYTSkvUoJ7ym3vMtsoy8= =KlBJ -----END PGP SIGNATURE----- --0bjewhI3UvHlAxo2--