From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id A5A4A3858C30 for ; Thu, 3 Nov 2022 15:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A5A4A3858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 44D7E3410C8; Thu, 3 Nov 2022 15:27:36 +0000 (UTC) Date: Thu, 3 Nov 2022 22:27:34 +0700 From: Mike Frysinger To: "Jose E. Marchesi" Cc: binutils@sourceware.org Subject: Re: [PATCH, V3 10/15] gdb: sim: buildsystem changes to accommodate libsframe Message-ID: Mail-Followup-To: "Jose E. Marchesi" , binutils@sourceware.org References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-11-indu.bhagat@oracle.com> <0f7e9a96-61fb-22a2-f71e-f3bead83579e@oracle.com> <87iljxuq74.fsf@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cptpKNg+fQYZByEa" Content-Disposition: inline In-Reply-To: <87iljxuq74.fsf@oracle.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --cptpKNg+fQYZByEa Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02 Nov 2022 20:11, Jose E. Marchesi wrote: >=20 > Hi Mike, Indu. >=20 > >> > On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: > >> >> [Changes in V3] > >> >> - Additional diff in sim/ppc/Makefile.in to accommodate libsfram= e. > >> >> This is needed to ensure --enable-targets=3Dall continues to b= uild. > >> >> - Addressed review comments by Mike Frysinger. > >> >=20 > >> > this doesn't seem to actually address my comments. you're still pok= ing > >> > the internals of libtool by accessing files under .libs/. > >>=20 > >> gdb does not use libtool yet. > > > > you have access to the source. you can change these things. > > > > also, gdb & sim are sep projects. >=20 > I see gdb/configure.ac uses the same strategy in order to locate the > in-tree libbacktrace.a and libctf: >=20 > if test "${enable_libbacktrace}" =3D "yes"; then > LIBBACKTRACE_INC=3D"-I$srcdir/../libbacktrace/ -I../libbacktrace/" > LIBBACKTRACE_LIB=3D../libbacktrace/.libs/libbacktrace.a > AC_DEFINE(HAVE_LIBBACKTRACE, 1, [Define if libbacktrace is being used= =2E]) > else > LIBBACKTRACE_INC=3D > LIBBACKTRACE_LIB=3D > fi >=20 > [...] >=20 > if test x${enable_static} =3D xno; then > LIBCTF=3D"-Wl,--rpath,../libctf/.libs ../libctf/.libs/libctf.so" > CTF_DEPS=3D"../libctf/.libs/libctf.so" > else > LIBCTF=3D"../libctf/.libs/libctf.a" > CTF_DEPS=3D"$LIBCTF" > fi >=20 > With corresponding substitutions in gdb/Makefile.in. >=20 > I agree it would be better to have GDB libtoolized so it could refer to > the .la libraries directly thus avoiding internals, but could that be > done in a separated patch set, also covering the other cases? >=20 > In the meanwhile, Indu could change her patch in order to look for > libsframe.so in gdb/configure.ac instead of gdb/Makefile.in, as it is > done for the other libs. Then we libtoolize. "the code is already in bad shape, so let's add more kindle to the fire" isn't a great strategy. hoping someone else will come and clean up the mess also isn't a great strategy ... usually that means it never gets cleaned up, and the tech debt just continues to build. so "let's do this as a followup" almost always translates into "i don't want to do it, and it's never actually going to happen, so let me merge anyways". i'm not saying that's necessarily the intention of the person making such a request, just that that's the practical result in my experience in the vast majority of cases. people, no matter how well intentioned, are busy, so without any pressing leverage (like "this is required if you want to merge"), it never improves. to be clear, i'm not a global gdb maintainer, so if you can convince one of them, then certainly they override. i am NAKing adding any such hacks to the sim code though. although that's a bit moot since i've already posted patches to clean up its libtool usage which means it doesn't need any changes for libsframe logic. -mike --cptpKNg+fQYZByEa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmNj3eUACgkQQWM7n+g3 9YFyQg/+Ivr2GK+WOO+xwKGgX8GzRjZnDIKF/I3Pe2gm4Ht5w4ofnJVfLqTYHmOr nhiY767t5cG8iGlVcHCEuOENZkUfEMdT1lZ6dxjsDJ1duIN4YUtUcFeCGbchjsi3 AIvBSLYFTUbFyTBjTFaLI24GmmRrcIR5MOfv3hZVJc5pNlU7sPLWBmGfLSJDuEbo fPC613CtZYcL/LWFgLcw7y9/BJhbckRk8OVqDX8fr/I2PXsRgb98tCYbtcRLtAoa hDUNXufnvPB9lZ1cOCmdmxswphP0A4dvA2lrQk6BF6Q/AhRZrAW9lpqqGbPUtGhM C4hHhYfs6JSNA2VLwUkD2CZUPCdhADPpjk6ENz6cTy7KmCUccLQi+USv3o809w7G DmmMJ+vuejTpiSSPHQBpKp2b0yrDrqyfW6gaxPBX2Pmb5cGOlA97Tl8HcGLhV0mu HyXm7rVGEOkM7R5556HEvJoBg9+j18nQiQYEr5EOFPjNOsEUiHwESXFenDPdAk0x LVq6IiNHnAbfBcm1VPkCYEO0kL1BiT3QbBOlVOTYXNU02bIW2yCL3F+rEQq+IQv3 60Mx+seWrrGlMTMTFhgj1Bq/ZtXeE/gGldPbRUGY0QJnDqytZ8JT95Ec6cPcrnu5 hhm1pDjn3kOrY6QocmuSG/3/TDa+7kyjl3HnM9NCa0MScFOYSSo= =bq3v -----END PGP SIGNATURE----- --cptpKNg+fQYZByEa--