From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 67D3A3858C33 for ; Mon, 7 Nov 2022 22:58:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 67D3A3858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id 130so12174290pfu.8 for ; Mon, 07 Nov 2022 14:58:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=82WKV7G+8rG274IvJsevF/eq/HG/Sc2c5LoLtXADJ2I=; b=WuEFuHMzq/qiWHSG+3RxSszpXEpf3kCiBt1pIkVVrc9Dd7INmlvmDgWULUyMekBkcr s8M9EwM+3MukuEVFqOOsuEy2HrETP33iKJs9lKUX+E7D+aXWccCz4wzeODhHIWud7g/P +uwAsGQA/QEvugiLJKosxCDs+ixCJiF1goQGXLTPsR4gUQ2GRgVkySkjNS8pmYEjd9H2 8wJLflwEnx/PemvbycG9Gx9PAdUdImhDbVY4I4hVWwmYlwxv7BJ8LwEbib5y5MmluxKF jifOvg8psJCBY64ncwKBsqmsWsK/U4nzryrBHuPa9YdtYUHSnGA3e7rdCA3fKgwEq5yd 6sxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=82WKV7G+8rG274IvJsevF/eq/HG/Sc2c5LoLtXADJ2I=; b=E6/I9W+tMR4BYYePkGx5SByzN7J91JS1OMMwGbbMSRwCnSOP39+Z5VSs0pZZ1cO6Rc xKCengW6xTuVw9xGHKq14zbr2s2N7A44MWXq8rlb/JTSgd3AmFHp8DO2PNDsKUpRV+JA 5Y6EdPN/QbPkfzc6uBSeDFObFFNqGwhJMcaJ7r7mAPKnsYaszpEk5/tGBWs8AJHDlh8g 4jYsjf/oyMbv/PZM5U5r+y9WMfdfF45TENtaNLTY+J3cdx04D2d1gCWT1A8eZL2rBB2X Ly3FIjbq7jk2dxGtPIXpCy3D8x3kDXiqyrCJX53zTg/QmPsNoBnzWM1Mj7F9IqTjJxsV 3noQ== X-Gm-Message-State: ACrzQf1zo1UghLn5NtHS+OipolAbyIZcFQw4U2VNmk6muTEkz2kF1SDM mYHbrut527pV9Sqkn2CWCESE7cVdWVg= X-Google-Smtp-Source: AMsMyM6V3JovOijiflU2wxGyo4VNrivY4nWj9RyQMQ1jACgTCnRkbrjR1Wlg6sq8cCjsA701B7AGdA== X-Received: by 2002:a05:6a00:1822:b0:56b:f29d:cca1 with SMTP id y34-20020a056a00182200b0056bf29dcca1mr53686113pfa.65.1667861888459; Mon, 07 Nov 2022 14:58:08 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 72-20020a62194b000000b00562677968aesm5005140pfz.72.2022.11.07.14.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 14:58:07 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 4F31E1140234; Tue, 8 Nov 2022 09:28:05 +1030 (ACDT) Date: Tue, 8 Nov 2022 09:28:05 +1030 From: Alan Modra To: Zac Walker Cc: binutils@sourceware.org Subject: Re: [PATCH] GAS fix section alignment for aarch64-pe Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 07, 2022 at 06:53:35PM +0100, Zac Walker via Binutils wrote: > For the aarch64-pe target, section alignment for various values of > '.align' causes writing of coff files to fail. > This patch performs aligning in md_section_align as opposed to the > original approach in aarch64_handle_align. The change is specific to > the aarch64-pe target. This can't be correct since HANDLE_ALIGN and md_section_align perform quite different functions. I don't think you should be changing aarch64_handle_align. For example: .text .p2align 4 nop .p2align 3 nop The second p2align needs to continue emitting nops. (Also, please fix your email client to *not* format lines. Wrapping lines and changing white space breaks patches.) -- Alan Modra Australia Development Lab, IBM