From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 77AE53858D1E for ; Thu, 10 Nov 2022 09:00:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77AE53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id g62so1358839pfb.10 for ; Thu, 10 Nov 2022 01:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9CI0JwYfMudtkYa9RqEziDj2llHxCgb1Rry7Z4a/0h0=; b=d+NxhtwgdOgaNkFqHfSOld6DiOk0n/ld+8iID+bi/c5mrzi1B+eI1t2XCJ7Mbj1Qm9 WKgWioC6Yq34Pll3QuPS3J4zgCjEQ2PjypynChTl8kot1DxGbpH98xEu1LqZZL6MMRuA 2QL1enCQXf1/wG2aLvYZ+3nIIcdatbyXO7gUNr8oNvpaZFPpTkMlIcc8XSWNvW17/wrQ T03e3neiTP48IC9QJ9HPvJggP8EGZgDd69h/GtXf2tICqgHbuYvVdS4/KqMBWv9+Jgi/ Zpp3QpSusmrxLCRVy0ur9CrgEaFXGaCFPz6NFlB4q40njNQnl2bcpg7zA75DZOaIo9cr hEvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9CI0JwYfMudtkYa9RqEziDj2llHxCgb1Rry7Z4a/0h0=; b=3EIxAEuuUBwq7VDwKBHk3lfy/PvzbKNje3qXq1LTOiaEaWRaAkmjOVaiQ0alF4N3UC TGjw0UQC2xNqeyDlB6vuFyILD5j8hM1t3n6hIYrTs677HmQnjU2JfGdxRkcy073TNxuO +DQpif5q9uCdwZeJyh7kkd5KbfOWfXMu0qaIcDMd8vBBrAkQo4ywWVb0whAVgBVILOwO HwJ11yWYdBK+bA352Ar4pSsxUzGqVhBXZKd2LPtXB7d9UMhxAyzK9KmEVE6J3Ne7L6n/ QV7S8TGfY2O5D4cFCN6g+91CT4Cecbe/ni9fQHhm5QVgUiTFqGIoN91ABEGBnRtkxQOq uviw== X-Gm-Message-State: ACrzQf3ULpaknaXzoV1stF5hQ6RQ/TTU+a8nlrjG3rI3fTBrP0gwnc+f KXLcNPlJGZiLBS1FEL/kG/5wZVO82WQ= X-Google-Smtp-Source: AMsMyM5hYp5No6l9ufrV52HJdQRDMvu4OOJDK6r3nOuqxzskaqpOGz80N9n0Vo9w1mQ3Vd7lrjlmng== X-Received: by 2002:a05:6a00:179f:b0:562:d5be:adc8 with SMTP id s31-20020a056a00179f00b00562d5beadc8mr2151858pfg.50.1668070837877; Thu, 10 Nov 2022 01:00:37 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id u7-20020a170902e80700b00186fa988a13sm10797073plg.166.2022.11.10.01.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 01:00:37 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 99AD21142DD4; Thu, 10 Nov 2022 19:30:34 +1030 (ACDT) Date: Thu, 10 Nov 2022 19:30:34 +1030 From: Alan Modra To: =?iso-8859-1?Q?Cl=E9ment?= Chigot Cc: binutils@sourceware.org Subject: Re: [PATCH] ld/testsuite: skip ld-size when -shared is not supported Message-ID: References: <20221109162611.760465-1-chigot@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 10, 2022 at 08:54:04AM +0100, Clément Chigot wrote: > On Wed, Nov 9, 2022 at 10:37 PM Alan Modra wrote: > > > > On Wed, Nov 09, 2022 at 05:26:11PM +0100, Clément Chigot via Binutils wrote: > > > * testsuite/ld-size/size.exp: Skip when -shared is not > > > supported. > > > > What does this catch that isn't already covered by the target test? > > It does in a wide approach. But it doesn't allow custom targets (as I > do) where shared support is explicitly disabled. > It might not have a big impact but it looks logical to me to check for > -shared (both linker and compiler by the way) before running any tests > related to that. > I've pushed other similar patches recently (see ld-arm or ld-shared). OK, the patch is fine. -- Alan Modra Australia Development Lab, IBM