From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id D014E3857C51 for ; Thu, 10 Nov 2022 10:12:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D014E3857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id 130so1542142pfu.8 for ; Thu, 10 Nov 2022 02:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=eEW591YS0JZucAn2D8gFufdcGvvdF786q2p0CgsuHu8=; b=GkdVFzprG/miR0vTpyLlEv3dG6EeZ0zIuorYkLT9LEv3+nqFJRz3yRFs1hyV/ww8Hj b1Lj7caXt54g8PJqK+HIoKC/17QygWdtWYmHlwpMYLjtLXvG43X1GrVpby/crZ2ckpTx 9hQU9/t9dpgnNDqsgycrk2sU53tcGVQHgnWlH0lj4L5acX7xo+FzBUNpJj8MvGzol1JU /RGwLB1SqIOIIkt3bApoT5e7H/mSPmgmpruFC5odGz41jrBFFrbOjbVQPaC0m7ouQI7P vWP5sTlWgcW0hwpJmu7LN5DscDx1AVV1rZYtgCu37YhVOVBiYlpnDeWd2OklegBFOIw7 w2Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eEW591YS0JZucAn2D8gFufdcGvvdF786q2p0CgsuHu8=; b=a6Y1stUsl1ZlxbMxC5ObS0bvOdDJdxLB/eTlSHQln+8AamZKVdFru30HdZqdmnBAe2 gQ2rmKMFKi8I1K5xiBe54Wq581dpAGl/yP+/OfAjxQsFtPQKw19godr3QO/46GX0ST1Z sx+qPAlxBlZJIWW+Lh4gaiGaF9+5ACzYz9qp+OkyG3RhFNuXtSvIvHVnnp8fQU2VqvMx wo4Nxdd53/sd4lgYESv92D2PyNMbzTQ2WkJe0Bt6kAGLyeRgLcrEN8dRHtDvcF+ggD/1 OoOMT7WorYeNrk6K2Olj+D9e3gSJLqFxLiBl1lnigGuqIKAGnF2SiLrVfN1yeQRO8pBF VEbw== X-Gm-Message-State: ACrzQf2BEqMFQzOhsVaXWzOjJEloPclsrJyRzY/RaCxu9pGUVf/ZK98Q fjvXBCkBq961uU0kTuUPQiyLy79xDw8= X-Google-Smtp-Source: AMsMyM7TPQ92VJbnrQhC+eZ2VnyoCHgIOdNVQTEEnZGozmMea61ffANwFiObQTfJZYU/ppLsQmhpeA== X-Received: by 2002:a63:7d43:0:b0:46f:8466:4de2 with SMTP id m3-20020a637d43000000b0046f84664de2mr54278982pgn.478.1668075157349; Thu, 10 Nov 2022 02:12:37 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id z11-20020a1709027e8b00b00186f81a074fsm10723633pla.290.2022.11.10.02.12.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 02:12:36 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 4360D1142E79; Thu, 10 Nov 2022 20:42:34 +1030 (ACDT) Date: Thu, 10 Nov 2022 20:42:34 +1030 From: Alan Modra To: binutils@sourceware.org Subject: mach-o reloc size overflow Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * mach-o.c (bfd_mach_o_canonicalize_reloc): Set bfd_error on multiply overflow. diff --git a/bfd/mach-o.c b/bfd/mach-o.c index 664ff44a8e7..bacb1a6252d 100644 --- a/bfd/mach-o.c +++ b/bfd/mach-o.c @@ -1663,7 +1663,10 @@ bfd_mach_o_canonicalize_reloc (bfd *abfd, asection *asect, size_t amt; if (_bfd_mul_overflow (asect->reloc_count, sizeof (arelent), &amt)) - return -1; + { + bfd_set_error (bfd_error_file_too_big); + return -1; + } res = bfd_malloc (amt); if (res == NULL) return -1; -- Alan Modra Australia Development Lab, IBM