From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 1D57B3858D20 for ; Wed, 23 Nov 2022 12:28:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D57B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42e.google.com with SMTP id g62so17169252pfb.10 for ; Wed, 23 Nov 2022 04:28:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=RQ9rQuvXiAikKTSBDH8zN8LaBw2tEGTN9y2K1bGkkrI=; b=TNf/QZ3XSkAnmlnbhAeX5spA/p5TwVMva4XTBay68zkzjkNGWh11rPD8/VigP6p4ud 5ckxrUvMjyXAPztqErM0GtGWAo2YmC/h7MUGeKKsvZ9lFgud1uJKjTos+48IYUbDai7f 6jVfcZ0lULL3g4HsHhRXZjq/C8rkER9iQyExfdv1DM3S3djfZYUvGR6vkZ1UpbfwV/ib rmfotMX1FIPv15EuEF870lOt9MYWMdHx3xSqpaAvb39VglWyAHt69Y6hVVY4Xz+g05a8 xZG4dutQnQsvXxttNbbQGYnA1HsbEdcU82SKRW0Mg0MgPKvCwx+2CR/BX9H7bsJl+NG7 ZM5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RQ9rQuvXiAikKTSBDH8zN8LaBw2tEGTN9y2K1bGkkrI=; b=EjNz2zcei6+22nmZxza9BUdsOKE9waLin5f1zJ991t7gcJzIRX9hpmJJvDkEvsCFKB 05XGuWHxA/BJhG/9bPeYXm5fbJcaANtubI2zYyUhAq1tDxHFmXowXEnlWdiSq8Evi/xZ KXzcdNbnwGxNjDCIKY50c/LZ6hHg3+4Ro3qK3FtPqNhk3rm3g/GMz/wU57uBO0nW+6fd L7JYvUlmOjdCgM+lGLmVz66axEwslh/djPWD64FE6Y5v/HIJ8j3rhRSg9432wMkoT9SH 9zQ4SpLgXkkkFP4mSDc/0yBg0xdwByrS025Xd5j3dr+Gji/X7/AcuGIxbbs3l2pNqFgL cTiQ== X-Gm-Message-State: ANoB5pnfZ6BkxN5/HwgcqsJorJgRNJFMjcjSYSH5bxtbDMmnzdppnQdV MzciMpE/4jYMLF2xl3JL+hO7VkHGoOk= X-Google-Smtp-Source: AA0mqf4T4EwmB8yv/w/J3xOYvDJrRTU8vL5nDGwrqjK/VbfXXXroWWLsJAM1M/D24mDAqrxqcKAwRw== X-Received: by 2002:aa7:9149:0:b0:574:5637:8172 with SMTP id 9-20020aa79149000000b0057456378172mr2780267pfi.2.1669206502613; Wed, 23 Nov 2022 04:28:22 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id j11-20020a170902da8b00b001894881842dsm1351343plx.151.2022.11.23.04.28.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 04:28:22 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id CDCEC11424B1; Wed, 23 Nov 2022 22:58:19 +1030 (ACDT) Date: Wed, 23 Nov 2022 22:58:19 +1030 From: Alan Modra To: binutils@sourceware.org Subject: asan: NULL deref in filter_symbols Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: If tdata->symbols is NULL, make tdata->symcount zero too. This makes wasm_get_symtab_upper_bound return the proper result and stops cascading errors. * wasm-module.c (wasm_scan_name_function_section): Clear tdata->symcount on error. diff --git a/bfd/wasm-module.c b/bfd/wasm-module.c index 2c2c6c72863..c96665b6e91 100644 --- a/bfd/wasm-module.c +++ b/bfd/wasm-module.c @@ -359,6 +359,7 @@ wasm_scan_name_function_section (bfd *abfd, sec_ptr asect) error_return: if (symbols) bfd_release (abfd, symbols); + tdata->symcount = 0; return false; } -- Alan Modra Australia Development Lab, IBM