From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D3E3F395BC39 for ; Wed, 16 Nov 2022 17:09:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D3E3F395BC39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 6A108340DB4; Wed, 16 Nov 2022 17:09:37 +0000 (UTC) Date: Thu, 17 Nov 2022 00:09:35 +0700 From: Mike Frysinger To: Michael Matz Cc: Jan Beulich , Alan Modra , Brett Werling , binutils@sourceware.org Subject: Re: [PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32 Message-ID: Mail-Followup-To: Michael Matz , Jan Beulich , Alan Modra , Brett Werling , binutils@sourceware.org References: <20221114150348.112815-1-bwerl.dev@gmail.com> <8c1844c9-4b04-0200-c24e-c33009562477@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oHe0zqHmwKoJ5X8Z" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_NUMSUBJECT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --oHe0zqHmwKoJ5X8Z Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 16 Nov 2022 16:13, Michael Matz wrote: > On Wed, 16 Nov 2022, Mike Frysinger wrote: > > are you claiming that current gnulib versions can't support even those = old > > versions of glibc ? i'd find that extremely surprising, and really sou= nds > > like a bug that should be taken up with the gnulib folks. >=20 > No. I'm claiming that moving to gnulib is work (even if perhaps not=20 > much?) and change and I (personally) don't see the need to invest into=20 > that work and deal with the change. Had you asked "should I look into=20 > using gnulib in bfd" my answer would have been "well, try it, why not?". = =20 > But you asked "should _we_ look" (aka should someone do that), hence my= =20 > answer was in the line of "perhaps, but why bother?". you're proposing adding a not insignificant amount of custom portability lo= gic and making the readelf code harder to understand & maintain while also not fixing the same bug in other binutils/ tools. it is perfectly reasonable to ask you to not add tech debt & make the code base worse off for everyone el= se to maintain, and instead focus on a common solution that the GNU project is already heavily invested in. this is, of course, the "GNU Binutils" projec= t. -mike --oHe0zqHmwKoJ5X8Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmN1GU8ACgkQQWM7n+g3 9YFzAQ/+LjBSBFbGHPGsDgdHv9mE+y+oc7bRv0ow76vV1ogBZ2O9aoLA3422ffWQ dDJfwDvB5bTQe0XZCF+QxjfguMQDuoYqTOojw1D0of3rsb/xq2h47GoAORuVfURl 6bxRvJpr3Q1+Qg1IYbdgIbSeOyq6ntqKnApy+mtO36Yiqm8AqJ3e7za1eigHv9fo Ku5ksGROQAdALTiQz8NJ9UUMdiNezh9ZBEXsPkoZNvOEyoXdRVN0xZ7W5FqjTGwO fnM5/OPaKI5EjOL6kTTX0O1I7fu9uueNdjUtKSGaydNHPSRepO8VBTN3rIsVO8V4 x/ix3mRGeQQ9mfxeZlfZ0mJIDtwQfqtWChJM4NWn28MVbOZr4y1/sXkpAyPSENet 45Csq87t662p5iCKtqbwy9nPzipuISePMAWDgSxru3iIK7dZplLrG4IdFMYST6Gk KW2wnP8hlNb4IFFsAcIkvIW8niEbR9JJQJWNYpgelazBlxy9BITOiUbcCZV+fMP7 PThMAteCXVlatuOI8jcFvwq7neZmMRVZut3OdETtlGCJE5X7xzYr38yXoOcOF+ds RtsUkVx5yut45L8QfXbi8nJMDAve+iGle6XoUBTVSQHiWRqriJQUO4jvTrQOtD/6 2dkFrtg9pokg8OCqlMbLvFEufODgZFgf7cTO1XjcwA0hxgqLXG4= =2OwS -----END PGP SIGNATURE----- --oHe0zqHmwKoJ5X8Z--