From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id C99F7392AC2C for ; Thu, 17 Nov 2022 03:29:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C99F7392AC2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52a.google.com with SMTP id 6so819340pgm.6 for ; Wed, 16 Nov 2022 19:29:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/CtgZ4SY+SMNvWdScx6RRtHVS6ehRfTi2xw8KXbsy+g=; b=HKIc8klnGz/H6iDVArn7q6C0+UpPR8MmlzJJnvVJuudjMbzq3jMA2F3tu1ZqIquS60 kmbE549CCXeeXXpbhuzUavNvstlSN4EKt+4HSKMZTJmWUzYanJ7KdyQo5XVzF7GYXz2P mro+mBYbLYL18is9/j2xPU0YdWOIGzP5XOt7So5WicP/wtzJLcaoCJ5TrI2dFh0VNZk1 wPH5HrvtrOkCZ7jooA3XClOcaTLiNxAPoHpvZxYxJMHZO5BDrj2MwW/dh+iv6ymGgCjH 45ZnIndvzQNXEyboFwljWj4YjvtysAN5OK8VvErmb7IiPQZgcalGueW2M+5RosQtXHaq SLnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/CtgZ4SY+SMNvWdScx6RRtHVS6ehRfTi2xw8KXbsy+g=; b=FRybYTg7Lx5Lx0NIkFerUMC7sJ2Adbtb24iSRig0ZFa+g4DL9qgoD91gmqEJEC78TK VVQdBtnk8qzTFQZN8Kg/ITv+mN/8dr23SO0TKyJpGS2i2HWCiH//8nsmiqd/H9MVixlf vuRyM0oZ6Vl7b97uQMOVWfisqPgcRmhgbuswHvGnKSRsGlgDC58OQaeMVsu1oKpaHOQ2 b38WRaB8BLYH9Ayh79mAWIefyJPuT9Gl6kaqsrpkw5lzcZQ3Ql1xUsyEdErgK9d2IzAj ceb7qbac+Y7nbZ80qHEq1oKCP5jfTQVneNjvPAZvoImgVzmAiYNtgmZ46dsYPvSs+qsn qqhA== X-Gm-Message-State: ANoB5pmeTW8AiTl/KqipxACnJrJUPTO4aKjZZbsI39rqyZrIBO7r8l/A a4QqQMMGmByP9noUzWee64lB8xI87M4= X-Google-Smtp-Source: AA0mqf6UBuBG6VwtzxoFxwTGrJuoeBRGsCLACqNtNJsiX+FJ5MC+SlHPOsQcpo53y7gJvDC2sMlBEw== X-Received: by 2002:a63:2160:0:b0:46f:f26e:e8ba with SMTP id s32-20020a632160000000b0046ff26ee8bamr379849pgm.250.1668655775875; Wed, 16 Nov 2022 19:29:35 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id o38-20020a634e66000000b004639c772878sm10565158pgl.48.2022.11.16.19.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 19:29:35 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 5AFD511405E6; Thu, 17 Nov 2022 13:59:32 +1030 (ACDT) Date: Thu, 17 Nov 2022 13:59:32 +1030 From: Alan Modra To: Indu Bhagat Cc: binutils@sourceware.org, zac.walker@linaro.org Subject: Re: [PATCH] [gas, aarch64]: fix build breakage for aarch64-pe Message-ID: References: <20221116232132.1009459-1-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116232132.1009459-1-indu.bhagat@oracle.com> X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 16, 2022 at 03:21:32PM -0800, Indu Bhagat via Binutils wrote: > --- a/gas/config/tc-aarch64.h > +++ b/gas/config/tc-aarch64.h > @@ -239,6 +239,28 @@ struct aarch64_segment_info_type > /* We want .cfi_* pseudo-ops for generating unwind info. */ > #define TARGET_USE_CFIPOP 1 > > +/* CFI hooks. */ > +#define tc_regname_to_dw2regnum tc_aarch64_regname_to_dw2regnum > +#define tc_cfi_frame_initial_instructions tc_aarch64_frame_initial_instructions > + > +extern void aarch64_after_parse_args (void); > +#define md_after_parse_args() aarch64_after_parse_args () > + > +#else /* Neither OBJ_ELF nor OBJ_COFF. */ > +#define GLOBAL_OFFSET_TABLE_NAME "__GLOBAL_OFFSET_TABLE_" > +#endif > + > +#if defined OBJ_ELF || defined OBJ_COFF > + > +# define EXTERN_FORCE_RELOC 1 > +# define tc_fix_adjustable(FIX) 1 > +/* Values passed to md_apply_fix don't include the symbol value. */ > +# define MD_APPLY_SYM_VALUE(FIX) 0 OK, but seeing as you are moving things around, let's move the above three defines before the #else to get rid of another #if. > + > +#endif > + > +#ifdef OBJ_ELF > + > /* Whether SFrame unwind info is supported. */ > extern bool aarch64_support_sframe_p (void); > #define support_sframe_p aarch64_support_sframe_p > @@ -268,25 +290,7 @@ extern offsetT aarch64_sframe_cfa_ra_offset (void); > unsigned char aarch64_sframe_get_abi_arch (void); > #define sframe_get_abi_arch aarch64_sframe_get_abi_arch > > -/* CFI hooks. */ > -#define tc_regname_to_dw2regnum tc_aarch64_regname_to_dw2regnum > -#define tc_cfi_frame_initial_instructions tc_aarch64_frame_initial_instructions > - > -extern void aarch64_after_parse_args (void); > -#define md_after_parse_args() aarch64_after_parse_args () > - > -#else /* Not OBJ_ELF. */ > -#define GLOBAL_OFFSET_TABLE_NAME "__GLOBAL_OFFSET_TABLE_" > -#endif > - > -#if defined OBJ_ELF || defined OBJ_COFF > - > -# define EXTERN_FORCE_RELOC 1 > -# define tc_fix_adjustable(FIX) 1 > -/* Values passed to md_apply_fix don't include the symbol value. */ > -# define MD_APPLY_SYM_VALUE(FIX) 0 > - > -#endif > +#endif /* OBJ_ELF */ > > #define MD_PCREL_FROM_SECTION(F,S) md_pcrel_from_section(F,S) > > -- > 2.37.2 -- Alan Modra Australia Development Lab, IBM