From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id B1B38384F4B9 for ; Mon, 21 Nov 2022 21:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1B38384F4B9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x535.google.com with SMTP id b62so12344860pgc.0 for ; Mon, 21 Nov 2022 13:21:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=gYqzssUjBQYqkIkIo0UcegVVaim5/A73T6vFLdbTdAg=; b=VorNC2+0/enCHb/eEYzi4L4GE/1LRJLi9j46Fug2BdulmCJJyZ86Ut898Ic/BOzoLY kO349YNd0BgC6D5Lh5rYu3NT/e09qlYbN3aVd+LUzXmvTJI6c/SGSfZvXstbx8UVF5i9 e1dowZpmjwL5nEEJgPiw9yCI6uE/TqSSDRlHnTIYsQTkye+/3/lANwUJMnyddiXYVfsC ZVIEoFP6HLTj/rPklWTq3WT+2ufUqCt+v6AHjuHYx54fZyx/WGZVfP5G78cuFfVxH0Hv ssnTrcY6pYPnL2h/ssa+HHrokJo2fHtnnF6Hv03s2sPzPXwxwmuwu3tvbuTyrclxpZbQ 3ccw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gYqzssUjBQYqkIkIo0UcegVVaim5/A73T6vFLdbTdAg=; b=xLFVG8cdL7IbqlgRl0YY5+syeJaKZ+6mJJkejMyDrdNwutpVSflT59HLVhgTd4HCRI beWbs1lH6y+8DasZqPo28qxPLHPcINL7b3dmq9Zpc3n+KrzdHwEwPOfFX1DP3r6k6Y7z EhPhHA2h91JOSM1bpDceYRNszi2al/KduqrCvXp4Nhcxzdp84eWceffL5lGG5p9iO5pl 8wqRtzMbWobc7gqW9WfuNuKEFPdrW5OkLlUx68KfpwX7H8qfO0byZWtGhrl8QbgLUyvi L3JtPhlOijUeezPAFO1nR+q4RFF8vtTRVvJlMbLui30e6o1Uo0AY8eiDHCINUpVHnq20 bLag== X-Gm-Message-State: ANoB5pke+w7RONXJVcOnI/Dr2G39vTzYx/hA5M86tKgAbeIyFqBsxfJ9 P6qKWokvgYumWj4V7cdznz7t/bko8Qw= X-Google-Smtp-Source: AA0mqf7vUHl/grGA0pG7cfhguQFA29Cp+unO0T6KbHXGArLkn8GddjEarzE+L9FniI3/vum4QlTjDQ== X-Received: by 2002:a62:2504:0:b0:572:6e8a:99ee with SMTP id l4-20020a622504000000b005726e8a99eemr683049pfl.56.1669065663633; Mon, 21 Nov 2022 13:21:03 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id g17-20020a63e611000000b00476c2180dbcsm3551087pgh.29.2022.11.21.13.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 13:21:02 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 32B9C1142E46; Tue, 22 Nov 2022 07:51:00 +1030 (ACDT) Date: Tue, 22 Nov 2022 07:51:00 +1030 From: Alan Modra To: binutils@sourceware.org Cc: "H.J. Lu" Subject: Re: ld: Always output local symbol for relocatable link Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Remove this code dating back to commit 98790d3a95fc entirely, what it was trying to do is done elsewhere. PR ld/29761 * elflink.c (elf_link_output_symstrtab): Don't handle symbols in SEC_EXCLUDE sections here. diff --git a/bfd/elflink.c b/bfd/elflink.c index 81b34129463..a141c9eb0e8 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -9995,10 +9995,7 @@ elf_link_output_symstrtab (void *finf, if (ELF_ST_BIND (elfsym->st_info) == STB_GNU_UNIQUE) elf_tdata (flinfo->output_bfd)->has_gnu_osabi |= elf_gnu_osabi_unique; - if (name == NULL - || *name == '\0' - || (!bfd_link_relocatable (flinfo->info) - && (input_sec->flags & SEC_EXCLUDE))) + if (name == NULL || *name == '\0') elfsym->st_name = (unsigned long) -1; else { -- Alan Modra Australia Development Lab, IBM