From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 7620B385B1A8 for ; Tue, 6 Dec 2022 22:46:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7620B385B1A8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102a.google.com with SMTP id fa4-20020a17090af0c400b002198d1328a0so2509269pjb.0 for ; Tue, 06 Dec 2022 14:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yHrTEhoOXt0wv/yu2Ce7P2eZOGVMLzDIS5DIFr0c9TE=; b=llDgDuMOQk7mjV4QqT58EIAhihBdhj9k75m8Wi5525ECkIICXKMfK0lrMO8VoYkyr9 pNmOVu+p35Y6qpLMpQvIFA759uJjDrlPltisHBwylZqxuDTZ8yGla/huuFGEbGMnUPhq 7iAMcqV8edTZxBM+3k8oExELhRTNQcp0io6KnAe4GLQUW73nH7TlDGASF3Z0jubTYHp+ lnttZZK7KHJa/A16gH8AGXrtv34y88CL8tmDtmB2do4FFiXtzUyEbzpSa+L7odU2xmBp iZe0FSH9rKvQESXyXkb5cVc4+vAKNNCGfE81o9grxlG4s0xNKqSodjXI3lOXXshdLQSn Y47w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yHrTEhoOXt0wv/yu2Ce7P2eZOGVMLzDIS5DIFr0c9TE=; b=zH1rfuUD8V73QF3sGCVF3CEzmpIGArKRLmbQsJR4g9NRfDfA1PkHKAld0SWHQbmAQt 8tp4QzGBwTLnEtYwrxny2zVOiall5z2izMOuKytofT/WHyNjJrjSG2OQe54/X+QgKAJa 3CzOEuHTEQFQLDSsW0ILrvgvkeVFrPnITDG+ZBAKCMhJoycuiXlfaZOjXFtft/n6pkF1 nBREz/WIYOTi051bbN98p1Gkc09ZEFhlZ0rq4CJCeeCznlJw4syb0t52UxZRBwfGJegY zCuZmA0WY6SOsS/WY4xsVTKe3bApbgnzWJjjLn7VhwnPRE3rex03Le5toGKrBhiq2Jbv bEAg== X-Gm-Message-State: ANoB5pkc6yxxM8g1ARsNkAdv3P/LoKi/XuzglTKfZclzvdDlzApAkqfa j6EOlENdsZUCByumwFwiLTo= X-Google-Smtp-Source: AA0mqf4UjJ3ZI1FzrpBfziv1Dp3rtdBiy3IYWQgW2hIdIdOiWExQiElqRsTpB3lVLZmi0HYSbnBawQ== X-Received: by 2002:a17:902:8c97:b0:189:13df:9dac with SMTP id t23-20020a1709028c9700b0018913df9dacmr69849802plo.34.1670366777524; Tue, 06 Dec 2022 14:46:17 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id a14-20020aa794ae000000b005774f19b41csm1512557pfl.88.2022.12.06.14.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 14:46:17 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 8C78711409D5; Wed, 7 Dec 2022 09:16:14 +1030 (ACDT) Date: Wed, 7 Dec 2022 09:16:14 +1030 From: Alan Modra To: "H.J. Lu" Cc: Binutils Subject: Re: [PATCH] bfd: Avoid signed overflow for new_size adjustment Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 06, 2022 at 01:01:42PM -0800, H.J. Lu wrote: > This doesn't work for 32-bit program since > > sizeof (Elf32_External_Chdr) - sizeof (Elf64_External_Chdr); > > is negative and will overflow. > > We should use > > *new_size -= sizeof (Elf64_External_Chdr) - sizeof (Elf32_External_Chdr); > > instead. > > OK for master? Yes thanks. -- Alan Modra Australia Development Lab, IBM