From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id DBEBB3858D37 for ; Wed, 30 Nov 2022 08:10:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBEBB3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62d.google.com with SMTP id 4so15947644pli.0 for ; Wed, 30 Nov 2022 00:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=/OrQ0SJD96+PDloUDFhChkZsxWlCOS32kUd7wlSLdkc=; b=jC7noFjxxfqibFN7a+6Q/rpY/iyLrveVy0Xf1LZ/N7VRnDud4EDgISHP/fy1NfY6Nu KfM1XjYuflt8rjqP/imoUpe9XYxbM/kfHkV75YL1YqRiucOeBwugydOXYnO/5tOXrP2u a2bFKOnD7IaEsEH22dM6/rdJfbBUVrWP9AezmJH8kF0FQ6JEsiLYod702iwp7ErQ27+u K2FVVG2RMgwgZyaJHyGpdAFD1Kmwf3XJ50tk/yoLM3soHKCmQWdz03pdoggrhymmwVDe rGbsebqJa9XnuazkB80o231MZKjq1TG9/PvI6uxfoEJLBIuCoPQPO//kDeB7P6e5e+C1 MQ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/OrQ0SJD96+PDloUDFhChkZsxWlCOS32kUd7wlSLdkc=; b=5RKG/YL80QUbR/c1VWwUuHt8/H067pbNbRcvgQTy+7sIM1bhX7ot5TA7i0uTxG2goY 5d3dw/tP8aLTj9jZ8KIAy20de1sHHf3CfsOgD3EdHr5Rlhejih11K2OyBrZRLKjOpUNU iJXgAT0qNPB9H/mhXyl3piMo40/R70b+k/KHpGZ+WA+lbk07mZP+64S1V49qv6oEOXmY GYxqRvHbUrIfB+4new1aJ4jBbuHTkicG32+g8nlSQdkyrv+tJzmYeb1NiHbDbGrTlFAr eQb1STveDYSm+Pmfpw07E6qRSEAeaT2vhPGJguj/h8KumAky/iXEGcMQ9XXDX5SiIIXw WGMA== X-Gm-Message-State: ANoB5pkiHL+6PYOANK3TN+vZ4vSSIhVCegQY0nwrA1sonnu6C3Ij0rFf ogdBYLXNUay26yuDEAeN2e97wDUWfwo= X-Google-Smtp-Source: AA0mqf4kjWxtVwzAHD549iyrDCAi4RgPwJfdFXxuJJARusKwgUj713m0BVK7X7tkRmxxApHun9VaFQ== X-Received: by 2002:a17:90a:4c:b0:218:b187:d7da with SMTP id 12-20020a17090a004c00b00218b187d7damr48533533pjb.68.1669795845826; Wed, 30 Nov 2022 00:10:45 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:3420:73f4:d228:faf4]) by smtp.gmail.com with ESMTPSA id pa3-20020a17090b264300b0021870b2c7absm658485pjb.42.2022.11.30.00.10.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 00:10:45 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id EC1E31142D31; Wed, 30 Nov 2022 18:40:42 +1030 (ACDT) Date: Wed, 30 Nov 2022 18:40:42 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Correct ordering problem in comm-data.exp Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * testsuite/ld-elf/comm-data.exp: Build libcomm-data.so before attempting to read it to set ELF64. diff --git a/ld/testsuite/ld-elf/comm-data.exp b/ld/testsuite/ld-elf/comm-data.exp index cea03df2366..f46d69350b6 100644 --- a/ld/testsuite/ld-elf/comm-data.exp +++ b/ld/testsuite/ld-elf/comm-data.exp @@ -48,19 +48,8 @@ if { [istarget "mips*vr4100*-*-elf*"] \ append LFLAGS " -call_shared" } -# Set the pointer size according to the ELF flavor. -set AFLAGS "" -if [is_elf64 "tmpdir/libcomm-data.so"] { - append AFLAGS " --defsym ELF64=1" -} -# HPUX targets use a different .comm syntax. -if [istarget "*-*-hpux*"] { - append AFLAGS " --defsym HPUX=1" -} - -set testname "Common symbol override test" - # Define a global symbol. +set testname "Common symbol override test" run_ld_link_tests [list \ [list \ "$testname (auxiliary shared object build)" \ @@ -72,16 +61,18 @@ run_ld_link_tests [list \ } \ "libcomm-data.so" \ ] \ - [list \ - "libpr26580-1.so" \ - "$LFLAGS -shared" "" \ - "$AFLAGS_PIC $AFLAGS" \ - { pr26580-b.s } \ - { } \ - "libpr26580-1.so" \ - ] \ ] +# Set the pointer size according to the ELF flavor. +set AFLAGS "" +if [is_elf64 "tmpdir/libcomm-data.so"] { + append AFLAGS " --defsym ELF64=1" +} +# HPUX targets use a different .comm syntax. +if [istarget "*-*-hpux*"] { + append AFLAGS " --defsym HPUX=1" +} + # bfin-elf does not currently support copy relocs. setup_xfail "bfin-*-*" clear_xfail "bfin-*-linux-uclibc*" @@ -121,6 +112,14 @@ run_ld_link_tests [list \ } \ "comm-data3b" \ ] \ + [list \ + "libpr26580-1.so" \ + "$LFLAGS -shared" "" \ + "$AFLAGS_PIC $AFLAGS" \ + { pr26580-b.s } \ + { } \ + "libpr26580-1.so" \ + ] \ [list \ "pr26580-1" \ "$LFLAGS --as-needed -Ltmpdir -lpr26580-1" "" \ -- Alan Modra Australia Development Lab, IBM