From: Alan Modra <amodra@gmail.com>
To: Fangrui Song <i@maskray.me>
Cc: binutils@sourceware.org
Subject: Re: Compression tidy and fixes
Date: Wed, 7 Dec 2022 14:28:28 +1030 [thread overview]
Message-ID: <Y5APZGmht8ghjuUr@squeak.grove.modra.org> (raw)
In-Reply-To: <20221207032825.ooufkrniqye3uegq@gmail.com>
On Tue, Dec 06, 2022 at 07:28:25PM -0800, Fangrui Song wrote:
> On 2022-12-07, Alan Modra via Binutils wrote:
> > Tidies:
> > - Move stuff from bfd-in.h and libbfd.c to compress.c
> > libbfd.[ch] is really supposed to be for BFD internal use only.
> > - Delete COMPRESS_DEBUG from enum compressed_debug_section_type
> > - Move compress_debug field out of link_info to ld_config.
> > The idea here is to ignore what the user requested after translating
> > to bfd flags, so there is just one place where the user request gets
> > translated to what is supported. Similarly for gas and objcopy.
> > Fixes:
> > - Correct test in bfd_convert_section_setup to use obfd flags,
> > not ibfd.
> > - Apply bfd_applicable_file_flags to compression bfd flags added
> > by gas and ld to the output bfd.
> >
>
> If .zdebug renaming turns out to be tricky, consider making
> zlib-gnu output no-op. zlib-gnu is pretty obsoleted now and in the latest
> GCC, -gz=zlib-gnu is a no-op. (iirc) gas
> --compress-debug-sections=zlib-gnu doesn't compress a .debug_* if the
> compressed output would be larger than the uncompressed one.
What got me into looking at the compression support in BFD was
discovering I'd broken the COFF/PE compressed debug support. There we
only support zlib-gnu.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-12-07 3:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 2:44 Alan Modra
2022-12-07 3:28 ` Fangrui Song
2022-12-07 3:58 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5APZGmht8ghjuUr@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=i@maskray.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).