From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=KgZ8=4I=gentoo.org=vapier@sourceware.org>
Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	by sourceware.org (Postfix) with ESMTP id 89D76382A239
	for <binutils@sourceware.org>; Sat, 10 Dec 2022 01:07:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89D76382A239
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
	id 14B2C340E88; Sat, 10 Dec 2022 01:07:50 +0000 (UTC)
Date: Sat, 10 Dec 2022 10:07:48 +0900
From: Mike Frysinger <vapier@gentoo.org>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] libctf: remove unnecessary zlib constructs
Message-ID: <Y5Pb5CtPuEPiJeXw@vapier>
References: <20221209202118.4106688-1-indu.bhagat@oracle.com>
 <20221209202118.4106688-2-indu.bhagat@oracle.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="aZWbYQOfcAEgWgqC"
Content-Disposition: inline
In-Reply-To: <20221209202118.4106688-2-indu.bhagat@oracle.com>
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>


--aZWbYQOfcAEgWgqC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 09 Dec 2022 12:21, Indu Bhagat via Binutils wrote:
> -ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
> -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
> +LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"

$ZLIBDIR is zlib related ...

> -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
> +LIBS="-lbfd -liberty $intl $LIBS"

... but $ZSTD_LIBS is zstd related, not zlib.

commit message only says zlib.

also, you're still calling AM_ZLIB & AC_ZSTD which should be removed.
-mike

--aZWbYQOfcAEgWgqC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmOT2+QACgkQQWM7n+g3
9YERTQ/9G7YjAj4rU7n32oTDSDscSnUh8isIW7aF1HFdSy+TmfkPShWZ4N2Sv4FV
u2tkddYHY4UsQwftqUATAgr0BhCXEjMTEAjrI7phZCwTtN7aE+S+WcF3ordT1Amk
FEO7GPr/gyF55JRcNtZDfAQZWKi0qrGaBP5mykByFVsZPaMTImxZfn48rqFlPHex
GXha31prJgcYC/bW8+fLUH2U1cg12D5iKIAtqw04wknKVJrC8ANoMrZbJfbGVp7e
uqKjULXMEtnRlBdR/fsCWdgnrKvt7OnlL/5wFW41W/mmZjnup7jMbhIfDBSs9xPh
JR2BKRdZ6u01mE8SsJ+x7H/KwwbNqbKZmhb4m7vDe6QlU9tWz67l3QugW0RPk4Kb
LQSxvGrhoISBs/26j4PqFRlN/CSW97294Pv9HNfcSfgucNI5ttdC1BK2uCF1nlVS
DdERfb52GL+iA1itqeWHNt7kVP1UHi7HN4vPNUV30rXAaTlTCHRkuJGs4jBz5Opl
pvyQOi/TnRN3Foa4eMsZ13P8uoDk1JXRel90sA69rAB6Gzw8aLuIN9PWqf9yhzWs
VHOcJJN0E4hJ6B6XqqI6VJVLpAJxiLSnWHIHdh8MhN69Rrqb2KEFj5ASy7q3WVnJ
2AyrKjqNr+uEzdDZGAjaVimXlxLtDdh4dhimLmvgsZ0Ovbc7foM=
=zBpF
-----END PGP SIGNATURE-----

--aZWbYQOfcAEgWgqC--