From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 2DADE3896C18 for ; Sun, 11 Dec 2022 07:33:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DADE3896C18 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id D0577341301; Sun, 11 Dec 2022 07:33:43 +0000 (UTC) Date: Sun, 11 Dec 2022 16:33:42 +0900 From: Mike Frysinger To: Indu Bhagat Cc: binutils@sourceware.org, nick.alcock@oracle.com, i@maskray.me Subject: Re: [PATCH] libctf: remove unnecessary zstd constructs Message-ID: References: <20221211002622.564875-1-indu.bhagat@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6gbyb8FQ76fk2sAW" Content-Disposition: inline In-Reply-To: <20221211002622.564875-1-indu.bhagat@oracle.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --6gbyb8FQ76fk2sAW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 10 Dec 2022 16:26, Indu Bhagat wrote: > This patch is essentially a revert of > commit-id: 8818c80cbd4116ef5af171ec47c61167179e225c > (libctf: Add ZSTD_LIBS to LIBS so that ac_cv_libctf_bfd_elf can be true) >=20 > As the specific configure check now uses libtool, this explicit mention o= f the > dependency $ZSTD_LIBS is not needed anymore. >=20 > As for AC_ZSTD, it was suggested to clean it up (https://sourceware.org/p= ipermail/binutils/2022-December/125026.html) > as it is unused. Althought this patch does remove AC_ZSTD from > libctf/configure.ac, I am not completely sure anymore: libctf may have > plans to support zstd compressed CTF sections soon/later ? if libctf ever gains such support, it's easy enough to add back in. lgtm -mike --6gbyb8FQ76fk2sAW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmOVh9YACgkQQWM7n+g3 9YH6PQ/8Ckc91CFmbJqcFTmnRkvQ/7oTrFKMuITiZc+kVc9ZZdWh9s49QY4x6uqY CxqcLbZs8iVrwIWXTZU600FDn15qqWwwnSnVDVla0KNHQI/zb26MCTfAbWZTD0VK YQtanwAWe/vDAB/tZvsQGkDOx6+kn2dDFVulTySho0iJKGywnOx9qD8R627FTmeV uFf6Mi26qxvxJa+Pg1aFiaBZfuCK3s6Pylt0mxXRam1H592UwYu+sd99yE/ylOLR vowtoehCfvDJ4xPUWRfKrcl56iVfQRcZTFmUrIn7IRVBxwlp52V004IbFf+3E+I9 kl9tJyOM+4gfSwdqkB+wPjv/siTLkpXXKgArZ7VmzZ0TkJvGI+PGgR2fiLb5fZKX Wx3OfJfPMpsccHAg8a72DU6qZ308/uzi4+YB4aoGBJhNINHOm7U+aFTdCovcGo3Q smfAL2faHmwgfnLeh3WUvdmxI/UWwoiQ+R1Rwt5oUt2ZVp/6t6QYpUJj7wjr+G4b /AvelEoWadKVB2y5VEACkvutpj412YR8JtweeXGADhgRJylKY23S8UTNKEj69XMo L8sudCocN7rBg0AHr/QCE5XbwXcdg2fedVSoieHGFbPapjObkTvZneFqk9Toi4Uo 2vFvfEaY2RmsDb8Ur2gID1f3ySTz8eRTeNvd9jGxkwE9fMAWdZQ= =EYM+ -----END PGP SIGNATURE----- --6gbyb8FQ76fk2sAW--